From 51b5e27578e49baa02a3f3efb3d5200c5e1c9e9d Mon Sep 17 00:00:00 2001 From: Valentin Popa Date: Fri, 30 Sep 2016 17:10:35 +0300 Subject: [PATCH 1/6] TAS-1014 REST API - valid request returns success status code 200 with Manager role | Move people APIs from sites to people --- .../AddSiteMembershipRequestSanityTests.java | 22 ++-- .../people/GetSiteMembershipSanityTests.java | 59 ++++++++++ ...itesMembershipInformationSanityTests.java} | 72 ++++++------ .../alfresco/rest/sites/GetSitesTests.java | 104 ------------------ 4 files changed, 107 insertions(+), 150 deletions(-) rename e2e-test/java/org/alfresco/rest/{sites => people}/AddSiteMembershipRequestSanityTests.java (74%) create mode 100644 e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java rename e2e-test/java/org/alfresco/rest/{sites/GetSiteMembershipInformationSanityTests.java => people/GetSitesMembershipInformationSanityTests.java} (59%) delete mode 100644 e2e-test/java/org/alfresco/rest/sites/GetSitesTests.java diff --git a/e2e-test/java/org/alfresco/rest/sites/AddSiteMembershipRequestSanityTests.java b/e2e-test/java/org/alfresco/rest/people/AddSiteMembershipRequestSanityTests.java similarity index 74% rename from e2e-test/java/org/alfresco/rest/sites/AddSiteMembershipRequestSanityTests.java rename to e2e-test/java/org/alfresco/rest/people/AddSiteMembershipRequestSanityTests.java index 6d9aaca6f..01c3dad8b 100644 --- a/e2e-test/java/org/alfresco/rest/sites/AddSiteMembershipRequestSanityTests.java +++ b/e2e-test/java/org/alfresco/rest/people/AddSiteMembershipRequestSanityTests.java @@ -1,9 +1,9 @@ -package org.alfresco.rest.sites; +package org.alfresco.rest.people; import org.alfresco.rest.RestTest; import org.alfresco.rest.body.SiteMembership; import org.alfresco.rest.exception.JsonToModelConversionException; -import org.alfresco.rest.requests.RestSitesApi; +import org.alfresco.rest.requests.RestPeopleApi; import org.alfresco.utility.constants.UserRole; import org.alfresco.utility.data.DataSite; import org.alfresco.utility.data.DataUser; @@ -15,14 +15,15 @@ import org.alfresco.utility.report.Bug; import org.alfresco.utility.testrail.ExecutionType; import org.alfresco.utility.testrail.annotation.TestRail; import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.http.HttpStatus; import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; -@Test(groups = { "rest-api", "sites", "sanity" }) +@Test(groups = { "rest-api", "people", "sanity" }) public class AddSiteMembershipRequestSanityTests extends RestTest { @Autowired - RestSitesApi siteAPI; + RestPeopleApi peopleApi; @Autowired DataUser dataUser; @@ -43,20 +44,21 @@ public class AddSiteMembershipRequestSanityTests extends RestTest siteModel = dataSite.usingUser(adminUser).createPublicRandomSite(); usersWithRoles = dataUser.addUsersWithRolesToSite(siteModel,UserRole.SiteManager, UserRole.SiteCollaborator, UserRole.SiteConsumer, UserRole.SiteContributor); - siteAPI.useRestClient(restClient); + peopleApi.useRestClient(restClient); } - @TestRail(section = { "rest-api","sites" }, executionType = ExecutionType.SANITY, description = "Verify site manager is able to create new site membership request") - @Bug(id="MNT-16557") - @Test(enabled=false) + @TestRail(section = { "rest-api","people" }, + executionType = ExecutionType.SANITY, description = "Verify site manager is able to create new site membership request") + @Bug(id="MNT-16557") public void siteManagerCanCreateSiteMembershipRequest() throws JsonToModelConversionException, Exception { UserModel newMember = dataUser.createRandomTestUser(); SiteMembership siteMembership = new SiteMembership("Please accept me", siteModel.getId(), "New request"); restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); - siteAPI.addSiteMembershipRequest(newMember, siteMembership); - siteAPI.getSite(siteModel).assertResponseIsNotEmpty(); + peopleApi.addSiteMembershipRequest(newMember, siteMembership); + peopleApi.usingRestWrapper() + .assertStatusCodeIs(HttpStatus.OK); } } \ No newline at end of file diff --git a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java new file mode 100644 index 000000000..634f38684 --- /dev/null +++ b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java @@ -0,0 +1,59 @@ +package org.alfresco.rest.people; + +import org.alfresco.rest.RestTest; +import org.alfresco.rest.exception.JsonToModelConversionException; +import org.alfresco.rest.requests.RestPeopleApi; +import org.alfresco.utility.constants.UserRole; +import org.alfresco.utility.data.DataSite; +import org.alfresco.utility.data.DataUser; +import org.alfresco.utility.data.DataUser.ListUserWithRoles; +import org.alfresco.utility.exception.DataPreparationException; +import org.alfresco.utility.model.SiteModel; +import org.alfresco.utility.model.UserModel; +import org.alfresco.utility.testrail.ExecutionType; +import org.alfresco.utility.testrail.annotation.TestRail; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.http.HttpStatus; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + +@Test(groups = { "rest-api", "people", "sanity" }) +public class GetSiteMembershipSanityTests extends RestTest +{ + @Autowired + RestPeopleApi peopleApi; + + @Autowired + DataUser dataUser; + + @Autowired + DataSite dataSite; + + private SiteModel siteModel; + private UserModel adminUser; + private ListUserWithRoles usersWithRoles; + + @BeforeClass(alwaysRun=true) + public void dataPreparation() throws DataPreparationException + { + adminUser = dataUser.getAdminUser(); + siteModel = dataSite.usingUser(adminUser).createPublicRandomSite(); + + usersWithRoles = dataUser.addUsersWithRolesToSite(siteModel, + UserRole.SiteManager, UserRole.SiteCollaborator, UserRole.SiteConsumer, UserRole.SiteContributor); + + peopleApi.useRestClient(restClient); + } + + @TestRail(section = { "rest-api", "people" }, + executionType = ExecutionType.SANITY, + description = "Verify site manager is able to retrieve site membership information of another user") + public void siteManagerCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + { + restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); + peopleApi.getSiteMembership(adminUser, siteModel); + peopleApi.usingRestWrapper() + .assertStatusCodeIs(HttpStatus.OK); + } + +} \ No newline at end of file diff --git a/e2e-test/java/org/alfresco/rest/sites/GetSiteMembershipInformationSanityTests.java b/e2e-test/java/org/alfresco/rest/people/GetSitesMembershipInformationSanityTests.java similarity index 59% rename from e2e-test/java/org/alfresco/rest/sites/GetSiteMembershipInformationSanityTests.java rename to e2e-test/java/org/alfresco/rest/people/GetSitesMembershipInformationSanityTests.java index 6d06d5809..264beff65 100644 --- a/e2e-test/java/org/alfresco/rest/sites/GetSiteMembershipInformationSanityTests.java +++ b/e2e-test/java/org/alfresco/rest/people/GetSitesMembershipInformationSanityTests.java @@ -1,8 +1,8 @@ -package org.alfresco.rest.sites; +package org.alfresco.rest.people; import org.alfresco.rest.RestTest; import org.alfresco.rest.exception.JsonToModelConversionException; -import org.alfresco.rest.requests.RestSitesApi; +import org.alfresco.rest.requests.RestPeopleApi; import org.alfresco.utility.constants.UserRole; import org.alfresco.utility.data.DataSite; import org.alfresco.utility.data.DataUser; @@ -17,11 +17,11 @@ import org.springframework.http.HttpStatus; import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; -@Test(groups = { "rest-api", "sites", "sanity" }) -public class GetSiteMembershipInformationSanityTests extends RestTest +@Test(groups = { "rest-api", "people", "sanity" }) +public class GetSitesMembershipInformationSanityTests extends RestTest { @Autowired - RestSitesApi siteAPI; + RestPeopleApi peopleApi; @Autowired DataUser dataUser; @@ -40,73 +40,73 @@ public class GetSiteMembershipInformationSanityTests extends RestTest siteModel = dataSite.usingUser(adminUser).createPublicRandomSite(); usersWithRoles = dataUser.addUsersWithRolesToSite(siteModel, UserRole.SiteManager, UserRole.SiteCollaborator, UserRole.SiteConsumer, UserRole.SiteContributor); - siteAPI.useRestClient(restClient); + peopleApi.useRestClient(restClient); } - @TestRail(section = { "rest-api", "sites" }, + @TestRail(section = { "rest-api", "people" }, executionType = ExecutionType.SANITY, - description = "Verify site manager is able to retrieve site membership information of another user") - public void siteManagerCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + description = "Verify site manager is able to retrieve sites membership information of another user") + public void siteManagerCanRetrieveSitesMembershipInformation() throws JsonToModelConversionException, Exception { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); - siteAPI.getSiteMembershipInformation(adminUser); - siteAPI.usingRestWrapper() + peopleApi.getSitesMembershipInformation(adminUser); + peopleApi.usingRestWrapper() .assertStatusCodeIs(HttpStatus.OK); } - @TestRail(section = { "rest-api", "sites" }, + @TestRail(section = { "rest-api", "people" }, executionType = ExecutionType.SANITY, - description = "Verify site collaborator is able to retrieve site membership information of another user") - public void siteCollaboratorCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + description = "Verify site collaborator is able to retrieve sites membership information of another user") + public void siteCollaboratorCanRetrieveSitesMembershipInformation() throws JsonToModelConversionException, Exception { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteCollaborator)); - siteAPI.getSiteMembershipInformation(adminUser); - siteAPI.usingRestWrapper() + peopleApi.getSitesMembershipInformation(adminUser); + peopleApi.usingRestWrapper() .assertStatusCodeIs(HttpStatus.OK); } - @TestRail(section = { "rest-api", "sites" }, + @TestRail(section = { "rest-api", "people" }, executionType = ExecutionType.SANITY, - description = "Verify site contributor is able to retrieve site membership information of another user") - public void siteContributorCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + description = "Verify site contributor is able to retrieve sites membership information of another user") + public void siteContributorCanRetrieveSitesMembershipInformation() throws JsonToModelConversionException, Exception { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteContributor)); - siteAPI.getSiteMembershipInformation(adminUser); - siteAPI.usingRestWrapper() + peopleApi.getSitesMembershipInformation(adminUser); + peopleApi.usingRestWrapper() .assertStatusCodeIs(HttpStatus.OK); } - @TestRail(section = { "rest-api", "sites" }, + @TestRail(section = { "rest-api", "people" }, executionType = ExecutionType.SANITY, - description = "Verify site consumer is able to retrieve site membership information of another user") - public void siteConsumerCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + description = "Verify site consumer is able to retrieve sites membership information of another user") + public void siteConsumerCanRetrieveSitesMembershipInformation() throws JsonToModelConversionException, Exception { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteConsumer)); - siteAPI.getSiteMembershipInformation(adminUser); - siteAPI.usingRestWrapper() + peopleApi.getSitesMembershipInformation(adminUser); + peopleApi.usingRestWrapper() .assertStatusCodeIs(HttpStatus.OK); } - @TestRail(section = { "rest-api", "sites" }, + @TestRail(section = { "rest-api", "people" }, executionType = ExecutionType.SANITY, - description = "Verify admin is able to retrieve site membership information of another user") - public void siteAdminCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + description = "Verify admin is able to retrieve sites membership information of another user") + public void siteAdminCanRetrieveSitesMembershipInformation() throws JsonToModelConversionException, Exception { restClient.authenticateUser(adminUser); - siteAPI.getSiteMembershipInformation(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); - siteAPI.usingRestWrapper() + peopleApi.getSitesMembershipInformation(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); + peopleApi.usingRestWrapper() .assertStatusCodeIs(HttpStatus.OK); } - @TestRail(section = { "rest-api", "sites" }, + @TestRail(section = { "rest-api", "people" }, executionType = ExecutionType.SANITY, - description = "Verify that unauthenticated user is not able to retrieve site membership information") - public void unauthenticatedUserCannotRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + description = "Verify that unauthenticated user is not able to retrieve sites membership information") + public void unauthenticatedUserCannotRetrieveSitesMembershipInformation() throws JsonToModelConversionException, Exception { UserModel inexistentUser = new UserModel("inexistent user", "wrong password"); restClient.authenticateUser(inexistentUser); - siteAPI.getSiteMembershipInformation(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); - siteAPI.usingRestWrapper() + peopleApi.getSitesMembershipInformation(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); + peopleApi.usingRestWrapper() .assertStatusCodeIs(HttpStatus.UNAUTHORIZED); } diff --git a/e2e-test/java/org/alfresco/rest/sites/GetSitesTests.java b/e2e-test/java/org/alfresco/rest/sites/GetSitesTests.java deleted file mode 100644 index 3f4a54291..000000000 --- a/e2e-test/java/org/alfresco/rest/sites/GetSitesTests.java +++ /dev/null @@ -1,104 +0,0 @@ -package org.alfresco.rest.sites; - -import org.alfresco.rest.RestTest; -import org.alfresco.rest.exception.JsonToModelConversionException; -import org.alfresco.rest.requests.RestSitesApi; -import org.alfresco.utility.constants.UserRole; -import org.alfresco.utility.data.DataSite; -import org.alfresco.utility.data.DataUser; -import org.alfresco.utility.data.DataUser.ListUserWithRoles; -import org.alfresco.utility.model.SiteModel; -import org.alfresco.utility.model.UserModel; -import org.alfresco.utility.testrail.ExecutionType; -import org.alfresco.utility.testrail.annotation.TestRail; -import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.http.HttpStatus; -import org.testng.annotations.BeforeClass; -import org.testng.annotations.Test; - -/** - * @author iulia.cojocea - */ -@Test(groups = { "rest-api", "comments", "sanity" }) -public class GetSitesTests extends RestTest -{ - @Autowired - RestSitesApi siteAPI; - - @Autowired - DataUser dataUser; - - @Autowired - DataSite dataSite; - - private UserModel adminUserModel; - private UserModel userModel; - private ListUserWithRoles usersWithRoles; - private SiteModel siteModel; - - @BeforeClass(alwaysRun=true) - public void dataPreparation() throws Exception - { - adminUserModel = dataUser.getAdminUser(); - restClient.authenticateUser(adminUserModel); - siteAPI.useRestClient(restClient); - siteModel = dataSite.usingUser(adminUserModel).createPublicRandomSite(); - usersWithRoles = dataUser.addUsersWithRolesToSite(siteModel,UserRole.SiteManager, UserRole.SiteCollaborator, UserRole.SiteConsumer, UserRole.SiteContributor); - } - - @TestRail(section = { "rest-api", "sites" }, executionType = ExecutionType.SANITY, description = "Verify user with Manager role gets sites information and gets status code OK (200)") - public void getSitesWithManagerRole() throws JsonToModelConversionException, Exception - { - - restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); - siteAPI.getAllSites(); - siteAPI.usingRestWrapper().assertStatusCodeIs(HttpStatus.OK); - } - - @TestRail(section = { "rest-api", "sites" }, executionType = ExecutionType.SANITY, description = "Verify user with Collaborator role gets sites information and gets status code OK (200)") - public void getSitesWithCollaboratorRole() throws JsonToModelConversionException, Exception - { - - restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteCollaborator)); - siteAPI.getAllSites(); - siteAPI.usingRestWrapper().assertStatusCodeIs(HttpStatus.OK); - } - - @TestRail(section = { "rest-api", "sites" }, executionType = ExecutionType.SANITY, description = "Verify user with Contributor role gets sites information and gets status code OK (200)") - public void getSitesWithContributorRole() throws JsonToModelConversionException, Exception - { - - restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteContributor)); - siteAPI.getAllSites(); - siteAPI.usingRestWrapper().assertStatusCodeIs(HttpStatus.OK); - } - - @TestRail(section = { "rest-api", "sites" }, executionType = ExecutionType.SANITY, description = "Verify user with Consumer role gets sites information and gets status code OK (200)") - public void getSitesWithConsumerRole() throws JsonToModelConversionException, Exception - { - - restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteConsumer)); - siteAPI.getAllSites(); - siteAPI.usingRestWrapper().assertStatusCodeIs(HttpStatus.OK); - } - - @TestRail(section = { "rest-api", "sites" }, executionType = ExecutionType.SANITY, description = "Verify user with Admin user gets sites information and gets status code OK (200)") - public void getSitesWithAdminUser() throws JsonToModelConversionException, Exception - { - restClient.authenticateUser(adminUserModel); - siteAPI.getAllSites(); - siteAPI.usingRestWrapper().assertStatusCodeIs(HttpStatus.OK); - } - - @TestRail(section = { "rest-api", "sites" }, executionType = ExecutionType.SANITY, description = "Failed authentication get sites call returns status code 401 with Manager role") - public void getSitesWithManagerRoleFailedAuth() throws JsonToModelConversionException, Exception - { - restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); - userModel = dataUser.createRandomTestUser(); - userModel.setPassword("user wrong password"); - dataUser.addUserToSite(userModel, siteModel, UserRole.SiteManager); - restClient.authenticateUser(userModel); - siteAPI.getAllSites(); - siteAPI.usingRestWrapper().assertStatusCodeIs(HttpStatus.UNAUTHORIZED); - } -} From f450bc6418f690988542e62bdbb185fb0c1b64cc Mon Sep 17 00:00:00 2001 From: Valentin Popa Date: Fri, 30 Sep 2016 17:15:31 +0300 Subject: [PATCH 2/6] TAS-1015 REST API - valid request returns success status code 200 with Collaborator role --- .../rest/people/GetSiteMembershipSanityTests.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java index 634f38684..623d15524 100644 --- a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java +++ b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java @@ -56,4 +56,13 @@ public class GetSiteMembershipSanityTests extends RestTest .assertStatusCodeIs(HttpStatus.OK); } + @TestRail(section = { "rest-api", + "people" }, executionType = ExecutionType.SANITY, description = "Verify site collaborator is able to retrieve site membership information of another user") + public void siteCollaboratorCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + { + restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteCollaborator)); + peopleApi.getSiteMembership(adminUser, siteModel); + peopleApi.usingRestWrapper().assertStatusCodeIs(HttpStatus.OK); + } + } \ No newline at end of file From 1880053d421498752fe1aa686210bf81fa619847 Mon Sep 17 00:00:00 2001 From: Valentin Popa Date: Fri, 30 Sep 2016 17:17:34 +0300 Subject: [PATCH 3/6] TAS-1016 REST API - valid request returns success status code 200 with Contributor role --- .../rest/people/GetSiteMembershipSanityTests.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java index 623d15524..529509aee 100644 --- a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java +++ b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java @@ -62,7 +62,18 @@ public class GetSiteMembershipSanityTests extends RestTest { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteCollaborator)); peopleApi.getSiteMembership(adminUser, siteModel); - peopleApi.usingRestWrapper().assertStatusCodeIs(HttpStatus.OK); + peopleApi.usingRestWrapper() + .assertStatusCodeIs(HttpStatus.OK); + } + + @TestRail(section = { "rest-api", + "people" }, executionType = ExecutionType.SANITY, description = "Verify site contributor is able to retrieve site membership information of another user") + public void siteContributorCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + { + restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteContributor)); + peopleApi.getSiteMembership(adminUser, siteModel); + peopleApi.usingRestWrapper() + .assertStatusCodeIs(HttpStatus.OK); } } \ No newline at end of file From 748f064b2b6139994d2ecda42d6e00b3296d5643 Mon Sep 17 00:00:00 2001 From: Valentin Popa Date: Fri, 30 Sep 2016 17:18:32 +0300 Subject: [PATCH 4/6] TAS-1017 REST API - valid request returns success status code 200 with Consumer role --- .../rest/people/GetSiteMembershipSanityTests.java | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java index 529509aee..e02574983 100644 --- a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java +++ b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java @@ -76,4 +76,14 @@ public class GetSiteMembershipSanityTests extends RestTest .assertStatusCodeIs(HttpStatus.OK); } + @TestRail(section = { "rest-api", + "people" }, executionType = ExecutionType.SANITY, description = "Verify site consumer is able to retrieve site membership information of another user") + public void siteConsumerCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + { + restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteConsumer)); + peopleApi.getSiteMembership(adminUser, siteModel); + peopleApi.usingRestWrapper() + .assertStatusCodeIs(HttpStatus.OK); +} + } \ No newline at end of file From ea0dbe40661e472b091df5548560e0bc26b030e1 Mon Sep 17 00:00:00 2001 From: Valentin Popa Date: Fri, 30 Sep 2016 17:20:03 +0300 Subject: [PATCH 5/6] TAS-1018 REST API - valid request returns success status code 200 with admin user --- .../rest/people/GetSiteMembershipSanityTests.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java index e02574983..a099f719e 100644 --- a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java +++ b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java @@ -84,6 +84,16 @@ public class GetSiteMembershipSanityTests extends RestTest peopleApi.getSiteMembership(adminUser, siteModel); peopleApi.usingRestWrapper() .assertStatusCodeIs(HttpStatus.OK); -} + } + + @TestRail(section = { "rest-api", + "people" }, executionType = ExecutionType.SANITY, description = "Verify admin user is able to retrieve site membership information of another user") + public void adminCanRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + { + restClient.authenticateUser(adminUser); + peopleApi.getSiteMembership(usersWithRoles.getOneUserWithRole(UserRole.SiteManager), siteModel); + peopleApi.usingRestWrapper() + .assertStatusCodeIs(HttpStatus.OK); + } } \ No newline at end of file From ff40e3abe5374f110179c032edb8fb743fc4b845 Mon Sep 17 00:00:00 2001 From: Valentin Popa Date: Fri, 30 Sep 2016 17:25:25 +0300 Subject: [PATCH 6/6] TAS-1019 REST API - failed authentication call returns status code 401 --- .../rest/people/GetSiteMembershipSanityTests.java | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java index a099f719e..08f8d9bff 100644 --- a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java +++ b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipSanityTests.java @@ -96,4 +96,14 @@ public class GetSiteMembershipSanityTests extends RestTest .assertStatusCodeIs(HttpStatus.OK); } + @TestRail(section = { "rest-api", + "people" }, executionType = ExecutionType.SANITY, description = "Verify unauthenticated user is not able to retrieve site membership information of another user") + public void unauthenticatedUserCannotRetrieveSiteMembershipInformation() throws JsonToModelConversionException, Exception + { + restClient.authenticateUser(new UserModel("random user", "random password")); + peopleApi.getSiteMembership(usersWithRoles.getOneUserWithRole(UserRole.SiteManager), siteModel); + peopleApi.usingRestWrapper() + .assertStatusCodeIs(HttpStatus.UNAUTHORIZED); + } + } \ No newline at end of file