From 969cf3996238152b29a7850001d1326f9ac2bd8b Mon Sep 17 00:00:00 2001
From: Tom Page <thomas.page@alfresco.com>
Date: Mon, 27 Apr 2020 14:37:12 +0100
Subject: [PATCH] SEARCH-2202 Make AdminHandler tests clearer.

Sonar doesn't like tests with no assertions.
---
 .../org/alfresco/solr/AdminHandlerIT.java     | 34 ++++++++++++++-----
 1 file changed, 25 insertions(+), 9 deletions(-)

diff --git a/search-services/alfresco-search/src/test/java/org/alfresco/solr/AdminHandlerIT.java b/search-services/alfresco-search/src/test/java/org/alfresco/solr/AdminHandlerIT.java
index 140b6b1db..429ad4b01 100644
--- a/search-services/alfresco-search/src/test/java/org/alfresco/solr/AdminHandlerIT.java
+++ b/search-services/alfresco-search/src/test/java/org/alfresco/solr/AdminHandlerIT.java
@@ -1,8 +1,10 @@
 package org.alfresco.solr;
 
+import static org.junit.Assert.fail;
+
 import org.apache.lucene.util.LuceneTestCase;
-import org.apache.solr.common.SolrException;
 import org.apache.solr.SolrTestCaseJ4;
+import org.apache.solr.common.SolrException;
 import org.apache.solr.common.params.CoreAdminParams;
 import org.apache.solr.handler.admin.CoreAdminHandler;
 import org.apache.solr.response.SolrQueryResponse;
@@ -32,19 +34,33 @@ public class AdminHandlerIT extends AbstractAlfrescoSolrIT
     }
 
     @Test
-    public void testhandledCores() throws Exception
+    public void testHandledCores()
     {
-        requestAction("newCore");
-        requestAction("updateCore");
-        requestAction("removeCore");
+        try
+        {
+            requestAction("newCore");
+            requestAction("updateCore");
+            requestAction("removeCore");
+        }
+        catch (Exception e)
+        {
+            fail("Expected to receive no exception, but got " + e);
+        }
     }
 
     @Test
-    public void testhandledReports() throws Exception
+    public void testHandledReports()
     {
-        requestAction("CHECK");
-        requestAction("REPORT");
-        requestAction("SUMMARY");
+        try
+        {
+            requestAction("CHECK");
+            requestAction("REPORT");
+            requestAction("SUMMARY");
+        }
+        catch (Exception e)
+        {
+            fail("Expected to receive no exception, but got " + e);
+        }
     }
 
     private void requestAction(String actionName) throws Exception {