diff --git a/e2e-test/java/org/alfresco/rest/comments/AddCommentSanityTests.java b/e2e-test/java/org/alfresco/rest/comments/AddCommentSanityTests.java index 5743f156b..00fb52d8b 100644 --- a/e2e-test/java/org/alfresco/rest/comments/AddCommentSanityTests.java +++ b/e2e-test/java/org/alfresco/rest/comments/AddCommentSanityTests.java @@ -3,10 +3,15 @@ package org.alfresco.rest.comments; import org.alfresco.dataprep.CMISUtil.DocumentType; import org.alfresco.rest.RestTest; import org.alfresco.rest.exception.JsonToModelConversionException; +import org.alfresco.rest.model.RestCommentModel; import org.alfresco.rest.model.RestErrorModel; import org.alfresco.utility.constants.UserRole; import org.alfresco.utility.data.DataUser.ListUserWithRoles; -import org.alfresco.utility.model.*; +import org.alfresco.utility.model.FileModel; +import org.alfresco.utility.model.SiteModel; +import org.alfresco.utility.model.StatusModel; +import org.alfresco.utility.model.TestGroup; +import org.alfresco.utility.model.UserModel; import org.alfresco.utility.report.Bug; import org.alfresco.utility.testrail.ExecutionType; import org.alfresco.utility.testrail.annotation.TestRail; @@ -14,7 +19,6 @@ import org.springframework.http.HttpStatus; import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; -@Test(groups = { TestGroup.REST_API, TestGroup.COMMENTS, TestGroup.SANITY }) public class AddCommentSanityTests extends RestTest { private UserModel adminUserModel; @@ -34,6 +38,7 @@ public class AddCommentSanityTests extends RestTest } @TestRail(section = { TestGroup.REST_API, TestGroup.COMMENTS }, executionType = ExecutionType.SANITY, description = "Verify admin user adds comments with Rest API and status code is 201") + @Test(groups = { TestGroup.REST_API, TestGroup.COMMENTS, TestGroup.SANITY }) public void adminIsAbleToAddComment() throws JsonToModelConversionException, Exception { restClient.authenticateUser(adminUserModel); @@ -45,28 +50,34 @@ public class AddCommentSanityTests extends RestTest } @TestRail(section = { TestGroup.REST_API, TestGroup.COMMENTS }, executionType = ExecutionType.SANITY, description = "Verify Manager user adds comments with Rest API and status code is 201") + @Test(groups = { TestGroup.REST_API, TestGroup.COMMENTS, TestGroup.SANITY }) public void managerIsAbleToAddComment() throws JsonToModelConversionException, Exception { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteManager)); String contentSiteManger = "This is a new comment added by user with role: " + UserRole.SiteManager; - restClient.withCoreAPI().usingResource(document).addComment(contentSiteManger) - .assertThat().field("content").isNotEmpty() - .and().field("content").is(contentSiteManger); + RestCommentModel createdComment = restClient.withCoreAPI().usingResource(document).addComment(contentSiteManger); restClient.assertStatusCodeIs(HttpStatus.CREATED); + createdComment.assertThat().field("content").isNotEmpty() + .and().field("content").is(contentSiteManger); + } @TestRail(section = { TestGroup.REST_API, TestGroup.COMMENTS }, executionType = ExecutionType.SANITY, description = "Verify Contributor user adds comments with Rest API and status code is 201") + @Test(groups = { TestGroup.REST_API, TestGroup.COMMENTS, TestGroup.SANITY }) + @Bug(id="ACE-4614") public void contributorIsAbleToAddComment() throws JsonToModelConversionException, Exception { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteContributor)); String contentSiteContributor = "This is a new comment added by user with role" + UserRole.SiteContributor; - restClient.withCoreAPI().usingResource(document).addComment(contentSiteContributor) - .assertThat().field("content").isNotEmpty() - .and().field("content").is(contentSiteContributor); + RestCommentModel createdComment = restClient.withCoreAPI().usingResource(document).addComment(contentSiteContributor); restClient.assertStatusCodeIs(HttpStatus.CREATED); + createdComment.assertThat().field("content").isNotEmpty() + .and().field("content").is(contentSiteContributor); + } @TestRail(section = { TestGroup.REST_API, TestGroup.COMMENTS }, executionType = ExecutionType.SANITY, description = "Verify Collaborator user adds comments with Rest API and status code is 201") + @Test(groups = { TestGroup.REST_API, TestGroup.COMMENTS, TestGroup.SANITY }) public void collaboratorIsAbleToAddComment() throws JsonToModelConversionException, Exception { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteCollaborator)); @@ -78,6 +89,7 @@ public class AddCommentSanityTests extends RestTest } @TestRail(section = { TestGroup.REST_API, TestGroup.COMMENTS }, executionType = ExecutionType.SANITY, description = "Verify Consumer user can't add comments with Rest API and status code is 403") + @Test(groups = { TestGroup.REST_API, TestGroup.COMMENTS, TestGroup.SANITY }) public void consumerIsNotAbleToAddComment() throws JsonToModelConversionException, Exception { restClient.authenticateUser(usersWithRoles.getOneUserWithRole(UserRole.SiteConsumer)); @@ -89,6 +101,7 @@ public class AddCommentSanityTests extends RestTest } @TestRail(section = { TestGroup.REST_API, TestGroup.COMMENTS }, executionType = ExecutionType.SANITY, description = "Verify unauthenticated user gets status code 401 on post comments call") + @Test(groups = { TestGroup.REST_API, TestGroup.COMMENTS, TestGroup.SANITY }) @Bug(id = "MNT-16904") public void unauthenticatedUserIsNotAbleToAddComment() throws JsonToModelConversionException, Exception {