mirror of
https://github.com/Alfresco/SearchServices.git
synced 2026-09-16 18:12:56 +00:00
SEARCH-2202 Use constants for fields in SOLRAPIQueueClient.
These collections should be constants anyway - they're never set.
This commit is contained in:
+3
-3
@@ -51,9 +51,9 @@ public class AlfrescoSolrReloadIT extends AbstractAlfrescoSolrIT
|
||||
public void clearQueue() throws Exception {
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
}
|
||||
|
||||
|
||||
+3
-4
@@ -89,7 +89,6 @@ import org.alfresco.solr.client.SOLRAPIQueueClient;
|
||||
import org.alfresco.solr.client.StringPropertyValue;
|
||||
import org.alfresco.solr.client.Transaction;
|
||||
import org.alfresco.util.ISO9075;
|
||||
import org.alfresco.util.Pair;
|
||||
import org.apache.solr.SolrTestCaseJ4.XmlDoc;
|
||||
import org.apache.solr.common.SolrInputDocument;
|
||||
import org.apache.solr.common.params.CoreAdminParams;
|
||||
@@ -383,17 +382,17 @@ public class AlfrescoSolrUtils
|
||||
public static void indexAclChangeSet(AclChangeSet aclChangeSet, List<Acl> aclList, List<AclReaders> aclReadersList)
|
||||
{
|
||||
//First map the nodes to a transaction.
|
||||
SOLRAPIQueueClient.aclMap.put(aclChangeSet.getId(), aclList);
|
||||
SOLRAPIQueueClient.ACL_MAP.put(aclChangeSet.getId(), aclList);
|
||||
|
||||
//Next map a node to the NodeMetaData
|
||||
for(AclReaders aclReaders : aclReadersList)
|
||||
{
|
||||
SOLRAPIQueueClient.aclReadersMap.put(aclReaders.getId(), aclReaders);
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.put(aclReaders.getId(), aclReaders);
|
||||
}
|
||||
|
||||
//Next add the transaction to the queue
|
||||
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.add(aclChangeSet);
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.add(aclChangeSet);
|
||||
}
|
||||
/**
|
||||
* Generate a collection from input.
|
||||
|
||||
+3
-3
@@ -41,9 +41,9 @@ public class AlfrescoTrackerRegistrationIT extends AbstractAlfrescoSolrIT
|
||||
public void clearQueue() throws Exception {
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
}
|
||||
@Test
|
||||
|
||||
+3
-5
@@ -4,7 +4,6 @@ import com.carrotsearch.randomizedtesting.annotations.ThreadLeakLingering;
|
||||
import org.alfresco.solr.basics.RandomSupplier;
|
||||
import org.alfresco.solr.client.SOLRAPIQueueClient;
|
||||
import org.apache.commons.io.FileUtils;
|
||||
import org.apache.hadoop.util.Time;
|
||||
import org.apache.solr.SolrTestCaseJ4;
|
||||
import org.apache.solr.client.solrj.SolrClient;
|
||||
import org.apache.solr.client.solrj.embedded.JettyConfig;
|
||||
@@ -15,7 +14,6 @@ import org.apache.solr.core.CoreContainer;
|
||||
import org.apache.solr.core.SolrCore;
|
||||
import org.eclipse.jetty.servlet.ServletHolder;
|
||||
import org.junit.BeforeClass;
|
||||
import org.junit.rules.ExternalResource;
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
|
||||
@@ -224,9 +222,9 @@ public abstract class SolrITInitializer extends SolrTestCaseJ4
|
||||
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
}
|
||||
|
||||
|
||||
+3
-3
@@ -146,9 +146,9 @@ public class ContentStoreReplicationIT extends AbstractAlfrescoDistributedIT
|
||||
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
SOLRAPIQueueClient.nodeContentMap.clear();
|
||||
}
|
||||
|
||||
+3
-3
@@ -154,9 +154,9 @@ public class AlfrescoHighlighterIT extends AbstractAlfrescoSolrIT
|
||||
public static void clearQueue() {
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
SOLRAPIQueueClient.nodeContentMap.clear();
|
||||
}
|
||||
|
||||
+3
-3
@@ -90,9 +90,9 @@ public class AlfrescoSolrFingerprintIT extends AbstractAlfrescoSolrIT
|
||||
{
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
SOLRAPIQueueClient.nodeContentMap.clear();
|
||||
|
||||
|
||||
+3
-3
@@ -87,9 +87,9 @@ public class AlfrescoSolrTrackerExceptionIT extends AbstractAlfrescoSolrIT
|
||||
public void clearQueue() throws Exception {
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
}
|
||||
|
||||
|
||||
+3
-3
@@ -88,9 +88,9 @@ public class AlfrescoSolrTrackerIT extends AbstractAlfrescoSolrIT
|
||||
public void clearQueue() throws Exception {
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
}
|
||||
|
||||
|
||||
+3
-3
@@ -80,9 +80,9 @@ public class AlfrescoSolrTrackerRollbackIT extends AbstractAlfrescoSolrIT
|
||||
public void clearQueue() throws Exception {
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
}
|
||||
|
||||
|
||||
+3
-3
@@ -82,9 +82,9 @@ public class AlfrescoSolrTrackerStateIT extends AbstractAlfrescoSolrIT
|
||||
public void clearQueue() throws Exception {
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
}
|
||||
|
||||
|
||||
+3
-3
@@ -152,9 +152,9 @@ public class CascadingIT extends AbstractAlfrescoSolrIT
|
||||
{
|
||||
SOLRAPIQueueClient.nodeMetaDataMap.clear();
|
||||
SOLRAPIQueueClient.transactionQueue.clear();
|
||||
SOLRAPIQueueClient.aclChangeSetQueue.clear();
|
||||
SOLRAPIQueueClient.aclReadersMap.clear();
|
||||
SOLRAPIQueueClient.aclMap.clear();
|
||||
SOLRAPIQueueClient.ACL_CHANGE_SET_QUEUE.clear();
|
||||
SOLRAPIQueueClient.ACL_READERS_MAP.clear();
|
||||
SOLRAPIQueueClient.ACL_MAP.clear();
|
||||
SOLRAPIQueueClient.nodeMap.clear();
|
||||
}
|
||||
|
||||
|
||||
+8
-8
@@ -47,9 +47,9 @@ import org.json.JSONException;
|
||||
|
||||
public class SOLRAPIQueueClient extends SOLRAPIClient
|
||||
{
|
||||
public static List<AclChangeSet> aclChangeSetQueue = Collections.synchronizedList(new ArrayList());
|
||||
public static Map<Long, List<Acl>> aclMap = Collections.synchronizedMap(new HashMap());
|
||||
public static Map<Long, AclReaders> aclReadersMap = Collections.synchronizedMap(new HashMap());
|
||||
protected static final List<AclChangeSet> ACL_CHANGE_SET_QUEUE = Collections.synchronizedList(new ArrayList());
|
||||
protected static final Map<Long, List<Acl>> ACL_MAP = Collections.synchronizedMap(new HashMap());
|
||||
protected static final Map<Long, AclReaders> ACL_READERS_MAP = Collections.synchronizedMap(new HashMap());
|
||||
|
||||
public static List<Transaction> transactionQueue = Collections.synchronizedList(new ArrayList());
|
||||
public static Map<Long, List<Node>> nodeMap = Collections.synchronizedMap(new HashMap());
|
||||
@@ -74,7 +74,7 @@ public class SOLRAPIQueueClient extends SOLRAPIClient
|
||||
throw new ConnectException("THROWING EXCEPTION, better be ready!");
|
||||
}
|
||||
|
||||
int size = aclChangeSetQueue.size();
|
||||
int size = ACL_CHANGE_SET_QUEUE.size();
|
||||
long maxTime = 0L;
|
||||
long maxId = 0L;
|
||||
|
||||
@@ -83,7 +83,7 @@ public class SOLRAPIQueueClient extends SOLRAPIClient
|
||||
List<AclChangeSet> aclChangeSetList = new ArrayList();
|
||||
for(int i=0; i<size; i++)
|
||||
{
|
||||
AclChangeSet aclChangeSet = aclChangeSetQueue.get(i);
|
||||
AclChangeSet aclChangeSet = ACL_CHANGE_SET_QUEUE.get(i);
|
||||
if(aclChangeSet.getId() >= minAclChangeSetId && aclChangeSet.getId() < maxAclChangeSetId)
|
||||
{
|
||||
aclChangeSetList.add(aclChangeSet);
|
||||
@@ -103,7 +103,7 @@ public class SOLRAPIQueueClient extends SOLRAPIClient
|
||||
|
||||
for(int i=0; i<size; i++)
|
||||
{
|
||||
AclChangeSet aclChangeSet = aclChangeSetQueue.get(i);
|
||||
AclChangeSet aclChangeSet = ACL_CHANGE_SET_QUEUE.get(i);
|
||||
|
||||
if(aclChangeSet.getCommitTimeMs() < fromCommitTime)
|
||||
{
|
||||
@@ -149,7 +149,7 @@ public class SOLRAPIQueueClient extends SOLRAPIClient
|
||||
List<Acl> allAcls = new ArrayList();
|
||||
for(AclChangeSet aclChangeSet : aclChangeSets)
|
||||
{
|
||||
List aclList = aclMap.get(aclChangeSet.getId());
|
||||
List aclList = ACL_MAP.get(aclChangeSet.getId());
|
||||
allAcls.addAll(aclList);
|
||||
}
|
||||
return allAcls;
|
||||
@@ -170,7 +170,7 @@ public class SOLRAPIQueueClient extends SOLRAPIClient
|
||||
List<AclReaders> allAclReaders = new ArrayList();
|
||||
for(Acl acl : acls)
|
||||
{
|
||||
AclReaders aclReaders = aclReadersMap.get(acl.getId());
|
||||
AclReaders aclReaders = ACL_READERS_MAP.get(acl.getId());
|
||||
allAclReaders.add(aclReaders);
|
||||
}
|
||||
return allAclReaders;
|
||||
|
||||
Reference in New Issue
Block a user