From c2f893dffd2ba4336dbd2e9a8277b6755b87a7e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alecsandru=20Prun=C4=83?= Date: Tue, 6 Dec 2016 10:41:39 +0200 Subject: [PATCH] test: Added valid values for skipCount and maxItems --- .../AddSiteMembershipRequestCoreTests.java | 4 ++ ...GetSiteMembershipInformationCoreTests.java | 55 +++++++++++++++++++ 2 files changed, 59 insertions(+) diff --git a/e2e-test/java/org/alfresco/rest/people/AddSiteMembershipRequestCoreTests.java b/e2e-test/java/org/alfresco/rest/people/AddSiteMembershipRequestCoreTests.java index f27718f90..127075d19 100644 --- a/e2e-test/java/org/alfresco/rest/people/AddSiteMembershipRequestCoreTests.java +++ b/e2e-test/java/org/alfresco/rest/people/AddSiteMembershipRequestCoreTests.java @@ -43,6 +43,7 @@ public class AddSiteMembershipRequestCoreTests extends RestTest .usingMe() .addSiteMembershipRequest(siteModel); restClient.assertStatusCodeIs(HttpStatus.BAD_REQUEST); + restClient.assertLastError().containsSummary(String.format("%s is already a member of site %s", newMember.getUsername(), siteModel.getId())); } @TestRail(section = { TestGroup.REST_API, TestGroup.PEOPLE }, executionType = ExecutionType.REGRESSION, @@ -53,6 +54,7 @@ public class AddSiteMembershipRequestCoreTests extends RestTest .withCoreAPI() .usingUser(new UserModel("invalidUser", "password")).addSiteMembershipRequest(siteModel); restClient.assertStatusCodeIs(HttpStatus.NOT_FOUND); + restClient.assertLastError().containsSummary("The entity with id: invalidUser was not found"); } @TestRail(section = { TestGroup.REST_API, TestGroup.PEOPLE }, executionType = ExecutionType.REGRESSION, @@ -63,6 +65,8 @@ public class AddSiteMembershipRequestCoreTests extends RestTest .withCoreAPI() .usingMe().addSiteMembershipRequest(new SiteModel("invalidSiteID")); restClient.assertStatusCodeIs(HttpStatus.NOT_FOUND); + restClient.assertLastError().containsSummary(String.format("The relationship resource was not found for" + + " the entity with id: %s and a relationship id of invalidSiteID", newMember.getUsername())); } @TestRail(section = { TestGroup.REST_API, TestGroup.PEOPLE }, executionType = ExecutionType.REGRESSION, diff --git a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipInformationCoreTests.java b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipInformationCoreTests.java index 4a755125a..07745dca6 100644 --- a/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipInformationCoreTests.java +++ b/e2e-test/java/org/alfresco/rest/people/GetSiteMembershipInformationCoreTests.java @@ -56,6 +56,7 @@ public class GetSiteMembershipInformationCoreTests extends RestTest .getSitesMembershipInformation() .assertThat().entriesListIsEmpty(); restClient.assertStatusCodeIs(HttpStatus.NOT_FOUND); + restClient.assertLastError().containsSummary("The entity with id: invalidPersonId was not found"); } @TestRail(section = { TestGroup.REST_API, TestGroup.PEOPLE }, executionType = ExecutionType.REGRESSION, @@ -69,6 +70,37 @@ public class GetSiteMembershipInformationCoreTests extends RestTest .getSitesMembershipInformation() .assertThat().entriesListIsEmpty(); restClient.assertStatusCodeIs(HttpStatus.BAD_REQUEST); + restClient.assertLastError().containsSummary("Only positive values supported for maxItems"); + + restClient.withParams("maxItems=-1") + .withCoreAPI() + .usingAuthUser() + .getSitesMembershipInformation() + .assertThat().entriesListIsEmpty(); + restClient.assertStatusCodeIs(HttpStatus.BAD_REQUEST); + restClient.assertLastError().containsSummary("Only positive values supported for maxItems"); + + restClient.withParams("maxItems=test") + .withCoreAPI() + .usingAuthUser() + .getSitesMembershipInformation() + .assertThat().entriesListIsEmpty(); + restClient.assertStatusCodeIs(HttpStatus.BAD_REQUEST); + restClient.assertLastError().containsSummary("Invalid paging parameter maxItems:test"); + } + + @TestRail(section = { TestGroup.REST_API, TestGroup.PEOPLE }, executionType = ExecutionType.REGRESSION, + description = "Verify if get site membership information request returns status code 200 for valid maxItems parameter") + public void getSiteMembershipInformationRequestReturns200ForValidMaxItemsParameter() throws Exception + { + restClient.authenticateUser(userModel) + .withParams("maxItems=5") + .withCoreAPI() + .usingAuthUser() + .getSitesMembershipInformation() + .assertThat().entriesListIsNotEmpty() + .getPagination().assertThat().field("maxItems").is("5"); + restClient.assertStatusCodeIs(HttpStatus.OK); } @TestRail(section = { TestGroup.REST_API, TestGroup.PEOPLE }, executionType = ExecutionType.REGRESSION, @@ -82,6 +114,29 @@ public class GetSiteMembershipInformationCoreTests extends RestTest .getSitesMembershipInformation() .assertThat().entriesListIsEmpty(); restClient.assertStatusCodeIs(HttpStatus.BAD_REQUEST); + restClient.assertLastError().containsSummary("Negative values not supported for skipCount"); + + restClient.withParams("skipCount=test") + .withCoreAPI() + .usingAuthUser() + .getSitesMembershipInformation() + .assertThat().entriesListIsEmpty(); + restClient.assertStatusCodeIs(HttpStatus.BAD_REQUEST); + restClient.assertLastError().containsSummary("Invalid paging parameter skipCount:test"); + } + + @TestRail(section = { TestGroup.REST_API, TestGroup.PEOPLE }, executionType = ExecutionType.REGRESSION, + description = "Verify if get site membership information request returns status code 200 for valid skipCount parameter") + public void getSiteMembershipInformationRequestReturns200ForValidSkipCountParameter() throws Exception + { + restClient.authenticateUser(userModel) + .withParams("skipCount=1") + .withCoreAPI() + .usingAuthUser() + .getSitesMembershipInformation() + .assertThat().entriesListIsNotEmpty() + .getPagination().assertThat().field("skipCount").is("1"); + restClient.assertStatusCodeIs(HttpStatus.OK); } @TestRail(section = { TestGroup.REST_API, TestGroup.PEOPLE }, executionType = ExecutionType.REGRESSION,