From d7efa10b654387facb2d630c0dbcb01de6045cb5 Mon Sep 17 00:00:00 2001 From: Matt Ward Date: Fri, 1 Dec 2017 16:47:02 +0000 Subject: [PATCH] REPO-1308: added 'GET /action-definitions' error status checks Added a couple of error code checks: 400 (bad request) and 401 (unauthorised) - the latter actually fails and raises the question of whether the actions API implmentation or the TAS test framework are wrong. Committing to capture the test code, but will sort it out one way or another. --- .../alfresco/rest/actions/ActionsTests.java | 35 ++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/e2e-test/java/org/alfresco/rest/actions/ActionsTests.java b/e2e-test/java/org/alfresco/rest/actions/ActionsTests.java index 577f30b2e..a4523de61 100644 --- a/e2e-test/java/org/alfresco/rest/actions/ActionsTests.java +++ b/e2e-test/java/org/alfresco/rest/actions/ActionsTests.java @@ -3,6 +3,7 @@ package org.alfresco.rest.actions; import org.alfresco.rest.RestTest; import org.alfresco.rest.model.RestActionDefinitionModelsCollection; import org.alfresco.utility.model.TestGroup; +import org.alfresco.utility.model.UserModel; import org.alfresco.utility.testrail.ExecutionType; import org.alfresco.utility.testrail.annotation.TestRail; import org.springframework.http.HttpStatus; @@ -20,7 +21,11 @@ public class ActionsTests extends RestTest { restClient.authenticateUser(dataContent.getAdminUser()); - RestActionDefinitionModelsCollection restActionDefinitions = restClient.withCoreAPI().usingActions().listActionDefinitions(); + RestActionDefinitionModelsCollection restActionDefinitions = restClient. + withCoreAPI(). + usingActions(). + listActionDefinitions(); + restClient.assertStatusCodeIs(HttpStatus.OK); assertFalse(restActionDefinitions.isEmpty()); restActionDefinitions.assertThat().entriesListContains("name", "copy"); @@ -28,4 +33,32 @@ public class ActionsTests extends RestTest restActionDefinitions.assertThat().entriesListContains("name", "check-out"); restActionDefinitions.assertThat().entriesListContains("name", "check-in"); } + + // TODO: TestGroup.ACTIONS not TestGroup.NODES + @TestRail(section = { TestGroup.REST_API,TestGroup.NODES }, executionType = ExecutionType.REGRESSION, + description = "Verify actions error conditions") + @Test(groups = { TestGroup.REST_API, TestGroup.NODES, TestGroup.REGRESSION}) + public void testActionDefinitionsNegative() throws Exception{ + // Badly formed request -> 400 + { + restClient.authenticateUser(dataContent.getAdminUser()). + // invalid skipCount + withParams("skipCount=-1"). + withCoreAPI(). + usingActions(). + listActionDefinitions(); + + restClient.assertStatusCodeIs(HttpStatus.BAD_REQUEST); + + } + + // Unauthorized -> 401 + { + + UserModel userUnauthorized = new UserModel("invalid-user", "invalid-pasword"); + restClient.authenticateUser(userUnauthorized).withCoreAPI().usingActions().listActionDefinitions(); + restClient.assertStatusCodeIs(HttpStatus.UNAUTHORIZED); + + } + } }