From 0237f4db68811c51111de49ed35f0ce02ee2df2e Mon Sep 17 00:00:00 2001
From: Angel Borroy <48685308+aborroy@users.noreply.github.com>
Date: Fri, 31 Jan 2020 14:36:52 +0100
Subject: [PATCH] =?UTF-8?q?SEARCH-2074:=20Add=20new=20queries=20tests=20to?=
 =?UTF-8?q?=20ensure=20these=20ANSI=20SQL=20queries=20w=E2=80=A6=20(#795)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* SEARCH-2074: Add new queries tests to ensure these ANSI SQL queries work with different database engines.

* SEARCH-2074: Check returned values from queries instead of asserting the value is not null.

* SEARCH-2074: Next TX Commit Time should be greater or equals to from commit time.
---
 .../repo/domain/node/NodeDAOTest.java         | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/src/test/java/org/alfresco/repo/domain/node/NodeDAOTest.java b/src/test/java/org/alfresco/repo/domain/node/NodeDAOTest.java
index 0f68493501..097de89665 100644
--- a/src/test/java/org/alfresco/repo/domain/node/NodeDAOTest.java
+++ b/src/test/java/org/alfresco/repo/domain/node/NodeDAOTest.java
@@ -368,4 +368,35 @@ public class NodeDAOTest extends TestCase
             Assert.assertEquals(node, clonedNode);          // Does NPE check implicitly
         }
     }
+
+    public void testGetMinTxInNodeIdRange()
+    {
+        Long fromNodeId = nodeDAO.getMinNodeId();
+        Long toNodeId = nodeDAO.getMaxNodeId();
+        
+        Long minTxCommitTime = nodeDAO.getMinTxnCommitTime();
+        
+        Long minTxCommitTimeInRange = nodeDAO.getMinTxInNodeIdRange(fromNodeId, toNodeId);
+        assertEquals(minTxCommitTime, minTxCommitTimeInRange);
+    }
+    
+    public void testGetMaxTxInNodeIdRange()
+    {
+        Long fromNodeId = nodeDAO.getMinNodeId();
+        Long toNodeId = nodeDAO.getMaxNodeId();
+        
+        Long maxTxCommitTime = nodeDAO.getMaxTxnCommitTime();
+        
+        Long maxTxCommitTimeInRange = nodeDAO.getMaxTxInNodeIdRange(fromNodeId, toNodeId);
+        assertEquals(maxTxCommitTime, maxTxCommitTimeInRange);
+    }
+    
+    public void testGetNextTxCommitTime()
+    {
+        Long fromCommitTime = nodeDAO.getMinTxnCommitTime();
+        
+        Long nextTxnCommitTime = nodeDAO.getNextTxCommitTime(fromCommitTime);
+        assertTrue(nextTxnCommitTime >= fromCommitTime);
+    }
+
 }
\ No newline at end of file