inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

update java docs & fix sonar "Mutable members should not be stored or returned directly" from PropertyModificationAllowedCheck class

Browse Source
This commit is contained in:
Rodica Sutu
2019-11-05 16:43:57 +02:00
parent 9e62b9a858
commit 02bdf0d92a
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/util/PropertyModificationAllowedCheck.java
View File

@@ -26,6 +26,8 @@
*/ */
package org.alfresco.module.org_alfresco_module_rm.util; package org.alfresco.module.org_alfresco_module_rm.util;
import static java.util.Collections.unmodifiableList;
import java.io.Serializable; import java.io.Serializable;
import java.util.HashSet; import java.util.HashSet;
import java.util.List; import java.util.List;
@@ -59,7 +61,7 @@ public class PropertyModificationAllowedCheck
*/ */
private List<String> getEditableURIs() private List<String> getEditableURIs()
{ {
return editableURIs; return unmodifiableList(editableURIs);
} }
/** /**
@@ -69,7 +71,7 @@ public class PropertyModificationAllowedCheck
*/ */
public void setEditableURIs(List<String> editableURIs) public void setEditableURIs(List<String> editableURIs)
{ {
this.editableURIs = editableURIs; this.editableURIs = unmodifiableList(editableURIs);
} }
/** /**
@@ -79,7 +81,8 @@ public class PropertyModificationAllowedCheck
*/ */
public void setWhiteList(List<QName> whiteList) public void setWhiteList(List<QName> whiteList)
{ {
this.whiteList = whiteList; this.whiteList = unmodifiableList(whiteList);
} }
/** /**
@@ -87,7 +90,8 @@ public class PropertyModificationAllowedCheck
* *
* @param before current node properties * @param before current node properties
* @param after updated properties for the node * @param after updated properties for the node
* @return true - if all modified property keys are in the whitelist * @return true - if all modified property keys are in the whitelist or
* in the list of model URI's for which the properties can be modified
*/ */
public boolean check(Map<QName, Serializable> before, Map<QName, Serializable> after) public boolean check(Map<QName, Serializable> before, Map<QName, Serializable> after)
{ {