From 04fa6611e09e60a685bbefaf0f50c052c07973a0 Mon Sep 17 00:00:00 2001 From: bsayan2 Date: Thu, 12 Jun 2025 18:27:03 +0530 Subject: [PATCH] MNT-24883 test case fix --- .../repo/content/transform/LocalTransformImpl.java | 7 ++++++- .../registry/LocalTransformServiceRegistryConfigTest.java | 5 +++++ .../resources/test/alfresco/test-renditions-context.xml | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/repository/src/main/java/org/alfresco/repo/content/transform/LocalTransformImpl.java b/repository/src/main/java/org/alfresco/repo/content/transform/LocalTransformImpl.java index 3b973ab518..c39789f0a3 100644 --- a/repository/src/main/java/org/alfresco/repo/content/transform/LocalTransformImpl.java +++ b/repository/src/main/java/org/alfresco/repo/content/transform/LocalTransformImpl.java @@ -157,7 +157,12 @@ public class LocalTransformImpl extends AbstractLocalTransform transformOptions.put(SOURCE_NODE_REF, sourceNodeRef.toString()); } - String filename = sourceNodeRef != null ? (String) nodeService.getProperty(sourceNodeRef, ContentModel.PROP_NAME) : null; + String filename = null; + if (sourceNodeRef != null && nodeService.exists(sourceNodeRef)) + { + filename = (String) nodeService.getProperty(sourceNodeRef, ContentModel.PROP_NAME); + } + if (StringUtils.isNotEmpty(filename)) { transformOptions.put(SOURCE_FILENAME, filename); diff --git a/repository/src/test/java/org/alfresco/transform/registry/LocalTransformServiceRegistryConfigTest.java b/repository/src/test/java/org/alfresco/transform/registry/LocalTransformServiceRegistryConfigTest.java index 394331aea1..0551b9cf57 100644 --- a/repository/src/test/java/org/alfresco/transform/registry/LocalTransformServiceRegistryConfigTest.java +++ b/repository/src/test/java/org/alfresco/transform/registry/LocalTransformServiceRegistryConfigTest.java @@ -64,6 +64,7 @@ import org.alfresco.repo.content.transform.LocalPipelineTransform; import org.alfresco.repo.content.transform.LocalTransformImpl; import org.alfresco.repo.content.transform.LocalTransformServiceRegistry; import org.alfresco.repo.content.transform.TransformerDebug; +import org.alfresco.service.cmr.repository.NodeService; import org.alfresco.transform.config.SupportedSourceAndTarget; import org.alfresco.transform.config.TransformConfig; import org.alfresco.transform.config.TransformOption; @@ -205,6 +206,9 @@ public class LocalTransformServiceRegistryConfigTest extends TransformRegistryMo @Mock private MimetypeMap mimetypeMap; + @Mock + private NodeService nodeService; + private Map> imagemagickSupportedTransformation; private Map> tikaSupportedTransformation; private Map> pdfRendererSupportedTransformation; @@ -232,6 +236,7 @@ public class LocalTransformServiceRegistryConfigTest extends TransformRegistryMo registry.setProperties(properties); registry.setTransformerDebug(transformerDebug); registry.setMimetypeService(mimetypeMap); + registry.setNodeService(nodeService); registry.setPipelineConfigDir(""); registry.setCronExpression(null); // just read it once registry.afterPropertiesSet(); diff --git a/repository/src/test/resources/test/alfresco/test-renditions-context.xml b/repository/src/test/resources/test/alfresco/test-renditions-context.xml index 990b71bf97..eea831a8f7 100644 --- a/repository/src/test/resources/test/alfresco/test-renditions-context.xml +++ b/repository/src/test/resources/test/alfresco/test-renditions-context.xml @@ -28,6 +28,7 @@ + \ No newline at end of file