Renamed method for calculating next disposition step and added null check.

This commit is contained in:
roxana
2016-10-31 14:41:58 +02:00
parent adc144e971
commit 0a79d24def
4 changed files with 19 additions and 16 deletions

View File

@@ -142,7 +142,7 @@
org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService.updateDispositionActionDefinition=RM_ALLOW
org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService.isNextDispositionActionEligible=RM.Read.0
org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService.getNextDispositionAction=RM.Read.0
org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService.updateDispositionWhenLinkingOrUnlinking=RM.Read.0
org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService.recalculateNextDispositionStep=RM.Read.0
org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService.getCompletedDispositionActions=RM.Read.0
org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService.getLastCompletedDispostionAction=RM.Read.0
org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService.isDisposableItemCutoff=RM.Read.0

View File

@@ -271,5 +271,5 @@ public interface DispositionService
*
* @param record
*/
void updateDispositionWhenLinkingOrUnlinking(NodeRef record);
void recalculateNextDispositionStep(NodeRef record);
}

View File

@@ -1095,12 +1095,14 @@ public class DispositionServiceImpl extends ServiceBaseImpl
return null;
}
public void updateDispositionWhenLinkingOrUnlinking(NodeRef record)
public void recalculateNextDispositionStep(NodeRef record)
{
List<NodeRef> recordFolders = recordFolderService.getRecordFolders(record);
DispositionAction nextDispositionAction = getNextDispositionAction(record);
if (nextDispositionAction != null)
{
NextActionFromDisposition dsNextAction = getNextDispositionAction(record, recordFolders, nextDispositionAction);
final NodeRef action = dsNextAction.getNextActionNodeRef();
final Date dispositionActionDate = dsNextAction.getNextActionDateAsOf();
@@ -1114,6 +1116,7 @@ public class DispositionServiceImpl extends ServiceBaseImpl
}
});
}
}
/**
* Helper method to determine if a node is frozen or has frozen children

View File

@@ -546,7 +546,7 @@ public class RecordServiceImpl extends BaseBehaviourBean
// create and file the content as a record
file(nodeRef);
// recalculate disposition schedule for the record when linking it
dispositionService.updateDispositionWhenLinkingOrUnlinking(nodeRef);
dispositionService.recalculateNextDispositionStep(nodeRef);
}
}
}
@@ -1720,7 +1720,7 @@ public class RecordServiceImpl extends BaseBehaviourBean
QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, name));
// recalculate disposition schedule for the record when linking it
dispositionService.updateDispositionWhenLinkingOrUnlinking(record);
dispositionService.recalculateNextDispositionStep(record);
}
else
{
@@ -1779,7 +1779,7 @@ public class RecordServiceImpl extends BaseBehaviourBean
nodeService.removeChild(recordFolder, record);
// recalculate disposition schedule for record after unlinking it
dispositionService.updateDispositionWhenLinkingOrUnlinking(record);
dispositionService.recalculateNextDispositionStep(record);
}
else
{