Fix ALF-19749: NodeService/CopyService interface changes breaks backwards compatibility with add-ons

- This maintains binary compatibility with extensions build before 4.2
 - e.g.  GOOGLEDOCS-235 Unable to deploy latest Google Docs Enterprise AMPs onto 4.2 (HEAD-QA) 
 - Reversed ALF-19217: NodeService and CopyService APIs return modified flags
   We are back to creating redundant versions when duplicate changes are made to data


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@54488 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/repo/coci/CheckOutCheckInServiceImpl.java

@@ -581,7 +581,7 @@ public class CheckOutCheckInServiceImpl implements CheckOutCheckInService
         }
             
         // Copy the contents of the working copy onto the original
-        boolean copied = this.copyService.copy(workingCopyNodeRef, nodeRef);
+        this.copyService.copy(workingCopyNodeRef, nodeRef);
         
         // Handle name change on working copy (only for folders/files)
         if (fileFolderService.getFileInfo(workingCopyNodeRef) != null)
@@ -628,10 +628,8 @@ public class CheckOutCheckInServiceImpl implements CheckOutCheckInService
                 }
             }
         }
-
-        // Create a version if something was modified and copied to th node from working copy
-        // See MNT-8789
-        if (versionProperties != null && nodeService.hasAspect(nodeRef, ContentModel.ASPECT_VERSIONABLE) && copied)
+            
+        if (versionProperties != null && nodeService.hasAspect(nodeRef, ContentModel.ASPECT_VERSIONABLE))
         {
             // Create the new version
             this.versionService.createVersion(nodeRef, versionProperties);