diff --git a/source/java/org/alfresco/rest/api/audit/AuditApplicationsAuditEntriesRelation.java b/source/java/org/alfresco/rest/api/audit/AuditApplicationsAuditEntriesRelation.java index ae6d269e8f..268af74d78 100644 --- a/source/java/org/alfresco/rest/api/audit/AuditApplicationsAuditEntriesRelation.java +++ b/source/java/org/alfresco/rest/api/audit/AuditApplicationsAuditEntriesRelation.java @@ -54,6 +54,9 @@ public class AuditApplicationsAuditEntriesRelation implements RelationshipResour ParameterCheck.mandatory("audit", this.audit); } + /** + * If auditAppId does not exist, EntityNotFoundException (status 404). + */ @WebApiDescription(title = "Returns audit entries for audit app id") @Override public CollectionWithPagingInfo readAll(String auditAppId, Parameters parameters) diff --git a/source/java/org/alfresco/rest/api/impl/AuditImpl.java b/source/java/org/alfresco/rest/api/impl/AuditImpl.java index 7abaa86665..41976988f1 100644 --- a/source/java/org/alfresco/rest/api/impl/AuditImpl.java +++ b/source/java/org/alfresco/rest/api/impl/AuditImpl.java @@ -182,6 +182,8 @@ public class AuditImpl implements Audit public CollectionWithPagingInfo listAuditEntries(String auditAppId, Parameters parameters) { checkEnabled(); + + validateAuditAppId(auditAppId); // adding orderBy property Pair sortProp = getAuditEntrySortProp(parameters); @@ -228,6 +230,18 @@ public class AuditImpl implements Audit } + private void validateAuditAppId(String auditAppId) + { + AuditService.AuditApplication auditApplication = findAuditAppById(auditAppId); + + // Check if id is valid + if (auditApplication == null) + { + throw new EntityNotFoundException(auditAppId); + } + + } + /** * * @param parameters @@ -417,13 +431,7 @@ public class AuditImpl implements Audit { checkEnabled(); - AuditService.AuditApplication auditApplication = findAuditAppById(auditAppId); - - // Check if id is valid - if (auditApplication == null) - { - throw new EntityNotFoundException(auditAppId); - } + validateAuditAppId(auditAppId); // Enable/Disable audit application if (auditApp.getIsEnabled() && !auditApplication.isEnabled())