[feature/MNT-24127-EndpointToCalculateFolderSize] Addressing review comments related to calculate and retrieve folder size details

This commit is contained in:
mohit-singh4
2024-10-08 11:21:53 +05:30
parent 18901c779d
commit 1027bc14cd
2 changed files with 10 additions and 8 deletions

View File

@@ -78,12 +78,14 @@ public class SizeDetailsImpl implements SizeDetails, InitializingBean
Optional<NodeSizeDetails> optionalDetails = nodeSizeDetailsService.getSizeDetails(nodeId);
return optionalDetails.map(details -> {
String cachedJobId = details.getJobId();
if (cachedJobId != null && !jobId.equalsIgnoreCase(cachedJobId)) {
throw new NotFoundException("jobId does not exist");
}
return details;
}).orElseGet(() -> new NodeSizeDetails(nodeId, STATUS.NOT_INITIATED));
String cachedJobId = details.getJobId();
if (cachedJobId != null && !jobId.equalsIgnoreCase(cachedJobId))
{
throw new NotFoundException("jobId does not exist");
}
return details;
})
.orElseGet(() -> new NodeSizeDetails(nodeId, STATUS.NOT_INITIATED));
}
/**

View File

@@ -74,8 +74,8 @@ public class SizeDetailsImplTest
verify(nodeSizeDetailsServiceImpl).setSimpleCache(simpleCache);
nodeSizeDetailsServiceImpl.setThreadPoolExecutor(threadPoolExecutor);
sizeDetailsImpl = new SizeDetailsImpl(nodes, nodeSizeDetailsServiceImpl);
// sizeDetailsImpl.setNodes(nodes);
// sizeDetailsImpl.setNodeSizeDetailsService(nodeSizeDetailsServiceImpl);
// sizeDetailsImpl.setNodes(nodes);
// sizeDetailsImpl.setNodeSizeDetailsService(nodeSizeDetailsServiceImpl);
}
@Test