inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-14 17:58:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

REPO-1027: V1 REST API - minor: tweak TestSiteMembers

Browse Source 
- to make it repeatable (TODO further splitting/refactoring)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/DEV/5.2.N/root@130918 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Jan Vonka
2016-09-26 15:26:57 +00:00
parent 6e857ad3bf
commit 114ce8b02c
2 changed files with 26 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/test-java/org/alfresco/rest/api/tests/RepoService.java
View File

@@ -1400,8 +1400,11 @@ public class RepoService
public TestPerson createUser() public TestPerson createUser()
{ {
String username = "user" + System.currentTimeMillis(); long timeMillis = System.currentTimeMillis();
PersonInfo personInfo = new PersonInfo("FirstName", "LastName", username, "password", null, "skype", "location", String firstname = "first" + timeMillis;
String lastname = "last" + timeMillis;
String username = "user" + timeMillis;
PersonInfo personInfo = new PersonInfo(firstname, lastname, username, "password", null, "skype", "location",
"telephone", "mob", "instant", "google"); "telephone", "mob", "instant", "google");
TestPerson person = createUser(personInfo); TestPerson person = createUser(personInfo);
return person; return person;

31
source/test-java/org/alfresco/rest/api/tests/TestSiteMembers.java
View File

@@ -240,6 +240,10 @@ public class TestSiteMembers extends EnterpriseTestApi
} }
}, network1.getId()); }, network1.getId());
final TestPerson person1 = people.get(0);
final TestPerson person2 = people.get(1);
final TestPerson person3 = people.get(2);
TenantUtil.runAsSystemTenant(new TenantRunAsWork<Void>() TenantUtil.runAsSystemTenant(new TenantRunAsWork<Void>()
{ {
@Override @Override
@@ -252,9 +256,6 @@ public class TestSiteMembers extends EnterpriseTestApi
} }
}, network2.getId()); }, network2.getId());
final TestPerson person1 = people.get(0);
final TestPerson person2 = people.get(1);
final TestPerson person3 = people.get(2);
final TestPerson person4 = people.get(3); final TestPerson person4 = people.get(3);
// Create site // Create site
@@ -641,17 +642,19 @@ public class TestSiteMembers extends EnterpriseTestApi
person1.expected(ret.getMember()); person1.expected(ret.getMember());
// check site membership in GET // check site membership in GET
expectedSiteMembers = site.getMembers(); SiteMember smToCheck = sitesProxy.getSingleSiteMember(site.getSiteId(), person1.getId());
SiteMember toCheck = null; assertNotNull(smToCheck); // check that the update site membership is present
for(SiteMember sm1 : expectedSiteMembers) assertEquals(sm.getRole(), smToCheck.getRole()); // check that the role is correct
{
if(sm1.getMemberId().equals(person1.getId()))
{ expectedSiteMembers = new ArrayList<>();
toCheck = sm1; SiteMember sm1 = new SiteMember(person1.getId(), person1, site.getSiteId(), SiteRole.SiteCollaborator.toString());
} expectedSiteMembers.add(sm1);
} SiteMember sm2 = new SiteMember(person2.getId(), person2, site.getSiteId(), SiteRole.SiteManager.toString());
assertNotNull(toCheck); // check that the update site membership is present expectedSiteMembers.add(sm2);
assertEquals(sm.getRole(), toCheck.getRole()); // check that the role is correct SiteMember sm3 = new SiteMember(person3.getId(), person3, site.getSiteId(), SiteRole.SiteCollaborator.toString());
expectedSiteMembers.add(sm3);
Collections.sort(expectedSiteMembers);
int skipCount = 0; int skipCount = 0;
int maxItems = Integer.MAX_VALUE; int maxItems = Integer.MAX_VALUE;