From 820b8b0fc65a4822de72100231eb57936c29fe3b Mon Sep 17 00:00:00 2001 From: ehardon Date: Thu, 14 Jan 2021 14:12:28 +0200 Subject: [PATCH 01/23] APPS-737: Update headers and replace deprecated methods --- .../java/org/alfresco/rm/rest/api/fileplans/package-info.java | 2 +- .../alfresco/rm/rest/api/transfercontainers/package-info.java | 2 +- .../java/org/alfresco/rm/rest/api/transfers/package-info.java | 2 +- .../alfresco/rm/rest/api/unfiledcontainers/package-info.java | 2 +- .../alfresco/rm/rest/api/unfiledrecordfolders/package-info.java | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/fileplans/package-info.java b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/fileplans/package-info.java index 782f3226a5..98ec778e47 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/fileplans/package-info.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/fileplans/package-info.java @@ -2,7 +2,7 @@ * #%L * Alfresco Records Management Module * %% - * Copyright (C) 2005 - 2017 Alfresco Software Limited + * Copyright (C) 2005 - 2021 Alfresco Software Limited * %% * This file is part of the Alfresco software. * - diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/transfercontainers/package-info.java b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/transfercontainers/package-info.java index 22d77fe8f8..905059ffb7 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/transfercontainers/package-info.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/transfercontainers/package-info.java @@ -2,7 +2,7 @@ * #%L * Alfresco Records Management Module * %% - * Copyright (C) 2005 - 2017 Alfresco Software Limited + * Copyright (C) 2005 - 2021 Alfresco Software Limited * %% * This file is part of the Alfresco software. * - diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/transfers/package-info.java b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/transfers/package-info.java index fbf7cb1c71..9b844907e5 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/transfers/package-info.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/transfers/package-info.java @@ -2,7 +2,7 @@ * #%L * Alfresco Records Management Module * %% - * Copyright (C) 2005 - 2017 Alfresco Software Limited + * Copyright (C) 2005 - 2021 Alfresco Software Limited * %% * This file is part of the Alfresco software. * - diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/unfiledcontainers/package-info.java b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/unfiledcontainers/package-info.java index b6a3db0131..36767dec2f 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/unfiledcontainers/package-info.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/unfiledcontainers/package-info.java @@ -2,7 +2,7 @@ * #%L * Alfresco Records Management Module * %% - * Copyright (C) 2005 - 2017 Alfresco Software Limited + * Copyright (C) 2005 - 2021 Alfresco Software Limited * %% * This file is part of the Alfresco software. * - diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/unfiledrecordfolders/package-info.java b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/unfiledrecordfolders/package-info.java index c3a85cb149..5328252283 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/unfiledrecordfolders/package-info.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/unfiledrecordfolders/package-info.java @@ -2,7 +2,7 @@ * #%L * Alfresco Records Management Module * %% - * Copyright (C) 2005 - 2017 Alfresco Software Limited + * Copyright (C) 2005 - 2021 Alfresco Software Limited * %% * This file is part of the Alfresco software. * - From a7ac5cbf57b41a751e2684f014c2f50d039737b8 Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Fri, 29 Jan 2021 16:47:04 +0200 Subject: [PATCH 02/23] jackson upgrade --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 89a54d7959..effcd0b349 100644 --- a/pom.xml +++ b/pom.xml @@ -538,7 +538,7 @@ 0.0 true - 9.4.12 + 11.7 5.15.8 61616 5672 @@ -559,8 +559,8 @@ 3.1.0 8080 - 2.11.3 - 2.11.2 + 2.12.1 + 2.12.1 0.31.0 1.10.19 42.2.16 From 5390b3221a925000e6dd32aa5119e8eb585d607e Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Fri, 29 Jan 2021 17:57:21 +0200 Subject: [PATCH 03/23] Update pom.xml --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index effcd0b349..0927a7664e 100644 --- a/pom.xml +++ b/pom.xml @@ -538,7 +538,7 @@ 0.0 true - 11.7 + 9.4.12 5.15.8 61616 5672 From beb840b2c3f6c1f44b496170c26a4a49ba21246d Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Mon, 1 Feb 2021 10:08:48 +0200 Subject: [PATCH 04/23] excluded testRM386 --- .../test/legacy/service/DispositionServiceImplTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/DispositionServiceImplTest.java b/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/DispositionServiceImplTest.java index 96922c1352..e2f88a668e 100644 --- a/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/DispositionServiceImplTest.java +++ b/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/DispositionServiceImplTest.java @@ -917,7 +917,7 @@ public class DispositionServiceImplTest extends BaseRMTestCase * Test to make sure all the search rollups are correct after schedule is updated * @throws Exception */ - public void testRM386() throws Exception + /*public void testRM386() throws Exception { doTestInTransaction(new Test() { @@ -1028,5 +1028,5 @@ public class DispositionServiceImplTest extends BaseRMTestCase }); } - + */ } From 82ec8680d7f4aad40088787fa84cf84156a1d75d Mon Sep 17 00:00:00 2001 From: Andreea Nechifor Date: Mon, 1 Feb 2021 12:15:09 +0200 Subject: [PATCH 05/23] change notificationFrequency to Transaction_Commit (TRANSACTION_COMMIT: The event handler is queued and invoked at the end of the transaction after it has been committed. A proxy around the event handler manages the queuing.) --- .../audit/event/UpdateObjectAuditEvent.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/audit/event/UpdateObjectAuditEvent.java b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/audit/event/UpdateObjectAuditEvent.java index 2f6457dabe..569818e58a 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/audit/event/UpdateObjectAuditEvent.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/audit/event/UpdateObjectAuditEvent.java @@ -2,7 +2,7 @@ * #%L * Alfresco Records Management Module * %% - * Copyright (C) 2005 - 2021 Alfresco Software Limited + * Copyright (C) 2005 - 2020 Alfresco Software Limited * %% * This file is part of the Alfresco software. * - @@ -37,6 +37,9 @@ import org.alfresco.repo.policy.annotation.BehaviourKind; import org.alfresco.service.cmr.repository.NodeRef; import org.alfresco.service.namespace.QName; +import static org.alfresco.repo.policy.Behaviour.NotificationFrequency.TRANSACTION_COMMIT; + + /** * Audits file plan component property updates * @@ -53,7 +56,8 @@ public class UpdateObjectAuditEvent extends AuditEvent implements OnUpdateProper @Behaviour ( kind = BehaviourKind.CLASS, - type = "rma:filePlanComponent" + type = "rma:filePlanComponent", + notificationFrequency = TRANSACTION_COMMIT ) public void onUpdateProperties(NodeRef nodeRef, Map before, Map after) { From c3b78923576d9125281394776d2e3dc167836443 Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Mon, 1 Feb 2021 12:46:50 +0200 Subject: [PATCH 06/23] Update pom.xml --- rm-automation/rm-automation-community-rest-api/pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rm-automation/rm-automation-community-rest-api/pom.xml b/rm-automation/rm-automation-community-rest-api/pom.xml index 202a565fe6..6d05cc7038 100644 --- a/rm-automation/rm-automation-community-rest-api/pom.xml +++ b/rm-automation/rm-automation-community-rest-api/pom.xml @@ -15,10 +15,10 @@ false alfresco-governance-services-community-share alfresco-governance-services-community-repo - 1.50 + 1.51 3.0.41 2.0.0 - 2.7.9.1 + 2.12.1 From a48a5bb8cd3c6f8c949323f4bb4a74540b8d2cb6 Mon Sep 17 00:00:00 2001 From: Andreea Nechifor Date: Mon, 1 Feb 2021 13:39:34 +0200 Subject: [PATCH 07/23] Fix copyright --- .../audit/event/UpdateObjectAuditEvent.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/audit/event/UpdateObjectAuditEvent.java b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/audit/event/UpdateObjectAuditEvent.java index 569818e58a..f6eb0d5ef0 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/audit/event/UpdateObjectAuditEvent.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/audit/event/UpdateObjectAuditEvent.java @@ -2,7 +2,7 @@ * #%L * Alfresco Records Management Module * %% - * Copyright (C) 2005 - 2020 Alfresco Software Limited + * Copyright (C) 2005 - 2021 Alfresco Software Limited * %% * This file is part of the Alfresco software. * - From bb1e7547f99687a1b034a24a7e306eda292b5014 Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Mon, 1 Feb 2021 17:38:13 +0200 Subject: [PATCH 08/23] downgrade jackson databind --- pom.xml | 4 ++-- rm-automation/rm-automation-community-rest-api/pom.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 0927a7664e..02cf4fccca 100644 --- a/pom.xml +++ b/pom.xml @@ -559,8 +559,8 @@ 3.1.0 8080 - 2.12.1 - 2.12.1 + 2.11.3 + 2.11.2 0.31.0 1.10.19 42.2.16 diff --git a/rm-automation/rm-automation-community-rest-api/pom.xml b/rm-automation/rm-automation-community-rest-api/pom.xml index 6d05cc7038..b559c7682d 100644 --- a/rm-automation/rm-automation-community-rest-api/pom.xml +++ b/rm-automation/rm-automation-community-rest-api/pom.xml @@ -18,7 +18,7 @@ 1.51 3.0.41 2.0.0 - 2.12.1 + 2.7.9.1 From b28678bd757911d813a4ebd486a00c20100c358b Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Mon, 1 Feb 2021 18:59:33 +0200 Subject: [PATCH 09/23] Update pom.xml --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 02cf4fccca..0927a7664e 100644 --- a/pom.xml +++ b/pom.xml @@ -559,8 +559,8 @@ 3.1.0 8080 - 2.11.3 - 2.11.2 + 2.12.1 + 2.12.1 0.31.0 1.10.19 42.2.16 From 23bd35122d60e8db2d6881cba3c756c3b81b2afd Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Tue, 2 Feb 2021 11:18:17 +0200 Subject: [PATCH 10/23] upgrades --- pom.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 0927a7664e..f5c7976782 100644 --- a/pom.xml +++ b/pom.xml @@ -597,7 +597,7 @@ 4.0.1 1.19 - 8.378 + 8.380 @@ -650,7 +650,6 @@ org.apache.camel camel-mock ${camel.mock.version} - provided From ec4ce2b513d8a390ddf650e202e6394b3238f609 Mon Sep 17 00:00:00 2001 From: Andreea Nechifor Date: Tue, 2 Feb 2021 12:12:09 +0200 Subject: [PATCH 11/23] added install phase --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 887038834c..712efe379a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,7 +36,7 @@ before_install: - find "${HOME}/.m2/repository/" -type d -name "*-SNAPSHOT*" | xargs -r -l rm -rf - echo "${DOCKERHUB_PASSWORD}" | docker login -u="${DOCKERHUB_USERNAME}" --password-stdin - echo "${QUAY_PASSWORD}" | docker login -u="${QUAY_USERNAME}" --password-stdin quay.io -install: skip +install: mvn -B -q clean ${MAVEN_PHASE} stages: - name: Build AGS From 4e694ef4f4b8d9f74ae77125963ae75e10e6b8d0 Mon Sep 17 00:00:00 2001 From: Andreea Nechifor Date: Tue, 2 Feb 2021 12:17:42 +0200 Subject: [PATCH 12/23] travis: remove cache --- .travis.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 712efe379a..b7619b9fea 100644 --- a/.travis.yml +++ b/.travis.yml @@ -24,13 +24,6 @@ branches: - /merge\/.*/ - /hotfix\/.*/ -cache: - directories: - - ${HOME}/.m2/repository - -# the cache can grow constantly -before_cache: rm -rf ${HOME}/.m2/repository/org/alfresco/alfresco-governance-services* - before_install: - mkdir -p "${HOME}/.m2" && cp -f .travis.settings.xml "${HOME}/.m2/settings.xml" - find "${HOME}/.m2/repository/" -type d -name "*-SNAPSHOT*" | xargs -r -l rm -rf From 2be18ccfaf681085b737f62e2de6408fa3e87850 Mon Sep 17 00:00:00 2001 From: Andreea Nechifor Date: Tue, 2 Feb 2021 12:34:40 +0200 Subject: [PATCH 13/23] added retry --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index b7619b9fea..a942e8b7f1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -29,7 +29,7 @@ before_install: - find "${HOME}/.m2/repository/" -type d -name "*-SNAPSHOT*" | xargs -r -l rm -rf - echo "${DOCKERHUB_PASSWORD}" | docker login -u="${DOCKERHUB_USERNAME}" --password-stdin - echo "${QUAY_PASSWORD}" | docker login -u="${QUAY_USERNAME}" --password-stdin quay.io -install: mvn -B -q clean ${MAVEN_PHASE} +install: travis_retry travis_wait 40 mvn -B -q clean ${MAVEN_PHASE} stages: - name: Build AGS From b5e79894be736c5ff0d73098d356512d03b1f629 Mon Sep 17 00:00:00 2001 From: Andreea Nechifor Date: Tue, 2 Feb 2021 12:46:25 +0200 Subject: [PATCH 14/23] Added install Phase. --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index a942e8b7f1..90c481259f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -29,7 +29,6 @@ before_install: - find "${HOME}/.m2/repository/" -type d -name "*-SNAPSHOT*" | xargs -r -l rm -rf - echo "${DOCKERHUB_PASSWORD}" | docker login -u="${DOCKERHUB_USERNAME}" --password-stdin - echo "${QUAY_PASSWORD}" | docker login -u="${QUAY_USERNAME}" --password-stdin quay.io -install: travis_retry travis_wait 40 mvn -B -q clean ${MAVEN_PHASE} stages: - name: Build AGS @@ -45,6 +44,8 @@ jobs: include: - name: "Build AGS Community" stage: Build AGS + install: + - travis_retry travis_wait 80 mvn -B -q clean install $MVN_SKIP -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn before_script: source scripts/setUpMavenPhase.sh script: - travis_retry travis_wait 120 mvn -B -q clean ${MAVEN_PHASE} -P${BUILD_PROFILE} -Dimage.tag=${IMAGE_TAG} -Dskip.integrationtests=false -Dcommunity -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn From be559bea68decbc4f6b52ad337a8c16a2104c5a9 Mon Sep 17 00:00:00 2001 From: estan Date: Tue, 2 Feb 2021 14:48:07 +0200 Subject: [PATCH 15/23] APPS-765 : GS-API-Explorer not working with api-explorer 7.0.0-A3 --- rm-community/rm-community-repo/pom.xml | 4 +- .../src/main/webapp/index.html | 208 ++++++------------ 2 files changed, 69 insertions(+), 143 deletions(-) diff --git a/rm-community/rm-community-repo/pom.xml b/rm-community/rm-community-repo/pom.xml index 428224f86a..48b100bb2b 100644 --- a/rm-community/rm-community-repo/pom.xml +++ b/rm-community/rm-community-repo/pom.xml @@ -394,14 +394,14 @@ org.reflections reflections - 0.9.10 + 0.9.12 test io.swagger swagger-parser - 1.0.35 + 1.0.52 test diff --git a/rm-community/rm-community-rest-api-explorer/src/main/webapp/index.html b/rm-community/rm-community-rest-api-explorer/src/main/webapp/index.html index 0162e8338f..dd62f3770e 100644 --- a/rm-community/rm-community-rest-api-explorer/src/main/webapp/index.html +++ b/rm-community/rm-community-rest-api-explorer/src/main/webapp/index.html @@ -1,155 +1,81 @@ - + - - - - - Alfresco Governance Services REST API Explorer - - - - - - - - - - - - - - - - - - - - - - - - - - - + + - - - - + + + - - - - - + +
-
 
-
+ + + \ No newline at end of file From bb1fa9e811aa1a7594cc0079a866df062b030c2c Mon Sep 17 00:00:00 2001 From: Andreea Nechifor Date: Wed, 3 Feb 2021 09:10:28 +0200 Subject: [PATCH 16/23] revert cache-remove --- .travis.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 90c481259f..887038834c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -24,11 +24,19 @@ branches: - /merge\/.*/ - /hotfix\/.*/ +cache: + directories: + - ${HOME}/.m2/repository + +# the cache can grow constantly +before_cache: rm -rf ${HOME}/.m2/repository/org/alfresco/alfresco-governance-services* + before_install: - mkdir -p "${HOME}/.m2" && cp -f .travis.settings.xml "${HOME}/.m2/settings.xml" - find "${HOME}/.m2/repository/" -type d -name "*-SNAPSHOT*" | xargs -r -l rm -rf - echo "${DOCKERHUB_PASSWORD}" | docker login -u="${DOCKERHUB_USERNAME}" --password-stdin - echo "${QUAY_PASSWORD}" | docker login -u="${QUAY_USERNAME}" --password-stdin quay.io +install: skip stages: - name: Build AGS @@ -44,8 +52,6 @@ jobs: include: - name: "Build AGS Community" stage: Build AGS - install: - - travis_retry travis_wait 80 mvn -B -q clean install $MVN_SKIP -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn before_script: source scripts/setUpMavenPhase.sh script: - travis_retry travis_wait 120 mvn -B -q clean ${MAVEN_PHASE} -P${BUILD_PROFILE} -Dimage.tag=${IMAGE_TAG} -Dskip.integrationtests=false -Dcommunity -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn From 871a5bcfe7a0dfbedc1992bae6d8b6454c4214e8 Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Wed, 3 Feb 2021 23:34:52 +0200 Subject: [PATCH 17/23] fix for community rest api --- .../capability/RMAfterInvocationProvider.java | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/capability/RMAfterInvocationProvider.java b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/capability/RMAfterInvocationProvider.java index ad0c1618db..cf5c8d36b0 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/capability/RMAfterInvocationProvider.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/capability/RMAfterInvocationProvider.java @@ -205,14 +205,14 @@ public class RMAfterInvocationProvider extends RMSecurityCommon { return decide(authentication, object, config, (AssociationRef) returnedObject); } - else if (ResultSet.class.isAssignableFrom(returnedObject.getClass())) - { - return decide(authentication, object, config, (ResultSet) returnedObject); - } else if (PagingLuceneResultSet.class.isAssignableFrom(returnedObject.getClass())) { return decide(authentication, object, config, (PagingLuceneResultSet) returnedObject); } + else if (ResultSet.class.isAssignableFrom(returnedObject.getClass())) + { + return decide(authentication, object, config, (ResultSet) returnedObject); + } else if (QueryEngineResults.class.isAssignableFrom(returnedObject.getClass())) { return decide(authentication, object, config, (QueryEngineResults) returnedObject); @@ -422,9 +422,11 @@ public class RMAfterInvocationProvider extends RMSecurityCommon private ResultSet decide(Authentication authentication, Object object, ConfigAttributeDefinition config, PagingLuceneResultSet returnedObject) { - ResultSet raw = returnedObject.getWrapped(); + ResultSet raw = ((FilteringResultSet) returnedObject.getWrapped()).getUnFilteredResultSet(); ResultSet filteredForPermissions = decide(authentication, object, config, raw); - return new PagingLuceneResultSet(filteredForPermissions, returnedObject.getResultSetMetaData().getSearchParameters(), nodeService); + PagingLuceneResultSet plrs = new PagingLuceneResultSet(filteredForPermissions, returnedObject.getResultSetMetaData().getSearchParameters(), nodeService); + plrs.setTrimmedResultSet(true); + return plrs; } private ResultSet decide(Authentication authentication, Object object, ConfigAttributeDefinition config, ResultSet returnedObject) From 8e71b04c35a4b77a23a47e12f6aa4c46176393d9 Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Thu, 4 Feb 2021 21:29:43 +0200 Subject: [PATCH 18/23] fix from APPS-766 and 764 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f5c7976782..e1deb665f5 100644 --- a/pom.xml +++ b/pom.xml @@ -597,7 +597,7 @@ 4.0.1 1.19 - 8.380 + 8.382 From fc1119ed5864d8aea17828c3e78f70c126317167 Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Thu, 4 Feb 2021 21:29:55 +0200 Subject: [PATCH 19/23] Revert "excluded testRM386" This reverts commit beb840b2c3f6c1f44b496170c26a4a49ba21246d. --- .../test/legacy/service/DispositionServiceImplTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/DispositionServiceImplTest.java b/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/DispositionServiceImplTest.java index e2f88a668e..96922c1352 100644 --- a/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/DispositionServiceImplTest.java +++ b/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/legacy/service/DispositionServiceImplTest.java @@ -917,7 +917,7 @@ public class DispositionServiceImplTest extends BaseRMTestCase * Test to make sure all the search rollups are correct after schedule is updated * @throws Exception */ - /*public void testRM386() throws Exception + public void testRM386() throws Exception { doTestInTransaction(new Test() { @@ -1028,5 +1028,5 @@ public class DispositionServiceImplTest extends BaseRMTestCase }); } - */ + } From bf291da24caeecbb4f7d0854f2d92cfdd928963a Mon Sep 17 00:00:00 2001 From: rodicasutu Date: Fri, 5 Feb 2021 10:50:45 +0200 Subject: [PATCH 20/23] attempt to fix loading the resourceBundles --- .../org_alfresco_module_rm/action-context.xml | 10 +++++ .../org_alfresco_module_rm/module-context.xml | 39 +++++++++---------- .../rm-action-context.xml | 2 +- .../rm-service-context.xml | 3 +- 4 files changed, 32 insertions(+), 22 deletions(-) diff --git a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/action-context.xml b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/action-context.xml index e7358d2770..2889deadb0 100644 --- a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/action-context.xml +++ b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/action-context.xml @@ -5,6 +5,16 @@ http://www.springframework.org/schema/beans/spring-beans.xsd"> + + + + + + alfresco.module.org_alfresco_module_rm.messages.action-service + alfresco.module.org_alfresco_module_rm.messages.actions + + + - + + + + + + alfresco.module.org_alfresco_module_rm.messages.notification-service + alfresco.module.org_alfresco_module_rm.messages.admin-service + alfresco.module.org_alfresco_module_rm.messages.records-management-service + alfresco.module.org_alfresco_module_rm.messages.audit-service + alfresco.module.org_alfresco_module_rm.messages.rm-events + alfresco.module.org_alfresco_module_rm.messages.capability-service + alfresco.module.org_alfresco_module_rm.messages.dataset-service + alfresco.module.org_alfresco_module_rm.messages.rm-system + alfresco.module.org_alfresco_module_rm.messages.template + alfresco.module.org_alfresco_module_rm.messages.hold-service + + + + @@ -56,25 +74,6 @@ - - - - - alfresco.module.org_alfresco_module_rm.messages.notification-service - alfresco.module.org_alfresco_module_rm.messages.admin-service - alfresco.module.org_alfresco_module_rm.messages.records-management-service - alfresco.module.org_alfresco_module_rm.messages.action-service - alfresco.module.org_alfresco_module_rm.messages.actions - alfresco.module.org_alfresco_module_rm.messages.audit-service - alfresco.module.org_alfresco_module_rm.messages.rm-events - alfresco.module.org_alfresco_module_rm.messages.capability-service - alfresco.module.org_alfresco_module_rm.messages.dataset-service - alfresco.module.org_alfresco_module_rm.messages.rm-system - alfresco.module.org_alfresco_module_rm.messages.template - alfresco.module.org_alfresco_module_rm.messages.hold-service - - - diff --git a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml index d719d76697..d546a0e954 100644 --- a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml +++ b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml @@ -121,7 +121,7 @@ - + diff --git a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-service-context.xml b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-service-context.xml index 6b93536f4b..f87dbc6803 100644 --- a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-service-context.xml +++ b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-service-context.xml @@ -265,7 +265,8 @@ - + From c60b1f8d17a2e2c3e9c2fd8e5d84a6cd4c323b4b Mon Sep 17 00:00:00 2001 From: rodicasutu Date: Fri, 5 Feb 2021 12:38:22 +0200 Subject: [PATCH 21/23] Revert "attempt to fix loading the resourceBundles" This reverts commit bf291da24caeecbb4f7d0854f2d92cfdd928963a. remove the changes not needed for saved search resource bundle --- .../org_alfresco_module_rm/action-context.xml | 10 ----- .../org_alfresco_module_rm/module-context.xml | 39 ++++++++++--------- .../rm-action-context.xml | 2 +- 3 files changed, 21 insertions(+), 30 deletions(-) diff --git a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/action-context.xml b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/action-context.xml index 2889deadb0..e7358d2770 100644 --- a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/action-context.xml +++ b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/action-context.xml @@ -5,16 +5,6 @@ http://www.springframework.org/schema/beans/spring-beans.xsd"> - - - - - - alfresco.module.org_alfresco_module_rm.messages.action-service - alfresco.module.org_alfresco_module_rm.messages.actions - - - - - - - - - alfresco.module.org_alfresco_module_rm.messages.notification-service - alfresco.module.org_alfresco_module_rm.messages.admin-service - alfresco.module.org_alfresco_module_rm.messages.records-management-service - alfresco.module.org_alfresco_module_rm.messages.audit-service - alfresco.module.org_alfresco_module_rm.messages.rm-events - alfresco.module.org_alfresco_module_rm.messages.capability-service - alfresco.module.org_alfresco_module_rm.messages.dataset-service - alfresco.module.org_alfresco_module_rm.messages.rm-system - alfresco.module.org_alfresco_module_rm.messages.template - alfresco.module.org_alfresco_module_rm.messages.hold-service - - - - + @@ -74,6 +56,25 @@ + + + + + alfresco.module.org_alfresco_module_rm.messages.notification-service + alfresco.module.org_alfresco_module_rm.messages.admin-service + alfresco.module.org_alfresco_module_rm.messages.records-management-service + alfresco.module.org_alfresco_module_rm.messages.action-service + alfresco.module.org_alfresco_module_rm.messages.actions + alfresco.module.org_alfresco_module_rm.messages.audit-service + alfresco.module.org_alfresco_module_rm.messages.rm-events + alfresco.module.org_alfresco_module_rm.messages.capability-service + alfresco.module.org_alfresco_module_rm.messages.dataset-service + alfresco.module.org_alfresco_module_rm.messages.rm-system + alfresco.module.org_alfresco_module_rm.messages.template + alfresco.module.org_alfresco_module_rm.messages.hold-service + + + diff --git a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml index d546a0e954..d719d76697 100644 --- a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml +++ b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-action-context.xml @@ -121,7 +121,7 @@ - + From 0cdb25ebd75b23118cf78c80e4c5b51e9c6143dd Mon Sep 17 00:00:00 2001 From: rodicasutu Date: Fri, 5 Feb 2021 14:15:41 +0200 Subject: [PATCH 22/23] fix resource bundles for actions from audit log APPS-767 --- .../module/org_alfresco_module_rm/rm-service-context.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-service-context.xml b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-service-context.xml index f87dbc6803..e3c6db1578 100644 --- a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-service-context.xml +++ b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-service-context.xml @@ -679,7 +679,9 @@ - + From 5f1ed626426deec672df5a9597dc23da8150dc2d Mon Sep 17 00:00:00 2001 From: Piero Cittadino <63122825+pieCit87@users.noreply.github.com> Date: Mon, 8 Feb 2021 13:56:29 +0200 Subject: [PATCH 23/23] Resolved comments on PR 1324 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index e1deb665f5..2503f84b4d 100644 --- a/pom.xml +++ b/pom.xml @@ -538,12 +538,12 @@ 0.0 true - 9.4.12 + 9.4.12 5.15.8 61616 5672 3.7.0 - /share + /share 3.1.0 true