From 13ed69561daa2d57f1ec4778b1210df331329528 Mon Sep 17 00:00:00 2001
From: Dave Ward <left@alfresco.com>
Date: Wed, 18 Mar 2009 22:37:00 +0000
Subject: [PATCH] Fix unit tests: unwrap InvocationTargetExceptions thrown by
 subsystems

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@13682 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 .../ManagedSubsystemProxyFactory.java         | 33 ++++++++++++-------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/source/java/org/alfresco/repo/management/ManagedSubsystemProxyFactory.java b/source/java/org/alfresco/repo/management/ManagedSubsystemProxyFactory.java
index 78dee79410..eaac874c43 100644
--- a/source/java/org/alfresco/repo/management/ManagedSubsystemProxyFactory.java
+++ b/source/java/org/alfresco/repo/management/ManagedSubsystemProxyFactory.java
@@ -24,6 +24,7 @@
  */
 package org.alfresco.repo.management;
 
+import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 import java.util.Map;
 
@@ -57,22 +58,30 @@ public class ManagedSubsystemProxyFactory extends ProxyFactoryBean
             public Object invoke(MethodInvocation mi) throws Throwable
             {
                 Method method = mi.getMethod();
-                if (ManagedSubsystemProxyFactory.this.sourceBeanName == null)
+                try
                 {
-                    Map<?, ?> beans = ManagedSubsystemProxyFactory.this.sourceApplicationContextFactory
-                            .getApplicationContext().getBeansOfType(method.getDeclaringClass());
-                    if (beans.size() != 1)
+                    if (ManagedSubsystemProxyFactory.this.sourceBeanName == null)
                     {
-                        throw new RuntimeException("Don't know where to route call to method " + method);
+                        Map<?, ?> beans = ManagedSubsystemProxyFactory.this.sourceApplicationContextFactory
+                                .getApplicationContext().getBeansOfType(method.getDeclaringClass());
+                        if (beans.size() != 1)
+                        {
+                            throw new RuntimeException("Don't know where to route call to method " + method);
+                        }
+                        return method.invoke(beans.values().iterator().next(), mi.getArguments());
                     }
-                    return method.invoke(beans.values().iterator().next(), mi.getArguments());
-                }
-                else
-                {
-                    Object bean = ManagedSubsystemProxyFactory.this.sourceApplicationContextFactory
-                            .getApplicationContext().getBean(ManagedSubsystemProxyFactory.this.sourceBeanName);
-                    return method.invoke(bean, mi.getArguments());
+                    else
+                    {
+                        Object bean = ManagedSubsystemProxyFactory.this.sourceApplicationContextFactory
+                                .getApplicationContext().getBean(ManagedSubsystemProxyFactory.this.sourceBeanName);
+                        return method.invoke(bean, mi.getArguments());
 
+                    }
+                }
+                catch (InvocationTargetException e)
+                {
+                    // Unwrap invocation target exceptions
+                    throw e.getTargetException();
                 }
             }
         }));