From 14e090d6eb966d5d2aeccf9ebb1b4937e33e3486 Mon Sep 17 00:00:00 2001 From: Andrei Rebegea Date: Tue, 6 Nov 2018 16:41:28 +0200 Subject: [PATCH] REPO-3963: SSO: Deprecate OneOff setting in InMemoryTicketComponentImpl (#35) --- .../authentication/InMemoryTicketComponentImpl.java | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/main/java/org/alfresco/repo/security/authentication/InMemoryTicketComponentImpl.java b/src/main/java/org/alfresco/repo/security/authentication/InMemoryTicketComponentImpl.java index 062d7867fb..1c52e6f056 100644 --- a/src/main/java/org/alfresco/repo/security/authentication/InMemoryTicketComponentImpl.java +++ b/src/main/java/org/alfresco/repo/security/authentication/InMemoryTicketComponentImpl.java @@ -37,6 +37,8 @@ import org.alfresco.repo.cache.SimpleCache; import org.alfresco.service.cmr.repository.datatype.Duration; import org.alfresco.util.GUID; import org.apache.commons.codec.binary.Hex; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.safehaus.uuid.UUIDGenerator; /** @@ -51,6 +53,8 @@ public class InMemoryTicketComponentImpl implements TicketComponent */ public static final String GRANTED_AUTHORITY_TICKET_PREFIX = "TICKET_"; + Log logger = LogFactory.getLog(getClass()); + private static ThreadLocal currentTicket = new ThreadLocal(); private boolean ticketsExpire; private Duration validDuration; @@ -96,9 +100,15 @@ public class InMemoryTicketComponentImpl implements TicketComponent /** * Are tickets single use */ + @Deprecated public void setOneOff(boolean oneOff) { this.oneOff = oneOff; + if (this.oneOff) + { + logger.warn("The 'oneOff' feature has been deprecated and will be removed in a future version. " + + "This feature may not work as intended even in the current version"); + } } /** @@ -190,6 +200,7 @@ public class InMemoryTicketComponentImpl implements TicketComponent } if (oneOff) { + //this feature is deprecated ticketsCache.remove(ticketKey); } else if (newTicket != ticket)