inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-07 17:49:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Link rules now automatically re-links

Browse Source 
- Calling link rules on an already linked folder will automatically unlink from the exisiting folder before linking to the new one.
 - Unit tests updated



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@19049 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Roy Wetherall
2010-03-04 00:15:09 +00:00
parent 673add1796
commit 1544887f4e
2 changed files with 99 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
source/java/org/alfresco/repo/rule/RuleLinkTest.java
View File

@@ -24,6 +24,7 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
import org.alfresco.error.AlfrescoRuntimeException;
import org.alfresco.model.ContentModel;
import org.alfresco.repo.action.evaluator.ComparePropertyValueEvaluator;
import org.alfresco.repo.action.executer.AddFeaturesActionExecuter;
@@ -57,7 +58,6 @@ public class RuleLinkTest extends BaseSpringTest
protected static final String CONDITION_DEF_NAME = ComparePropertyValueEvaluator.NAME;
protected static final String COND_PROP_NAME_1 = ComparePropertyValueEvaluator.PARAM_VALUE;
protected static final String COND_PROP_VALUE_1 = ".doc";
private NodeService nodeService;
private RuleService ruleService;
@@ -69,6 +69,7 @@ public class RuleLinkTest extends BaseSpringTest
private NodeRef rootNodeRef;
private NodeRef folderOne;
private NodeRef folderTwo;
private NodeRef folderThree;
@SuppressWarnings("deprecation")
@Override
@@ -100,6 +101,7 @@ public class RuleLinkTest extends BaseSpringTest
folderOne = fileFolderService.create(folder, "folderOne", ContentModel.TYPE_FOLDER).getNodeRef();
folderTwo = fileFolderService.create(folder, "folderTwo", ContentModel.TYPE_FOLDER).getNodeRef();
folderThree = fileFolderService.create(folder, "folderThree", ContentModel.TYPE_FOLDER).getNodeRef();
}
public void testLinkRule()
@@ -175,8 +177,7 @@ public class RuleLinkTest extends BaseSpringTest
assertEquals(folderTwo, linkedFrom.get(0));
// Unlink
Action unlinkAction = actionService.createAction(UnlinkRules.NAME);
actionService.executeAction(unlinkAction, folderTwo);
unlink(folderTwo);
assertTrue(this.ruleService.hasRules(folderOne));
assertEquals(2, ruleService.getRules(folderOne, false).size());
@@ -188,6 +189,71 @@ public class RuleLinkTest extends BaseSpringTest
}
private void link(NodeRef folderFrom, NodeRef folderTo)
{
Action linkAction = actionService.createAction(LinkRules.NAME);
linkAction.setParameterValue(LinkRules.PARAM_LINK_FROM_NODE, folderFrom);
actionService.executeAction(linkAction, folderTo);
}
private void unlink(NodeRef folder)
{
Action unlinkAction = actionService.createAction(UnlinkRules.NAME);
actionService.executeAction(unlinkAction, folder);
}
public void testRelink()
{
// Setup test data
Rule rule = createTestRule(false, "luke");
this.ruleService.saveRule(folderOne, rule);
rule = createTestRule(false, "chewy");
this.ruleService.saveRule(folderTwo, rule);
rule = createTestRule(false, "han");
this.ruleService.saveRule(folderTwo, rule);
List<Rule> rules = ruleService.getRules(folderThree);
assertNotNull(rules);
assertTrue(rules.isEmpty());
link(folderOne, folderThree);
rules = ruleService.getRules(folderThree);
assertNotNull(rules);
assertFalse(rules.isEmpty());
assertEquals(1, rules.size());
link(folderTwo, folderThree);
rules = ruleService.getRules(folderThree);
assertNotNull(rules);
assertFalse(rules.isEmpty());
assertEquals(2, rules.size());
try
{
link(folderTwo, folderOne);
fail("Shouldn't be able to link a folder that already has rules that it owns.");
}
catch (AlfrescoRuntimeException exception)
{
// excepted
}
unlink(folderThree);
rules = ruleService.getRules(folderThree);
assertNotNull(rules);
assertTrue(rules.isEmpty());
link(folderTwo, folderThree);
rules = ruleService.getRules(folderThree);
assertNotNull(rules);
assertFalse(rules.isEmpty());
assertEquals(2, rules.size());
}
protected Rule createTestRule(boolean isAppliedToChildren, String title)
{
// Rule properties