From 182afc58c40f838b04fc1f7a54a83128b1bdad7b Mon Sep 17 00:00:00 2001 From: Tom Page Date: Mon, 25 Jul 2022 15:07:31 +0100 Subject: [PATCH] ACS-3227 Update FilePlanRuleInheritanceTest to include a title for the rule. --- .../rule/FilePlanRuleInheritanceTest.java | 51 ++++++------------- 1 file changed, 16 insertions(+), 35 deletions(-) diff --git a/amps/ags/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/integration/rule/FilePlanRuleInheritanceTest.java b/amps/ags/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/integration/rule/FilePlanRuleInheritanceTest.java index 4a09476861..5a0903be74 100644 --- a/amps/ags/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/integration/rule/FilePlanRuleInheritanceTest.java +++ b/amps/ags/rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/integration/rule/FilePlanRuleInheritanceTest.java @@ -82,13 +82,7 @@ public class FilePlanRuleInheritanceTest extends BaseRMTestCase public void given() { filePlan = createFilePlan(); - - // create a rule that applies to childre - Action completeRecordAction = actionService.createAction(DeclareRecordAction.NAME); - rule = new Rule(); - rule.setRuleType("inbound"); - rule.setAction(completeRecordAction); - rule.applyToChildren(true); + rule = createRuleThatAppliesToChildren(); } public void when() @@ -127,13 +121,7 @@ public class FilePlanRuleInheritanceTest extends BaseRMTestCase public void given() { filePlan = createFilePlan(); - - // create a rule that applies to childre - Action completeRecordAction = actionService.createAction(DeclareRecordAction.NAME); - rule = new Rule(); - rule.setRuleType("inbound"); - rule.setAction(completeRecordAction); - rule.applyToChildren(true); + rule = createRuleThatAppliesToChildren(); } public void when() @@ -171,13 +159,7 @@ public class FilePlanRuleInheritanceTest extends BaseRMTestCase public void given() { filePlan = createFilePlan(); - - // create a rule that applies to childre - Action completeRecordAction = actionService.createAction(DeclareRecordAction.NAME); - rule = new Rule(); - rule.setRuleType("inbound"); - rule.setAction(completeRecordAction); - rule.applyToChildren(true); + rule = createRuleThatAppliesToChildren(); } public void when() @@ -215,13 +197,7 @@ public class FilePlanRuleInheritanceTest extends BaseRMTestCase public void given() { filePlan = createFilePlan(); - - // create a rule that applies to childre - Action completeRecordAction = actionService.createAction(DeclareRecordAction.NAME); - rule = new Rule(); - rule.setRuleType("inbound"); - rule.setAction(completeRecordAction); - rule.applyToChildren(true); + rule = createRuleThatAppliesToChildren(); } public void when() @@ -261,13 +237,7 @@ public class FilePlanRuleInheritanceTest extends BaseRMTestCase { filePlan = createFilePlan(); recordCategory = filePlanService.createRecordCategory(filePlan, GUID.generate()); - - // create a rule that applies to childre - Action completeRecordAction = actionService.createAction(DeclareRecordAction.NAME); - rule = new Rule(); - rule.setRuleType("inbound"); - rule.setAction(completeRecordAction); - rule.applyToChildren(true); + rule = createRuleThatAppliesToChildren(); } public void when() @@ -286,4 +256,15 @@ public class FilePlanRuleInheritanceTest extends BaseRMTestCase } }); } + + private Rule createRuleThatAppliesToChildren() + { + Action completeRecordAction = actionService.createAction(DeclareRecordAction.NAME); + Rule rule = new Rule(); + rule.setRuleType("inbound"); + rule.setTitle("Rule name"); + rule.setAction(completeRecordAction); + rule.applyToChildren(true); + return rule; + } }