[feature/MNT-24127-EndpointToCalculateFolderSize] Addressing review comments related to calculate and retrieve folder size details

This commit is contained in:
mohit-singh4
2024-10-07 16:41:34 +05:30
parent 79e2cb6342
commit 18901c779d
2 changed files with 9 additions and 7 deletions

View File

@@ -144,8 +144,9 @@ public class NodeSizeDetailsTest extends AbstractBaseApiTest
assertNotNull("After executing GET/size-details, it will provide NodeSizeDetails with 200 status code", assertNotNull("After executing GET/size-details, it will provide NodeSizeDetails with 200 status code",
getResponse.getJsonResponse()); getResponse.getJsonResponse());
NodeSizeDetails nodeSizeDetails = NodeSizeDetails.parseNodeSizeDetails((JSONObject) getResponse.getJsonResponse() NodeSizeDetails nodeSizeDetails = NodeSizeDetails.parseNodeSizeDetails(
.get("entry")); (JSONObject) getResponse.getJsonResponse()
.get("entry"));
assertNotNull("We are not getting correct response " + nodeSizeDetails, nodeSizeDetails.getStatus()); assertNotNull("We are not getting correct response " + nodeSizeDetails, nodeSizeDetails.getStatus());
} }
@@ -190,7 +191,7 @@ public class NodeSizeDetailsTest extends AbstractBaseApiTest
postResponse.getJsonResponse()); postResponse.getJsonResponse());
JSONObject jsonObject = (JSONObject) postResponse.getJsonResponse() JSONObject jsonObject = (JSONObject) postResponse.getJsonResponse()
.get("entry"); .get("entry");
String jobId = (String) jsonObject.get("jobId"); String jobId = (String) jsonObject.get("jobId");
assertNotNull("In response, JobId should be present", jobId); assertNotNull("In response, JobId should be present", jobId);
@@ -205,8 +206,9 @@ public class NodeSizeDetailsTest extends AbstractBaseApiTest
assertNotNull("After executing GET/size-details, it will provide NodeSizeDetails with 200 status code", assertNotNull("After executing GET/size-details, it will provide NodeSizeDetails with 200 status code",
getResponse.getJsonResponse()); getResponse.getJsonResponse());
NodeSizeDetails nodeSizeDetails = NodeSizeDetails.parseNodeSizeDetails((JSONObject) getResponse.getJsonResponse() NodeSizeDetails nodeSizeDetails = NodeSizeDetails.parseNodeSizeDetails(
.get("entry")); (JSONObject) getResponse.getJsonResponse()
.get("entry"));
assertNotNull("We are not getting correct response " + nodeSizeDetails, nodeSizeDetails.getStatus()); assertNotNull("We are not getting correct response " + nodeSizeDetails, nodeSizeDetails.getStatus());

View File

@@ -1386,8 +1386,8 @@ scripts.execution.maxMemoryUsedInBytes=-1
# Number of instructions that will trigger the observer # Number of instructions that will trigger the observer
scripts.execution.observerInstructionCount=5000 scripts.execution.observerInstructionCount=5000
#Default value being used in POST/size-details endpoint to partition a huge folder into smaller chunks # Default value being used in POST/size-details endpoint to partition a huge folder into smaller chunks
#so that we can compute more efficiently and consolidate all sizes into a single unit. # so that we can compute more efficiently and consolidate all sizes into a single unit.
default.async.folder.items=1000 default.async.folder.items=1000
# Default NodeSize Thread pool # Default NodeSize Thread pool