From 1a71eafaf5f5e98112bafdc03e2f8293b5329773 Mon Sep 17 00:00:00 2001 From: Neil McErlean Date: Mon, 28 Sep 2015 11:58:55 +0000 Subject: [PATCH] ServiceBaseImpl.instanceOfCache is a collection that only grows and never has elements removed. findbugs flags this as a 'scary' error therefore I'm changing it from a HashMap to a WeakHashMap. git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@113199 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261 --- .../module/org_alfresco_module_rm/util/ServiceBaseImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/util/ServiceBaseImpl.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/util/ServiceBaseImpl.java index 84ae926006..39642a1af1 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/util/ServiceBaseImpl.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/util/ServiceBaseImpl.java @@ -18,9 +18,9 @@ */ package org.alfresco.module.org_alfresco_module_rm.util; -import java.util.HashMap; import java.util.Map; import java.util.Set; +import java.util.WeakHashMap; import org.alfresco.module.org_alfresco_module_rm.fileplan.FilePlanComponentKind; import org.alfresco.module.org_alfresco_module_rm.fileplan.FilePlanService; @@ -443,7 +443,7 @@ public class ServiceBaseImpl implements RecordsManagementModel, ApplicationConte return instanceOf(className, ofClassName); } - private static Map instanceOfCache = new HashMap(); + private static Map instanceOfCache = new WeakHashMap<>(); /** * Utility method to quickly determine whether one class is equal to or sub of another.