inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-14 17:58:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merged FILE-FOLDER-API (5.2.0) to HEAD (5.2)

Browse Source 
121929 jvonka: Nodes (File/Folder) API - test for move operation
   - update existing test
   - switch from PUT /nodes/{nodeId} (with parentId) to POST /nodes/{nodeId} (with targetParentId)
   RA-683, RA-806


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@126442 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Jamal Kaabi-Mofrad
2016-05-10 10:55:46 +00:00
parent 6e89ab1ea3
commit 1bd4af7a70
1 changed files with 33 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
source/test-java/org/alfresco/rest/api/tests/NodeApiTest.java
View File

@@ -52,6 +52,7 @@ import org.alfresco.repo.content.MimetypeMap;
import org.alfresco.repo.security.authentication.AuthenticationUtil; import org.alfresco.repo.security.authentication.AuthenticationUtil;
import org.alfresco.repo.transaction.RetryingTransactionHelper.RetryingTransactionCallback; import org.alfresco.repo.transaction.RetryingTransactionHelper.RetryingTransactionCallback;
import org.alfresco.rest.api.Nodes; import org.alfresco.rest.api.Nodes;
import org.alfresco.rest.api.model.NodeTarget;
import org.alfresco.rest.api.nodes.NodesEntityResource; import org.alfresco.rest.api.nodes.NodesEntityResource;
import org.alfresco.rest.api.tests.RepoService.TestNetwork; import org.alfresco.rest.api.tests.RepoService.TestNetwork;
import org.alfresco.rest.api.tests.RepoService.TestPerson; import org.alfresco.rest.api.tests.RepoService.TestPerson;
@@ -1063,13 +1064,9 @@ public class NodeApiTest extends AbstractBaseApiTest
/** /**
* Tests move (file or folder) * Tests move (file or folder)
* <p>PUT:</p> * <p>POST:</p>
* {@literal <host>:<port>/alfresco/api/-default-/public/alfresco/versions/1/nodes/<nodeId>} * {@literal <host>:<port>/alfresco/api/-default-/public/alfresco/versions/1/nodes/<nodeId>/move}
*/ */
// TODO update these tests for RA-806 (ie. use "POST /nodes/{nodeId}/move" instead of "PUT /nodes/{nodeId}")
/*
@Test @Test
public void testMove() throws Exception public void testMove() throws Exception
{ {
@@ -1097,10 +1094,10 @@ public class NodeApiTest extends AbstractBaseApiTest
// move file (without rename) // move file (without rename)
Document dUpdate = new Document(); NodeTarget moveTgt = new NodeTarget();
dUpdate.setParentId(f2Id); moveTgt.setTargetParentId(f2Id);
HttpResponse response = put("nodes", user1, d1Id, toJsonAsStringNonNull(dUpdate), null, 200); HttpResponse response = post("nodes/"+d1Id+"/move", user1, toJsonAsStringNonNull(moveTgt), null, 201);
Document documentResp = RestApiUtil.parseRestApiEntry(response.getJsonResponse(), Document.class); Document documentResp = RestApiUtil.parseRestApiEntry(response.getJsonResponse(), Document.class);
assertEquals(d1Name, documentResp.getName()); assertEquals(d1Name, documentResp.getName());
@@ -1110,11 +1107,11 @@ public class NodeApiTest extends AbstractBaseApiTest
String d1NewName = d1Name+" updated !!"; String d1NewName = d1Name+" updated !!";
dUpdate = new Document(); moveTgt = new NodeTarget();
dUpdate.setName(d1NewName); moveTgt.setName(d1NewName);
dUpdate.setParentId(f1Id); moveTgt.setTargetParentId(f1Id);
response = put("nodes", user1, d1Id, toJsonAsStringNonNull(dUpdate), null, 200); response = post("nodes/"+d1Id+"/move", user1, toJsonAsStringNonNull(moveTgt), null, 201);
documentResp = RestApiUtil.parseRestApiEntry(response.getJsonResponse(), Document.class); documentResp = RestApiUtil.parseRestApiEntry(response.getJsonResponse(), Document.class);
assertEquals(d1NewName, documentResp.getName()); assertEquals(d1NewName, documentResp.getName());
@@ -1123,25 +1120,25 @@ public class NodeApiTest extends AbstractBaseApiTest
// -ve tests // -ve tests
// name already exists // name already exists
dUpdate = new Document(); moveTgt = new NodeTarget();
dUpdate.setName(d2Name); moveTgt.setName(d2Name);
dUpdate.setParentId(f2Id); moveTgt.setTargetParentId(f2Id);
put("nodes", user1, d1Id, toJsonAsStringNonNull(dUpdate), null, 409); post("nodes/"+d1Id+"/move", user1, toJsonAsStringNonNull(moveTgt), null, 409);
// unknown source nodeId // unknown source nodeId
dUpdate = new Document(); moveTgt = new NodeTarget();
dUpdate.setParentId(f2Id); moveTgt.setTargetParentId(f2Id);
put("nodes", user1, UUID.randomUUID().toString(), toJsonAsStringNonNull(dUpdate), null, 404); post("nodes/"+UUID.randomUUID().toString()+"/move", user1, toJsonAsStringNonNull(moveTgt), null, 404);
// unknown target nodeId // unknown target nodeId
dUpdate = new Document(); moveTgt = new NodeTarget();
dUpdate.setParentId(UUID.randomUUID().toString()); moveTgt.setTargetParentId(UUID.randomUUID().toString());
put("nodes", user1, d1Id, toJsonAsStringNonNull(dUpdate), null, 404); post("nodes/"+d1Id+"/move", user1, toJsonAsStringNonNull(moveTgt), null, 404);
// target is not a folder // target is not a folder
dUpdate = new Document(); moveTgt = new NodeTarget();
dUpdate.setParentId(d2Id); moveTgt.setTargetParentId(d2Id);
put("nodes", user1, d1Id, toJsonAsStringNonNull(dUpdate), null, 400); post("nodes/"+d1Id+"/move", user1, toJsonAsStringNonNull(moveTgt), null, 400);
String rootNodeId = getRootNodeId(user1); String rootNodeId = getRootNodeId(user1);
@@ -1150,29 +1147,29 @@ public class NodeApiTest extends AbstractBaseApiTest
String f3Id = folderResp.getId(); String f3Id = folderResp.getId();
// can't create cycle (move into own subtree) // can't create cycle (move into own subtree)
dUpdate = new Document(); moveTgt = new NodeTarget();
dUpdate.setParentId(f3Id); moveTgt.setTargetParentId(f3Id);
put("nodes", user1, f2Id, toJsonAsStringNonNull(dUpdate), null, 400); post("nodes/"+f2Id+"/move", user1, toJsonAsStringNonNull(moveTgt), null, 400);
// no (write/create) permissions to move to target // no (write/create) permissions to move to target
dUpdate = new Document(); moveTgt = new NodeTarget();
dUpdate.setParentId(rootNodeId); moveTgt.setTargetParentId(rootNodeId);
put("nodes", user1, d1Id, toJsonAsStringNonNull(dUpdate), null, 403); post("nodes/"+d1Id+"/move", user1, toJsonAsStringNonNull(moveTgt), null, 403);
AuthenticationUtil.setFullyAuthenticatedUser(user2); AuthenticationUtil.setFullyAuthenticatedUser(user2);
String my2NodeId = getMyNodeId(user2); String my2NodeId = getMyNodeId(user2);
// no (write/delete) permissions to move source // no (write/delete) permissions to move source
dUpdate = new Document(); moveTgt = new NodeTarget();
dUpdate.setParentId(my2NodeId); moveTgt.setTargetParentId(my2NodeId);
put("nodes", user2, f1Id, toJsonAsStringNonNull(dUpdate), null, 403); post("nodes/"+f1Id+"/move", user2, toJsonAsStringNonNull(moveTgt), null, 403);
} }
/** /**
* Tests copy (file or folder) * Tests copy (file or folder)
* <p>PUT:</p> * <p>POST:</p>
* {@literal <host>:<port>/alfresco/api/-default-/public/alfresco/versions/1/nodes/<nodeId>/copy} * {@literal <host>:<port>/alfresco/api/-default-/public/alfresco/versions/1/nodes/<nodeId>/copy}
*/ */
@Test @Test