inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-14 17:58:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

REPO-1543: Refactor tests for list site filtering

Browse Source 
- site are now created with a default site preset
   - refactored tests

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/DEV/5.2.N/root@132587 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Raluca Munteanu
2016-11-09 09:20:07 +00:00
parent 280bcff174
commit 1eba269df5
3 changed files with 32 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
source/java/org/alfresco/rest/api/impl/SitesImpl.java
View File

@@ -120,6 +120,8 @@ public class SitesImpl implements Sites
private static final String SITE_ID_VALID_CHARS_PARTIAL_REGEX = "A-Za-z0-9\\-"; private static final String SITE_ID_VALID_CHARS_PARTIAL_REGEX = "A-Za-z0-9\\-";
private static final String DEFAULT_SITE_PRESET = "site-dashboard";
private final static Map<String,QName> SORT_PARAMS_TO_QNAMES; private final static Map<String,QName> SORT_PARAMS_TO_QNAMES;
static static
{ {
@@ -1102,7 +1104,7 @@ public class SitesImpl implements Sites
SiteInfo siteInfo = null; SiteInfo siteInfo = null;
try try
{ {
siteInfo = siteService.createSite(site.getPreset() != null ? site.getPreset() : "sitePreset", site.getId(), site.getTitle(), site.getDescription(), site.getVisibility()); siteInfo = siteService.createSite(DEFAULT_SITE_PRESET, site.getId(), site.getTitle(), site.getDescription(), site.getVisibility());
} }
catch (SiteServiceException sse) catch (SiteServiceException sse)
{ {

15
source/test-java/org/alfresco/rest/api/tests/RepoService.java
View File

@@ -516,7 +516,7 @@ public class RepoService
*/ */
public TestSite createSite(TestNetwork network, final SiteInformation siteInfoIn) public TestSite createSite(TestNetwork network, final SiteInformation siteInfoIn)
{ {
SiteInfo siteInfoOut = siteService.createSite(TEST_SITE_PRESET, siteInfoIn.getShortName(), siteInfoIn.getTitle(), siteInfoIn.getDescription(), siteInfoIn.getSiteVisibility()); SiteInfo siteInfoOut = siteService.createSite(siteInfoIn.getSitePreset() != null ? siteInfoIn.getSitePreset() : TEST_SITE_PRESET, siteInfoIn.getShortName(), siteInfoIn.getTitle(), siteInfoIn.getDescription(), siteInfoIn.getSiteVisibility());
siteService.createContainer(siteInfoIn.getShortName(), "documentLibrary", ContentModel.TYPE_FOLDER, null); siteService.createContainer(siteInfoIn.getShortName(), "documentLibrary", ContentModel.TYPE_FOLDER, null);
final TestSite testSite = new TestSite(network, siteInfoOut); final TestSite testSite = new TestSite(network, siteInfoOut);
@@ -1378,6 +1378,13 @@ public class RepoService
return createSite(siteInfo); return createSite(siteInfo);
} }
public TestSite createSite(String id, String title, String description, String sitePreset, SiteVisibility visibility)
{
SiteInformation siteInfo = new SiteInformation(id, title, description, sitePreset, visibility);
// Used deprecated createSite method until will be allowed creating a site with sitePreset
return createSite(siteInfo);
}
public TestSite createSite(SiteVisibility siteVisibility) public TestSite createSite(SiteVisibility siteVisibility)
{ {
return createSite(null, siteVisibility); return createSite(null, siteVisibility);
@@ -1954,6 +1961,12 @@ public class RepoService
this.siteVisibility = siteVisibility; this.siteVisibility = siteVisibility;
} }
public SiteInformation(String shortName, String title, String description, String sitePreset, SiteVisibility siteVisibility)
{
this(shortName, title, description, siteVisibility);
this.sitePreset = sitePreset;
}
public String getShortName() public String getShortName()
{ {
return shortName; return shortName;

33
source/test-java/org/alfresco/rest/api/tests/TestSites.java
View File

@@ -181,25 +181,20 @@ public class TestSites extends EnterpriseTestApi
} }
}, network3.getId()); }, network3.getId());
publicApiClient.setRequestContext(new RequestContext(network3.getId(), person4Id)); TenantUtil.runAsUserTenant(new TenantRunAsWork<Void>()
{
Sites sitesProxy = publicApiClient.sites(); @Override
public Void doWork() throws Exception
Site site = new SiteImpl().withSiteId("a-" + GUID.generate()).withTitle("site A" + GUID.generate()).withDescription(siteDescription) {
.withVisibility(SiteVisibility.PRIVATE.toString()).withPreset(preset); // Temporary solution for testing as for now creating a site
site7 = sitesProxy.createSite(site); // with site preset is not allowed (please see REPO-194)
site7 = network3.createSite("a-" + GUID.generate(), "site A" + GUID.generate(), siteDescription, preset, SiteVisibility.PRIVATE);
site = new SiteImpl().withSiteId("b-" + GUID.generate()).withTitle("site B" + GUID.generate()).withDescription(siteDescription) site8 = network3.createSite("b-" + GUID.generate(), "site B" + GUID.generate(), siteDescription, preset, SiteVisibility.PUBLIC);
.withVisibility(SiteVisibility.PUBLIC.toString()).withPreset(preset); site9 = network3.createSite("c-" + GUID.generate(), "site C" + GUID.generate(), siteDescription, preset, SiteVisibility.PUBLIC);
site8 = sitesProxy.createSite(site); site10 = network3.createSite("d-" + GUID.generate(), "site D" + GUID.generate(), siteDescription, "site-dashboard", SiteVisibility.MODERATED);
return null;
site = new SiteImpl().withSiteId("c-" + GUID.generate()).withTitle("site C" + GUID.generate()).withDescription(siteDescription) }
.withVisibility(SiteVisibility.PUBLIC.toString()).withPreset(preset); }, person4Id, network3.getId());
site9 = sitesProxy.createSite(site);
site = new SiteImpl().withSiteId("d-" + GUID.generate()).withTitle("site D" + GUID.generate()).withDescription(siteDescription)
.withVisibility(SiteVisibility.MODERATED.toString()).withPreset("site-dashboard");
site10 = sitesProxy.createSite(site);
} }
} }