inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-07 17:49:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make the cache objects used by the Action Tracking Service immutable

Browse Source 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@22382 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Nick Burch
2010-09-10 11:13:33 +00:00
parent e931342236
commit 1ee65f081a
4 changed files with 25 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
source/java/org/alfresco/repo/action/ActionTrackingServiceImpl.java
View File

@@ -388,8 +388,12 @@ public class ActionTrackingServiceImpl implements ActionTrackingService
return;
}
// Since it is, update the cancelled flag on it
details.requestCancel();
// Create a new copy of the details, this time with
// the cancel flag set
details = new ExecutionDetails(
details.getExecutionSummary(), details.getPersistedActionRef(),
details.getRunningOn(), details.getStartedAt(), true
);
// Save the flag to the cache
executingActionsCache.put(actionKey, details);

3
source/java/org/alfresco/repo/action/ActionTrackingServiceImplTest.java
View File

@@ -752,13 +752,16 @@ public class ActionTrackingServiceImplTest extends TestCase
// Get the updated key, and check
key3 = ActionTrackingServiceImpl.generateCacheKey(sleepAction3);
ExecutionSummary s3 = ActionTrackingServiceImpl.buildExecutionSummary(key3);
assertEquals(false, actionTrackingService.isCancellationRequested(sleepAction3));
assertEquals(false, actionTrackingService.getExecutionDetails(s3).isCancelRequested());
assertNotNull(executingActionsCache.get(key3));
actionTrackingService.requestActionCancellation(sleepAction3);
assertEquals(true, actionTrackingService.isCancellationRequested(sleepAction3));
assertEquals(true, actionTrackingService.getExecutionDetails(s3).isCancelRequested());
assertNotNull(executingActionsCache.get(key3));
// Have it finish sleeping, will have been cancelled