From 1f30e5b5f143dd948fc14b0992c665af7f3d4798 Mon Sep 17 00:00:00 2001
From: Matt Ward <matt.ward@alfresco.com>
Date: Tue, 22 Nov 2016 10:28:56 +0000
Subject: [PATCH] Merged mward/5.2.n-repo1544-update-self (5.2.1) to 5.2.N
 (5.2.1)    132966 mward: REPO-1544: replaced use of unprotected person
 service with runAsSystem (review: CR-620)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/DEV/5.2.N/root@133000 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 config/alfresco/public-rest-context.xml       |  1 -
 .../alfresco/rest/api/impl/PeopleImpl.java    | 25 ++++++++-----------
 2 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/config/alfresco/public-rest-context.xml b/config/alfresco/public-rest-context.xml
index e0e18fbff7..6b329f99c1 100644
--- a/config/alfresco/public-rest-context.xml
+++ b/config/alfresco/public-rest-context.xml
@@ -626,7 +626,6 @@
         <property name="siteService" ref="SiteService" />
         <property name="nodeService" ref="NodeService" />
         <property name="personService" ref="PersonService" />
-        <property name="unprotectedPersonService" ref="personService" />
         <property name="authenticationService" ref="AuthenticationService" />
         <property name="authorityService" ref="AuthorityService" />
         <property name="contentUsageService" ref="contentUsageImpl" />
diff --git a/source/java/org/alfresco/rest/api/impl/PeopleImpl.java b/source/java/org/alfresco/rest/api/impl/PeopleImpl.java
index 4b95171dda..f2c29dbdd4 100644
--- a/source/java/org/alfresco/rest/api/impl/PeopleImpl.java
+++ b/source/java/org/alfresco/rest/api/impl/PeopleImpl.java
@@ -104,7 +104,6 @@ public class PeopleImpl implements People
 	protected SiteService siteService;
 	protected NodeService nodeService;
     protected PersonService personService;
-    protected PersonService unprotectedPersonService;
     protected AuthenticationService authenticationService;
     protected AuthorityService authorityService;
     protected ContentUsageService contentUsageService;
@@ -146,11 +145,6 @@ public class PeopleImpl implements People
 		this.personService = personService;
 	}
 
-    public void setUnprotectedPersonService(PersonService unprotectedPersonService)
-    {
-        this.unprotectedPersonService = unprotectedPersonService;
-    }
-
     public void setAuthenticationService(AuthenticationService authenticationService)
     {
 		this.authenticationService = authenticationService;
@@ -583,16 +577,17 @@ public class PeopleImpl implements People
 			Map<String, Object> customProps = person.getProperties();
 			properties.putAll(nodes.mapToNodeProperties(customProps));
 		}
-        
-		// The person service only allows admin users to set the properties by default.
-        if (!isAdminAuthority())
+
+        // The person service only allows admin users to set the properties by default.
+        AuthenticationUtil.runAsSystem(new RunAsWork<Void>()
         {
-            unprotectedPersonService.setPersonProperties(personIdToUpdate, properties, false);
-        }
-        else
-        {
-            personService.setPersonProperties(personIdToUpdate, properties, false);
-        }
+            @Override
+            public Void doWork() throws Exception
+            {
+                personService.setPersonProperties(personIdToUpdate, properties, false);
+                return null;
+            }
+        });
 
 		// Update custom aspects
 		nodes.updateCustomAspects(personNodeRef, person.getAspectNames(), EXCLUDED_ASPECTS);