From 20efaab647cf7ee7366f5f552092db5a1c75d37d Mon Sep 17 00:00:00 2001
From: Roy Wetherall <roy.wetherall@alfresco.com>
Date: Tue, 24 Sep 2013 05:42:00 +0000
Subject: [PATCH] RM-911: User is prevented from changing the RM site's
 visibility to anything but public

  * this is only enforced in the repository atm



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@55871 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 .../model/behaviour/RmSiteType.java           | 54 +++++++++++++++----
 1 file changed, 45 insertions(+), 9 deletions(-)

diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/model/behaviour/RmSiteType.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/model/behaviour/RmSiteType.java
index 51a0ea48de..a0b5a1077a 100644
--- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/model/behaviour/RmSiteType.java
+++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/model/behaviour/RmSiteType.java
@@ -18,19 +18,27 @@
  */
 package org.alfresco.module.org_alfresco_module_rm.model.behaviour;
 
+import java.io.Serializable;
+import java.util.Map;
+
+import org.alfresco.error.AlfrescoRuntimeException;
 import org.alfresco.module.org_alfresco_module_rm.model.RecordsManagementModel;
 import org.alfresco.module.org_alfresco_module_rm.search.RecordsManagementSearchService;
 import org.alfresco.repo.node.NodeServicePolicies;
+import org.alfresco.repo.policy.Behaviour.NotificationFrequency;
 import org.alfresco.repo.policy.JavaBehaviour;
 import org.alfresco.repo.policy.PolicyComponent;
-import org.alfresco.repo.policy.Behaviour.NotificationFrequency;
 import org.alfresco.repo.security.authentication.AuthenticationUtil;
+import org.alfresco.repo.site.SiteModel;
 import org.alfresco.service.cmr.repository.ChildAssociationRef;
 import org.alfresco.service.cmr.repository.NodeRef;
 import org.alfresco.service.cmr.repository.NodeService;
 import org.alfresco.service.cmr.repository.StoreRef;
 import org.alfresco.service.cmr.site.SiteInfo;
 import org.alfresco.service.cmr.site.SiteService;
+import org.alfresco.service.cmr.site.SiteVisibility;
+import org.alfresco.service.namespace.QName;
+import org.alfresco.util.PropertyMap;
 
 /**
  * Behaviour associated with the RM Site type
@@ -38,7 +46,8 @@ import org.alfresco.service.cmr.site.SiteService;
  * @author Roy Wetherall
  */
 public class RmSiteType implements RecordsManagementModel,
-                                   NodeServicePolicies.OnCreateNodePolicy
+                                   NodeServicePolicies.OnCreateNodePolicy,
+                                   NodeServicePolicies.OnUpdatePropertiesPolicy
 {
 	/** Constant values */
 	public static final String COMPONENT_DOCUMENT_LIBRARY = "documentLibrary";
@@ -57,7 +66,8 @@ public class RmSiteType implements RecordsManagementModel,
     private RecordsManagementSearchService recordsManagementSearchService;
     
     /** Behaviour */
-    JavaBehaviour behaviour = new JavaBehaviour(this, "onCreateNode", NotificationFrequency.FIRST_EVENT);
+    JavaBehaviour onCreateNode = new JavaBehaviour(this, "onCreateNode", NotificationFrequency.FIRST_EVENT);
+    JavaBehaviour onUpdateProperties = new JavaBehaviour(this, "onUpdateProperties", NotificationFrequency.FIRST_EVENT);
     
     /**
      * Set the policy component
@@ -99,10 +109,13 @@ public class RmSiteType implements RecordsManagementModel,
      */
     public void init()
     {
-        policyComponent.bindClassBehaviour(
-                NodeServicePolicies.OnCreateNodePolicy.QNAME,
-                TYPE_RM_SITE,
-                behaviour);
+        policyComponent.bindClassBehaviour(NodeServicePolicies.OnCreateNodePolicy.QNAME,
+                                           TYPE_RM_SITE,
+                                           onCreateNode);
+        
+        policyComponent.bindClassBehaviour(NodeServicePolicies.OnUpdatePropertiesPolicy.QNAME, 
+                                           TYPE_RM_SITE, 
+                                           onUpdateProperties);
     }
 
     /**
@@ -111,7 +124,7 @@ public class RmSiteType implements RecordsManagementModel,
 	@Override
 	public void onCreateNode(ChildAssociationRef childAssocRef) 
 	{
-	    behaviour.disable();
+	    onCreateNode.disable();
 	    try
 	    {	    
     		final NodeRef rmSite = childAssocRef.getChildRef();
@@ -145,7 +158,30 @@ public class RmSiteType implements RecordsManagementModel,
 	    }
 	    finally
 	    {
-	        behaviour.enable();
+	        onCreateNode.enable();
 	    }
 	}
+
+	/**
+	 * Ensure that the visibility of a RM site can not be changed to anything but public.
+	 * 
+	 * TODO support other site visibilities
+	 * 
+	 * @see org.alfresco.repo.node.NodeServicePolicies.OnUpdatePropertiesPolicy#onUpdateProperties(org.alfresco.service.cmr.repository.NodeRef, java.util.Map, java.util.Map)
+	 */
+    @Override
+    public void onUpdateProperties(NodeRef nodeRef, Map<QName, Serializable> before, Map<QName, Serializable> after)
+    {
+        if (nodeService.exists(nodeRef) == true)
+        {
+            Map<QName, Serializable> changed = PropertyMap.getChangedProperties(before, after);   
+            if (changed.containsKey(SiteModel.PROP_SITE_VISIBILITY) == true &&
+                changed.get(SiteModel.PROP_SITE_VISIBILITY) != null &&
+                SiteVisibility.PUBLIC.equals(changed.get(SiteModel.PROP_SITE_VISIBILITY)) == false)                
+            {
+                // we do not current support non-public RM sites
+                throw new AlfrescoRuntimeException("The records management site must have public visibility.  It can't be changed to " + changed.get(SiteModel.PROP_SITE_VISIBILITY));
+            }
+        }
+    }
 }