Refactoring test code to separate it from BaseUnitTest. RM-2027. +review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@100172 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/classification/ClassificationServiceImpl.java

@@ -59,7 +59,17 @@ public class ClassificationServiceImpl extends ServiceBaseImpl
     /** The classification reasons currently configured in this server. */
     private List<ClassificationReason> configuredReasons;
 
-    private Configuration config = new Configuration(DEFAULT_LEVELS_FILE, DEFAULT_REASONS_FILE);
+    private final Configuration config;
+
+    public ClassificationServiceImpl()
+    {
+        this.config = new Configuration(DEFAULT_LEVELS_FILE, DEFAULT_REASONS_FILE);
+    }
+
+    ClassificationServiceImpl(Configuration config)
+    {
+        this.config = config;
+    }
 
     public void setAttributeService(AttributeService service) { this.attributeService = service; }
 

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/classification/Configuration.java

@@ -50,7 +50,7 @@ class Configuration
     }
 
     /**
-     * Gets the list (in descending order) of classification levels - as defined in the system configuration.
+     * Gets the list (in descending order) of classification levels - as defined in the classpath.
      *
      * @return the configured classification levels in descending order, or an empty list if there are none.
      */

rm-server/unit-test/java/org/alfresco/module/org_alfresco_module_rm/classification/ClassificationServiceImplUnitTest.java

@@ -19,15 +19,26 @@
 package org.alfresco.module.org_alfresco_module_rm.classification;
 
 import org.alfresco.module.org_alfresco_module_rm.classification.ClassificationServiceException.MissingConfiguration;
-import org.alfresco.module.org_alfresco_module_rm.test.util.BaseUnitTest;
+import org.alfresco.module.org_alfresco_module_rm.util.AuthenticationUtil;
 import org.alfresco.service.cmr.attributes.AttributeService;
+import org.junit.Before;
 import org.junit.Test;
-import org.mockito.Mock;
+import org.mockito.invocation.InvocationOnMock;
+import org.mockito.stubbing.Answer;
 
+import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.List;
 
-import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.any;
+import static org.mockito.Mockito.anyString;
+import static org.mockito.Mockito.doAnswer;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.reset;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
 
 /**
  * Unit tests for {@link ClassificationServiceImpl}.
@@ -35,7 +46,7 @@ import static org.junit.Assert.assertEquals;
  * @author Neil Mc Erlean
  * @since 3.0
  */
-public class ClassificationServiceImplUnitTest extends BaseUnitTest
+public class ClassificationServiceImplUnitTest
 {
     private static final List<ClassificationLevel> DEFAULT_CLASSIFICATION_LEVELS = asLevelList("Top Secret",   "rm.classification.topSecret",
                                                                                                "Secret",       "rm.classification.secret",
@@ -70,54 +81,68 @@ public class ClassificationServiceImplUnitTest extends BaseUnitTest
         return levels;
     }
 
-    @Mock(name="attributeService") protected AttributeService mockedAttributeService;
-
     private ClassificationServiceImpl classificationService;
 
-    @Test public void defaultConfigurationVanillaSystem()
+    private AttributeService   mockedAttributeService   = mock(AttributeService.class);
+    private AuthenticationUtil mockedAuthenticationUtil = mock(AuthenticationUtil.class);
+    private Configuration      mockConfig               = mock(Configuration.class);
+
+    @Before public void setUp()
     {
-        classificationService = new TestClassificationService(null, DEFAULT_CLASSIFICATION_LEVELS);
+        reset(mockConfig, mockedAttributeService);
-        classificationService.setAttributeService(mockedAttributeService);
 
-        classificationService.initConfiguredClassificationLevels();
+        // FIXME This should be out of here (and BaseUnitTest) and into a common utility class.
-
+        // We don't care about authentication here.
-        assertEquals(DEFAULT_CLASSIFICATION_LEVELS, classificationService.getClassificationLevels());
+        doAnswer(new Answer<Object>()
+        {
+            @SuppressWarnings("rawtypes")
+            @Override
+            public Object answer(InvocationOnMock invocation) throws Throwable
+            {
+                org.alfresco.repo.security.authentication.AuthenticationUtil.RunAsWork work
+                        = (org.alfresco.repo.security.authentication.AuthenticationUtil.RunAsWork)invocation.getArguments()[0];
+                return work.doWork();
             }
 
-    @Test public void alternativeConfigurationPreviouslyStartedSystem()
+        }).when(mockedAuthenticationUtil).<Object>runAs(any(org.alfresco.repo.security.authentication.AuthenticationUtil.RunAsWork.class), anyString());
-    {
+
-        classificationService = new TestClassificationService(DEFAULT_CLASSIFICATION_LEVELS, ALT_CLASSIFICATION_LEVELS);
+        // Use the admin user
+        doReturn("admin").when(mockedAuthenticationUtil).getAdminUserName();
+        doReturn("admin").when(mockedAuthenticationUtil).getFullyAuthenticatedUser();
+
+        classificationService = new ClassificationServiceImpl(mockConfig);
         classificationService.setAttributeService(mockedAttributeService);
+        classificationService.setAuthenticationUtil(mockedAuthenticationUtil);
+    }
+
+    @Test public void defaultLevelsConfigurationVanillaSystem()
+    {
+        when(mockConfig.getConfiguredLevels()).thenReturn(DEFAULT_CLASSIFICATION_LEVELS);
+        when(mockedAttributeService.getAttribute(anyString(), anyString(), anyString())).thenReturn(null);
 
         classificationService.initConfiguredClassificationLevels();
 
-        assertEquals(ALT_CLASSIFICATION_LEVELS, classificationService.getClassificationLevels());
+        verify(mockedAttributeService).setAttribute(eq((Serializable) DEFAULT_CLASSIFICATION_LEVELS),
+                anyString(), anyString(), anyString());
+    }
+
+    @Test public void alternativeLevelsConfigurationPreviouslyStartedSystem()
+    {
+        when(mockConfig.getConfiguredLevels()).thenReturn(ALT_CLASSIFICATION_LEVELS);
+        when(mockedAttributeService.getAttribute(anyString(), anyString(), anyString()))
+                                   .thenReturn((Serializable) DEFAULT_CLASSIFICATION_LEVELS);
+
+        classificationService.initConfiguredClassificationLevels();
+
+        verify(mockedAttributeService).setAttribute(eq((Serializable) ALT_CLASSIFICATION_LEVELS),
+                anyString(), anyString(), anyString());
     }
 
     @Test (expected=MissingConfiguration.class)
-    public void missingConfigurationVanillaSystemShouldFail() throws Exception
+    public void missingLevelsConfigurationVanillaSystemShouldFail() throws Exception
     {
-        classificationService = new TestClassificationService(null, null);
+        when(mockedAttributeService.getAttribute(anyString(), anyString(), anyString())).thenReturn(null);
-        classificationService.setAttributeService(mockedAttributeService);
 
         classificationService.initConfiguredClassificationLevels();
     }
-
-    /**
-     * Helper class for test purposes that allows us to replace the persisted
-     * and configured lists of {@link ClassificationLevel}s.
-     */
-    private static class TestClassificationService extends ClassificationServiceImpl
-    {
-        private final List<ClassificationLevel> persisted;
-        private final List<ClassificationLevel> configured;
-        public TestClassificationService(List<ClassificationLevel> persisted, List<ClassificationLevel> configured)
-        {
-            this.persisted  = persisted;
-            this.configured = configured;
-        }
-
-        @Override List<ClassificationLevel> getPersistedLevels()  { return persisted; }
-        @Override List<ClassificationLevel> getConfigurationLevels() { return configured; }
-    }
 }