inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

REPO-4859 : HTTP_UNAUTHORIZED instead of HTTP_FORBIDDEN for some CMIS apis (#932)

Browse Source 
- updated code so the Context set includes the USERNAME field.
    - the missing of that field on the context was causing the CMIS lib to trigger a 401
This commit is contained in:
Lucian Tuca
2020-04-22 16:58:49 +03:00
committed by GitHub
parent a800da6e8e
commit 230a30d7e9
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/main/java/org/alfresco/opencmis/AlfrescoCmisServiceImpl.java
View File

@@ -44,8 +44,6 @@ import java.util.concurrent.ConcurrentHashMap;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
import net.sf.acegisecurity.Authentication;
import org.alfresco.model.ContentModel; import org.alfresco.model.ContentModel;
import org.alfresco.opencmis.dictionary.CMISNodeInfo; import org.alfresco.opencmis.dictionary.CMISNodeInfo;
import org.alfresco.opencmis.dictionary.CMISObjectVariant; import org.alfresco.opencmis.dictionary.CMISObjectVariant;
@@ -136,6 +134,7 @@ import org.apache.chemistry.opencmis.commons.impl.server.AbstractCmisService;
import org.apache.chemistry.opencmis.commons.impl.server.ObjectInfoImpl; import org.apache.chemistry.opencmis.commons.impl.server.ObjectInfoImpl;
import org.apache.chemistry.opencmis.commons.impl.server.RenditionInfoImpl; import org.apache.chemistry.opencmis.commons.impl.server.RenditionInfoImpl;
import org.apache.chemistry.opencmis.commons.server.CallContext; import org.apache.chemistry.opencmis.commons.server.CallContext;
import org.apache.chemistry.opencmis.commons.server.MutableCallContext;
import org.apache.chemistry.opencmis.commons.server.ObjectInfo; import org.apache.chemistry.opencmis.commons.server.ObjectInfo;
import org.apache.chemistry.opencmis.commons.server.RenditionInfo; import org.apache.chemistry.opencmis.commons.server.RenditionInfo;
import org.apache.chemistry.opencmis.commons.spi.Holder; import org.apache.chemistry.opencmis.commons.spi.Holder;
@@ -143,6 +142,8 @@ import org.apache.chemistry.opencmis.server.shared.QueryStringHttpServletRequest
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import net.sf.acegisecurity.Authentication;
/** /**
* OpenCMIS service implementation * OpenCMIS service implementation
* *
@@ -176,7 +177,19 @@ public class AlfrescoCmisServiceImpl extends AbstractCmisService implements Alfr
@Override @Override
public void open(CallContext context) public void open(CallContext context)
{ {
AlfrescoCmisServiceCall.set(context); if (context instanceof MutableCallContext)
{
MutableCallContext mutableCallContext = (MutableCallContext) context;
if (mutableCallContext.getUsername() == null && AuthenticationUtil.getFullyAuthenticatedUser() != null)
{
mutableCallContext.put(CallContext.USERNAME, AuthenticationUtil.getFullyAuthenticatedUser());
}
AlfrescoCmisServiceCall.set(mutableCallContext);
}
else
{
AlfrescoCmisServiceCall.set(context);
}
} }
protected CallContext getContext() protected CallContext getContext()