From 29517c366c9f6b945ddb8c8a88a99ae1a8f980e8 Mon Sep 17 00:00:00 2001 From: Sara Aspery Date: Tue, 27 Jun 2017 15:12:22 +0100 Subject: [PATCH] final change after review - replace logger method --- .../record/RecordServiceImpl.java | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/record/RecordServiceImpl.java b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/record/RecordServiceImpl.java index f6c42d8f85..8da0e40161 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/record/RecordServiceImpl.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/record/RecordServiceImpl.java @@ -2008,19 +2008,19 @@ public class RecordServiceImpl extends BaseBehaviourBean private void validateForCompletion(NodeRef nodeRef) { if (!nodeService.exists(nodeRef)) { - logError(nodeRef); + LOGGER.warn(I18NUtil.getMessage(MSG_UNDECLARED_ONLY_RECORDS, nodeRef.toString())); throw new IntegrityException("The record does not exist.", null); } if (!isRecord(nodeRef)) { - logError(nodeRef); + LOGGER.warn(I18NUtil.getMessage(MSG_UNDECLARED_ONLY_RECORDS, nodeRef.toString())); throw new IntegrityException("The node is not a record.", null); } if (freezeService.isFrozen(nodeRef)) { - logError(nodeRef); + LOGGER.warn(I18NUtil.getMessage(MSG_UNDECLARED_ONLY_RECORDS, nodeRef.toString())); throw new IntegrityException("The record is frozen.", null); } @@ -2069,18 +2069,6 @@ public class RecordServiceImpl extends BaseBehaviourBean } } - /** - * Helper method to log a warning to the log file - * - * @param nodeRef node for which error occurred - */ - private void logError(NodeRef nodeRef) { - if (LOGGER.isWarnEnabled()) - { - LOGGER.warn(I18NUtil.getMessage(MSG_UNDECLARED_ONLY_RECORDS, nodeRef.toString())); - } - } - /** * Helper method to build single string containing list of missing properties *