Merged 5.2.N (5.2.1) to HEAD (5.2)

129764 jvonka: REPO-1144: LockService - add isLocked & isLockedAndReadOnly common helper methods to public API
   - remove duplicated code from various locations to use the new methods
   - add sanity checks to Lock*Test


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@130225 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Alan Davis
2016-09-06 14:42:34 +00:00
parent f5f6a6c64f
commit 2e47b0cce2
3 changed files with 54 additions and 58 deletions

View File

@@ -1189,12 +1189,12 @@ public class WebDAVHelper
/** /**
* Indicates if the node is unlocked or the current user has a WRITE_LOCK<p> * Indicates if the node is unlocked or the current user has a WRITE_LOCK<p>
* *
* @see LockUtils#isLockedAndReadOnly(org.alfresco.service.cmr.repository.NodeRef, org.alfresco.service.cmr.lock.LockService) * @see LockService#isLockedAndReadOnly(org.alfresco.service.cmr.repository.NodeRef)
* *
* @param nodeRef the node reference * @param nodeRef the node reference
*/ */
public boolean isLockedAndReadOnly(final NodeRef nodeRef) public boolean isLockedAndReadOnly(final NodeRef nodeRef)
{ {
return LockUtils.isLockedAndReadOnly(nodeRef, m_serviceRegistry.getLockService()); return m_serviceRegistry.getLockService().isLockedAndReadOnly(nodeRef);
} }
} }

View File

@@ -373,7 +373,7 @@ public class WebDAVLockServiceImpl implements WebDAVLockService
*/ */
public boolean isLockedAndReadOnly(NodeRef nodeRef) public boolean isLockedAndReadOnly(NodeRef nodeRef)
{ {
return LockUtils.isLockedAndReadOnly(nodeRef, this.lockService); return this.lockService.isLockedAndReadOnly(nodeRef);
} }
/** /**

View File

@@ -1987,11 +1987,7 @@ public class NodesImpl implements Nodes
if (((aspects != null) && aspects.contains(ContentModel.ASPECT_LOCKABLE)) if (((aspects != null) && aspects.contains(ContentModel.ASPECT_LOCKABLE))
|| nodeService.hasAspect(nodeRef, ContentModel.ASPECT_LOCKABLE)) || nodeService.hasAspect(nodeRef, ContentModel.ASPECT_LOCKABLE))
{ {
LockStatus status = lockService.getLockStatus(nodeRef); locked = lockService.isLocked(nodeRef);
if (status == LockStatus.LOCKED || status == LockStatus.LOCK_OWNER)
{
locked = true;
}
} }
return locked; return locked;