From 3166554a9563309caf9ef5d0654d887471864ae6 Mon Sep 17 00:00:00 2001
From: Derek Hulley <derek.hulley@alfresco.com>
Date: Tue, 2 May 2006 11:05:20 +0000
Subject: [PATCH] Fixed permission bug appearing as Hibernate null issue. Added
 an index on the "NodeRef" portion of the node table.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@2735 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
---
 .../repo/domain/hibernate/Node.hbm.xml        | 38 ++++++++-----------
 .../PermissionsDaoComponentImpl.java          |  7 +++-
 2 files changed, 22 insertions(+), 23 deletions(-)

diff --git a/source/java/org/alfresco/repo/domain/hibernate/Node.hbm.xml b/source/java/org/alfresco/repo/domain/hibernate/Node.hbm.xml
index 10684f573b..3b97a33b9e 100644
--- a/source/java/org/alfresco/repo/domain/hibernate/Node.hbm.xml
+++ b/source/java/org/alfresco/repo/domain/hibernate/Node.hbm.xml
@@ -21,19 +21,22 @@
       <id name="id" column="id" type="long" >
          <generator class="native" />
       </id>
-      <!-- forward assoc to store -->
-      <many-to-one
-            name="store"
-            class="org.alfresco.repo.domain.hibernate.StoreImpl"
-            not-null="true"
-            lazy="no-proxy"
-            optimistic-lock="true"
-            fetch="select">
-         <column name="protocol" not-null="true" />
-         <column name="identifier" not-null="true" />
-      </many-to-one>
-      <!-- the store-unique identifier -->
-      <property name="uuid" column="uuid" type="string" length="36" />
+      <!-- the natural ID of the node -->
+      <natural-id mutable="true">
+         <!-- forward assoc to store -->
+         <many-to-one
+               name="store"
+               class="org.alfresco.repo.domain.hibernate.StoreImpl"
+               not-null="true"
+               lazy="no-proxy"
+               optimistic-lock="true"
+               fetch="select">
+            <column name="protocol" not-null="true" />
+            <column name="identifier" not-null="true" />
+         </many-to-one>
+         <!-- the store-unique identifier -->
+         <property name="uuid" column="uuid" type="string" length="36" />
+      </natural-id>
       <property name="typeQName" column="type_qname" type="QName" length="255" not-null="true" />
       <!-- inverse assoc to access control list -->
       <one-to-one 
@@ -43,15 +46,6 @@
             lazy="no-proxy"
             fetch="select"
             cascade="delete" /> 
-      <!-- inverse assoc to node status -->
-<!--
-      <one-to-one
-            name="status"
-            class="org.alfresco.repo.domain.hibernate.NodeStatusImpl"
-            property-ref="node"
-            lazy="no-proxy"
-            fetch="select" />
--->
       <!-- forward assoc to properties -->
       <map
             name="properties" 
diff --git a/source/java/org/alfresco/repo/domain/hibernate/PermissionsDaoComponentImpl.java b/source/java/org/alfresco/repo/domain/hibernate/PermissionsDaoComponentImpl.java
index 6ead381b52..8dc7a42357 100644
--- a/source/java/org/alfresco/repo/domain/hibernate/PermissionsDaoComponentImpl.java
+++ b/source/java/org/alfresco/repo/domain/hibernate/PermissionsDaoComponentImpl.java
@@ -141,7 +141,12 @@ public class PermissionsDaoComponentImpl extends HibernateDaoSupport implements
         DbAccessControlList acl = null;
         if (results.size() == 0)
         {
-            // we'll return null
+            // create it
+            if (create)
+            {
+                acl = createAccessControlList(nodeRef);
+            }
+            // else null will be returned
         }
         else if (results.size() > 0)
         {