Merged RETURN-OF-THE-API (5.2.0) to 5.2.N (5.2.1)

128525 jvonka: REPO-874: Improve REST fwk: improve error message if a POST operation is attempted with multiple items
   - follow-on to fix fallout


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/DEV/5.2.N/root@129169 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Martin Muller
2016-08-05 13:46:55 +00:00
parent ed52b3a6c5
commit 3881d6e8d7

View File

@@ -150,6 +150,7 @@ public class ResourceWebScriptPost extends AbstractResourceWebScript implements
} }
Class<?> objType = resourceMeta.getObjectType(operation); Class<?> objType = resourceMeta.getObjectType(operation);
boolean isTypeOperation = resourceMeta.getType().equals(ResourceMetadata.RESOURCE_TYPE.OPERATION);
List<ResourceParameter> params = operation.getParameters(); List<ResourceParameter> params = operation.getParameters();
if (!params.isEmpty()) if (!params.isEmpty())
@@ -157,7 +158,6 @@ public class ResourceWebScriptPost extends AbstractResourceWebScript implements
for (ResourceParameter resourceParameter : params) for (ResourceParameter resourceParameter : params)
{ {
// POST to collection may or may not support List as json body, Operations don't support a List as json body // POST to collection may or may not support List as json body, Operations don't support a List as json body
boolean isTypeOperation = resourceMeta.getType().equals(ResourceMetadata.RESOURCE_TYPE.OPERATION);
boolean notMultiple = ((! resourceParameter.isAllowMultiple()) || isTypeOperation); boolean notMultiple = ((! resourceParameter.isAllowMultiple()) || isTypeOperation);
if (ResourceParameter.KIND.HTTP_BODY_OBJECT.equals(resourceParameter.getParamType()) && notMultiple) if (ResourceParameter.KIND.HTTP_BODY_OBJECT.equals(resourceParameter.getParamType()) && notMultiple)
@@ -168,7 +168,7 @@ public class ResourceWebScriptPost extends AbstractResourceWebScript implements
Object jsonContent = null; Object jsonContent = null;
if (objType != null) if (objType != null)
{ {
jsonContent = ResourceWebScriptHelper.extractJsonContent(req,assistant.getJsonHelper(), objType); jsonContent = ResourceWebScriptHelper.extractJsonContent(req, assistant.getJsonHelper(), objType);
} }
if (isTypeOperation) if (isTypeOperation)
@@ -194,8 +194,22 @@ public class ResourceWebScriptPost extends AbstractResourceWebScript implements
} }
} }
} }
if (objType == null)
{
return null;
}
if (isTypeOperation)
{
// Operations don't support a List as json body
return ResourceWebScriptHelper.extractJsonContent(req, assistant.getJsonHelper(), objType);
}
else
{
return ResourceWebScriptHelper.extractJsonContentAsList(req, assistant.getJsonHelper(), objType); return ResourceWebScriptHelper.extractJsonContentAsList(req, assistant.getJsonHelper(), objType);
} }
}
/** /**