RM Performance Improvements

* general file plan browse rendering in around half the previously recorded times for around 500 records (need to scale up)
 * unessesary bottle neck removed from record detail page rendering (see RM-1461)
 * other general improvements
 * TODO .. hasFrozenChildren, getNextDisposition, TransferNodeIndicator, HeldBy .. all traverse up or down record/record folder hierarchy in ways that don't scale
 * fix to disposition lifecycle job that failed all when one failed .. this explains why the job appeared not to work on occasion



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@74458 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

rm-server/unit-test/java/org/alfresco/module/org_alfresco_module_rm/hold/HoldServiceImplUnitTest.java

@@ -275,7 +275,8 @@ public class HoldServiceImplUnitTest extends BaseUnitTest
     @Test (expected=AlfrescoRuntimeException.class)
     public void addToHoldNotARecordFolderOrRecord()
     {
-        holdService.addToHold(hold, filePlanComponent);
+        NodeRef anotherThing = generateNodeRef(TYPE_RECORD_CATEGORY);
+        holdService.addToHold(hold, anotherThing);
     }
 
     @SuppressWarnings("unchecked")

rm-server/unit-test/java/org/alfresco/module/org_alfresco_module_rm/test/util/BaseUnitTest.java

@@ -121,7 +121,7 @@ public class BaseUnitTest implements RecordsManagementModel
         MockitoAnnotations.initMocks(this);
         
         // setup application context
-        doReturn(mockedNodeService).when(mockedApplicationContext).getBean("nodeService");
+        doReturn(mockedNodeService).when(mockedApplicationContext).getBean("dbNodeService");
         
         // setup retrying transaction helper
         Answer<Object> doInTransactionAnswer = new Answer<Object>()