inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-07 17:49:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed critical issues reported by sonar (Dodgy - Dead store to local variable)

Browse Source 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63493 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Tuna Aksoy
2014-03-02 16:28:31 +00:00
parent 6b7cb38685
commit 43a2f10ef6
2 changed files with 83 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/action/RecordsManagementActionServiceImpl.java
View File

@@ -32,7 +32,6 @@ import org.alfresco.module.org_alfresco_module_rm.RecordsManagementPolicies.OnRM
import org.alfresco.module.org_alfresco_module_rm.util.PoliciesUtil; import org.alfresco.module.org_alfresco_module_rm.util.PoliciesUtil;
import org.alfresco.repo.policy.ClassPolicyDelegate; import org.alfresco.repo.policy.ClassPolicyDelegate;
import org.alfresco.repo.policy.PolicyComponent; import org.alfresco.repo.policy.PolicyComponent;
import org.alfresco.repo.security.authentication.AuthenticationUtil;
import org.alfresco.service.cmr.repository.NodeRef; import org.alfresco.service.cmr.repository.NodeRef;
import org.alfresco.service.cmr.repository.NodeService; import org.alfresco.service.cmr.repository.NodeService;
import org.alfresco.service.namespace.QName; import org.alfresco.service.namespace.QName;
@@ -183,7 +182,7 @@ public class RecordsManagementActionServiceImpl implements RecordsManagementActi
@SuppressWarnings("unused") @SuppressWarnings("unused")
public List<RecordsManagementAction> getDispositionActions(NodeRef nodeRef) public List<RecordsManagementAction> getDispositionActions(NodeRef nodeRef)
{ {
String userName = AuthenticationUtil.getFullyAuthenticatedUser(); //String userName = AuthenticationUtil.getFullyAuthenticatedUser();
List<RecordsManagementAction> result = new ArrayList<RecordsManagementAction>(this.rmActions.size()); List<RecordsManagementAction> result = new ArrayList<RecordsManagementAction>(this.rmActions.size());
for (RecordsManagementAction action : this.rmActions.values()) for (RecordsManagementAction action : this.rmActions.values())

20
rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/capability/RMAfterInvocationProvider.java
View File

@@ -453,17 +453,17 @@ public class RMAfterInvocationProvider extends RMSecurityCommon
maxSize = new Integer(maxSize + returnedObject.getResultSetMetaData().getSearchParameters().getSkipCount()); maxSize = new Integer(maxSize + returnedObject.getResultSetMetaData().getSearchParameters().getSkipCount());
} }
int maxChecks = maxPermissionChecks; // int maxChecks = maxPermissionChecks;
if (returnedObject.getResultSetMetaData().getSearchParameters().getMaxPermissionChecks() >= 0) // if (returnedObject.getResultSetMetaData().getSearchParameters().getMaxPermissionChecks() >= 0)
{ // {
maxChecks = returnedObject.getResultSetMetaData().getSearchParameters().getMaxPermissionChecks(); // maxChecks = returnedObject.getResultSetMetaData().getSearchParameters().getMaxPermissionChecks();
} // }
long maxCheckTime = maxPermissionCheckTimeMillis; // long maxCheckTime = maxPermissionCheckTimeMillis;
if (returnedObject.getResultSetMetaData().getSearchParameters().getMaxPermissionCheckTimeMillis() >= 0) // if (returnedObject.getResultSetMetaData().getSearchParameters().getMaxPermissionCheckTimeMillis() >= 0)
{ // {
maxCheckTime = returnedObject.getResultSetMetaData().getSearchParameters().getMaxPermissionCheckTimeMillis(); // maxCheckTime = returnedObject.getResultSetMetaData().getSearchParameters().getMaxPermissionCheckTimeMillis();
} // }
if (supportedDefinitions.size() == 0) if (supportedDefinitions.size() == 0)
{ {