From 477e9d61a10a30b99bc1282a0d1dffff0aeee197 Mon Sep 17 00:00:00 2001 From: Dave Ward Date: Wed, 10 Mar 2010 18:46:02 +0000 Subject: [PATCH] ALF-1999: Refactored AuthorityService.findAuthorities to support search options required by Alfresco Explorer client in efficient manner - optional parentAuthority argument - when set will only search for authorities under a given group - optional immediate flag - when false means do a recursive search. When true means only return first level. When true and parentAuthority is null means root groups. - search expression - which is tested against the short name and the display name - reworked all existing calls for new semantics - this method is for UI search only - not for existence checking! - removed some ill-informed calls git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@19203 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261 --- .../alfresco/web/bean/users/MailInviteSpaceUsersWizard.java | 6 +++--- .../org/alfresco/web/bean/wcm/SetPermissionsDialog.java | 4 ++-- .../org/alfresco/web/bean/wizard/BaseInviteUsersWizard.java | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/source/java/org/alfresco/web/bean/users/MailInviteSpaceUsersWizard.java b/source/java/org/alfresco/web/bean/users/MailInviteSpaceUsersWizard.java index 8eff125a17..581ea054d7 100644 --- a/source/java/org/alfresco/web/bean/users/MailInviteSpaceUsersWizard.java +++ b/source/java/org/alfresco/web/bean/users/MailInviteSpaceUsersWizard.java @@ -22,7 +22,6 @@ import java.util.Set; import org.alfresco.service.cmr.security.AuthorityService; import org.alfresco.service.cmr.security.AuthorityType; -import org.alfresco.service.cmr.security.PermissionService; import org.alfresco.web.bean.spaces.InviteSpaceUsersWizard; /** @@ -35,9 +34,10 @@ public class MailInviteSpaceUsersWizard extends InviteSpaceUsersWizard protected Set getGroups(String search) { // groups - text search match on supplied name - String term = PermissionService.GROUP_PREFIX + "*" + search + "*"; + String term = "*" + search + "*"; Set groups; - groups = getAuthorityService().findAuthoritiesInZone(AuthorityType.GROUP, term, AuthorityService.ZONE_APP_DEFAULT); + groups = getAuthorityService().findAuthorities(AuthorityType.GROUP, null, false, term, + AuthorityService.ZONE_APP_DEFAULT); return groups; } } \ No newline at end of file diff --git a/source/java/org/alfresco/web/bean/wcm/SetPermissionsDialog.java b/source/java/org/alfresco/web/bean/wcm/SetPermissionsDialog.java index 5f7b3c2a4a..4fde3a2ff0 100644 --- a/source/java/org/alfresco/web/bean/wcm/SetPermissionsDialog.java +++ b/source/java/org/alfresco/web/bean/wcm/SetPermissionsDialog.java @@ -286,9 +286,9 @@ public class SetPermissionsDialog extends UpdatePermissionsDialog else { // groups - text search match on supplied name - String term = PermissionService.GROUP_PREFIX + "*" + contains.trim() + "*"; + String term = "*" + contains.trim() + "*"; Set groups; - groups = getAuthorityService().findAuthoritiesInZone(AuthorityType.GROUP, term, AuthorityService.ZONE_APP_DEFAULT); + groups = getAuthorityService().findAuthorities(AuthorityType.GROUP, null, false, term, AuthorityService.ZONE_APP_DEFAULT); groups.addAll(getAuthorityService().getAllAuthorities(AuthorityType.EVERYONE)); String groupDisplayName; diff --git a/source/java/org/alfresco/web/bean/wizard/BaseInviteUsersWizard.java b/source/java/org/alfresco/web/bean/wizard/BaseInviteUsersWizard.java index 7f41a6c02f..95bf87da1d 100644 --- a/source/java/org/alfresco/web/bean/wizard/BaseInviteUsersWizard.java +++ b/source/java/org/alfresco/web/bean/wizard/BaseInviteUsersWizard.java @@ -63,7 +63,6 @@ import org.alfresco.web.ui.common.Utils; import org.alfresco.web.ui.common.component.UIGenericPicker; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; -import org.apache.lucene.queryParser.QueryParser; import org.apache.lucene.search.BooleanQuery; import org.springframework.mail.javamail.JavaMailSender; @@ -563,9 +562,10 @@ public abstract class BaseInviteUsersWizard extends BaseWizardBean protected Set getGroups(String search) { // groups - text search match on supplied name - String term = PermissionService.GROUP_PREFIX + "*" + search + "*"; + String term = "*" + search + "*"; Set groups; - groups = getAuthorityService().findAuthoritiesInZone(AuthorityType.GROUP, term, AuthorityService.ZONE_APP_DEFAULT); + groups = getAuthorityService().findAuthorities(AuthorityType.GROUP, null, false, term, + AuthorityService.ZONE_APP_DEFAULT); groups.addAll(getAuthorityService().getAllAuthorities(AuthorityType.EVERYONE)); return groups; }