PersonService and AuthenticationDao changes

- Clean up javadocs (remove uncommented parameters and fix method comments)
 - ALF-8996: Administrator users can disable themselves
   - Administrator users cannot be disabled (the repo ignores the request)
   - Administrator users cannot expire, be locked; they remain active no matter what
   - UI attempts to disable admin but the request just does nothing (UI could gray it out, I suppose)
 - (ALF-8805) ALF-9056: RINF 40: Fix XPath query to use selectNodes
   - Final (Team-introduced) Lucene query in PersonServiceImpl
   - Cleanup and better tests
   - Unit test template retrieval for user notification (not easy via UI)


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@28528 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/repo/security/authentication/MutableAuthenticationDao.java

@@ -33,157 +33,107 @@ public interface MutableAuthenticationDao extends AuthenticationDao, SaltSource
 {
     /**
      * Create a user with the given userName and password
-     * 
-     * @param userName
-     * @param rawPassword
-     * @throws AuthenticationException
      */
     public void createUser(String userName, char[] rawPassword) throws AuthenticationException;
     
     /**
      * Update a user's password.
-     * 
-     * @param userName
-     * @param rawPassword
-     * @throws AuthenticationException
      */
     public void updateUser(String userName, char[] rawPassword) throws AuthenticationException;
     
     /**
      * Delete a user.
-     * 
-     * @param userName
-     * @throws AuthenticationException
      */
     public void deleteUser(String userName) throws AuthenticationException;
     
     /**
-     * CHeck is a user exists.
-     * 
-     * @param userName
-     * @return
+     * Check is a user exists.
      */
     public boolean userExists(String userName);
     
     /**
      * Enable/disable a user.
-     * 
-     * @param userName
-     * @param enabled
      */
     public void setEnabled(String userName, boolean enabled);
     
     /**
      * Getter for user enabled
-     * 
-     * @param userName
-     * @return
      */
     public boolean getEnabled(String userName);
     
     /**
      * Set if the account should expire
-     * 
-     * @param userName
-     * @param expires
      */
     public void setAccountExpires(String userName, boolean expires);
     
     /**
      * Does the account expire?
-     * 
-     * @param userName
-     * @return
      */
-            
     public boolean getAccountExpires(String userName);
     
     /**
      * Has the account expired?
-     * 
-     * @param userName
-     * @return
      */
     public boolean getAccountHasExpired(String userName);
   
     /**
      * Set if the password expires.
-     * 
-     * @param userName
-     * @param expires
      */
     public void setCredentialsExpire(String userName, boolean expires);
   
     /**
      * Do the credentials for the user expire?
-     * 
-     * @param userName
-     * @return
      */
     public boolean getCredentialsExpire(String userName);
     
     /**
      * Have the credentials for the user expired?
-     * 
-     * @param userName
-     * @return
      */
     public boolean getCredentialsHaveExpired(String userName);
     
     /**
      * Set if the account is locked.
-     * 
-     * @param userName
-     * @param locked
      */
     public void setLocked(String userName, boolean locked);
     
+    /**
+     * Check if the account is locked
+     * 
+     * @param userName          the username
+     * 
+     * @since 4.0
+     */
+    public boolean getLocked(String userName);
+    
     /**
      * Is the account locked?
      * 
-     * @param userName
-     * @return
+     * @deprecated Use {@link #getLocked(String)}
      */
     public boolean getAccountlocked(String userName);
     
     /**
      * Set the date on which the account expires
-     * 
-     * @param userName
-     * @param exipryDate
      */
     public void setAccountExpiryDate(String userName, Date exipryDate);
     
     /** 
      * Get the date when this account expires.
-     * 
-     * @param userName
-     * @return
      */
     public Date getAccountExpiryDate(String userName);
     
     /**
      * Set the date when credentials expire.
-     * 
-     * @param userName
-     * @param exipryDate
      */
     public void setCredentialsExpiryDate(String userName, Date exipryDate);
     
     /**
      * Get the date when the credentials/password expire.
-     * 
-     * @param userName
-     * @return
      */
     public Date getCredentialsExpiryDate(String userName);
     
     /**
      * Get the MD4 password hash
-     * 
-     * @param userName
-     * @return
      */
     public String getMD4HashedPassword(String userName);
-    
 }