Fixed major issues reported by sonar (Simplify Boolean Expression)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64169 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Tuna Aksoy
2014-03-13 22:52:16 +00:00
parent 1f3a6566ac
commit 4ccd8861cf
120 changed files with 330 additions and 330 deletions

View File

@@ -110,7 +110,7 @@ public class RmClassesGet extends DictionaryWebServiceBase implements RecordsMan
}
//validate classfilter
if (isValidClassFilter(classFilter) == false)
if (!isValidClassFilter(classFilter))
{
throw new WebScriptException(Status.STATUS_NOT_FOUND, "Check the classfilter - " + classFilter + " provided in the URL");
}
@@ -128,7 +128,7 @@ public class RmClassesGet extends DictionaryWebServiceBase implements RecordsMan
if (name != null)
{
className = namespacePrefix + "_" + name;
if (isValidClassname(className) == false)
if (!isValidClassname(className))
{
throw new WebScriptException(Status.STATUS_NOT_FOUND, "Check the name - " + name + "parameter in the URL");
}

View File

@@ -237,9 +237,9 @@ public class RmSubstitutionSuggestionsGet extends DeclarativeWebScript
String storeId = templateVars.get("store_id");
String id = templateVars.get("id");
if (StringUtils.isEmpty(storeType) == false &&
StringUtils.isEmpty(storeId) == false &&
StringUtils.isEmpty(id) == false)
if (!StringUtils.isEmpty(storeType) &&
!StringUtils.isEmpty(storeId) &&
!StringUtils.isEmpty(id))
{
StoreRef storeRef = new StoreRef(storeType, storeId);
NodeRef nodeRef = new NodeRef(storeRef, id);