Fix a TODO - Remove a static for a test that can be done without one

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@31311 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Nick Burch
2011-10-18 11:33:19 +00:00
parent 290ba3c203
commit 4cde60f0e6
2 changed files with 5 additions and 13 deletions

View File

@@ -76,8 +76,7 @@ public class ScheduledPersistedActionServiceImpl implements ScheduledPersistedAc
protected static final String JOB_SCHEDULE_NODEREF = "ScheduleNodeRef";
protected static final String JOB_ACTION_NODEREF = "ActionNodeRef";
// TODO: Should be private NodeRef scheduledActionRootNodeRef;
protected static NodeRef SCHEDULED_ACTION_ROOT_NODE_REF;
protected NodeRef SCHEDULED_ACTION_ROOT_NODE_REF;
protected static final Set<QName> ACTION_TYPES = new HashSet<QName>(Arrays
.asList(new QName[] { ActionModel.TYPE_ACTION_SCHEDULE }));

View File

@@ -117,17 +117,13 @@ public class ScheduledPersistedActionServiceTest extends TestCase
testAction = new TestAction(actionService
.createAction(SleepActionExecuter.NAME));
runtimeActionService.createActionNodeRef(
//
testAction,
ScheduledPersistedActionServiceImpl.SCHEDULED_ACTION_ROOT_NODE_REF,
testAction, serviceImpl.SCHEDULED_ACTION_ROOT_NODE_REF,
ContentModel.ASSOC_CONTAINS, QName.createQName("TestAction"));
testAction2 = new TestAction(actionService
.createAction(SleepActionExecuter.NAME));
runtimeActionService.createActionNodeRef(
//
testAction2,
ScheduledPersistedActionServiceImpl.SCHEDULED_ACTION_ROOT_NODE_REF,
testAction2, serviceImpl.SCHEDULED_ACTION_ROOT_NODE_REF,
ContentModel.ASSOC_CONTAINS, QName.createQName("TestAction2"));
testAction3 = new TestAction(actionService
@@ -182,8 +178,7 @@ public class ScheduledPersistedActionServiceTest extends TestCase
// Persist the 3rd action
runtimeActionService.createActionNodeRef(
//
testAction3,
ScheduledPersistedActionServiceImpl.SCHEDULED_ACTION_ROOT_NODE_REF,
testAction3, serviceImpl.SCHEDULED_ACTION_ROOT_NODE_REF,
ContentModel.ASSOC_CONTAINS, QName.createQName("TestAction3"));
assertEquals(null, schedule.getPersistedAtNodeRef());
@@ -673,9 +668,7 @@ public class ScheduledPersistedActionServiceTest extends TestCase
.getPersistedAtNodeRef());
runtimeActionService.createActionNodeRef(
//
testAction3,
ScheduledPersistedActionServiceImpl.SCHEDULED_ACTION_ROOT_NODE_REF,
testAction3, serviceImpl.SCHEDULED_ACTION_ROOT_NODE_REF,
ContentModel.ASSOC_CONTAINS, QName.createQName("TestAction3"));
assertNotNull(schedule.getActionNodeRef());