inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

RM-4293: prevent filePlan and unfiled Record container from behaviour

Browse Source 
beans, also removed deleteNode method from RMNodesImpl and some unit
tests
This commit is contained in:
Silviu Dinuta
2016-11-15 19:00:48 +02:00
parent 411c14a93b
commit 51f99f1846
6 changed files with 116 additions and 144 deletions
Download Patch File Download Diff File Expand all files Collapse all files

120
rm-community/rm-community-repo/unit-test/java/org/alfresco/rm/rest/api/impl/RMNodesImplUnitTest.java
View File

@@ -35,9 +35,6 @@ import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import java.security.InvalidParameterException;
@@ -52,8 +49,6 @@ import org.alfresco.module.org_alfresco_module_rm.test.util.BaseUnitTest;
import org.alfresco.repo.model.Repository;
import org.alfresco.rest.api.model.Node;
import org.alfresco.rest.framework.core.exceptions.EntityNotFoundException;
import org.alfresco.rest.framework.core.exceptions.PermissionDeniedException;
import org.alfresco.rest.framework.resource.parameters.Parameters;
import org.alfresco.rm.rest.api.RMNodes;
import org.alfresco.rm.rest.api.model.FileplanComponentNode;
import org.alfresco.rm.rest.api.model.RecordCategoryNode;
@@ -609,121 +604,6 @@ public class RMNodesImplUnitTest extends BaseUnitTest
assertEquals(nodeRef, validateOrLookupNode);
}
@Test
public void testDeleteNode() throws Exception
{
NodeRef nodeRef = AlfMock.generateNodeRef(mockedNodeService);
Parameters mockedParameters = mock(Parameters.class);
QName mockedType = AlfMock.generateQName();
when(mockedNodeService.getType(nodeRef)).thenReturn(mockedType);
setupCompanyHomeAndPrimaryParent(nodeRef);
rmNodesImpl.deleteNode(nodeRef.getId(), mockedParameters);
verify(mockedFileFolderService, times(1)).delete(nodeRef);
}
@Test
public void testDeleteFileplanNode() throws Exception
{
NodeRef nodeRef = AlfMock.generateNodeRef(mockedNodeService);
Parameters mockedParameters = mock(Parameters.class);
QName mockedType = AlfMock.generateQName();
when(mockedNodeService.getType(nodeRef)).thenReturn(mockedType);
when(mockedFilePlanService.getFilePlanBySiteId(RM_SITE_ID)).thenReturn(nodeRef);
try
{
rmNodesImpl.deleteNode(nodeRef.getId(), mockedParameters);
fail("Expected ecxeption as filePlan can't be deleted.");
}
catch(PermissionDeniedException ex)
{
assertEquals("Cannot delete: " + nodeRef.getId(), ex.getMsgId());
}
verify(mockedFileFolderService, never()).delete(nodeRef);
}
@Test
public void testDeleteTransfersContainerNode() throws Exception
{
NodeRef nodeRef = AlfMock.generateNodeRef(mockedNodeService);
Parameters mockedParameters = mock(Parameters.class);
QName mockedType = AlfMock.generateQName();
when(mockedNodeService.getType(nodeRef)).thenReturn(mockedType);
NodeRef filePlanNodeRef = AlfMock.generateNodeRef(mockedNodeService);
when(mockedFilePlanService.getFilePlanBySiteId(RM_SITE_ID)).thenReturn(filePlanNodeRef);
when(mockedFilePlanService.getTransferContainer(filePlanNodeRef)).thenReturn(nodeRef);
try
{
rmNodesImpl.deleteNode(nodeRef.getId(), mockedParameters);
fail("Expected ecxeption as Trnsfers container can't be deleted.");
}
catch(PermissionDeniedException ex)
{
assertEquals("Cannot delete: " + nodeRef.getId(), ex.getMsgId());
}
verify(mockedFileFolderService, never()).delete(nodeRef);
}
@Test
public void testDeleteHoldsContainerNode() throws Exception
{
NodeRef nodeRef = AlfMock.generateNodeRef(mockedNodeService);
Parameters mockedParameters = mock(Parameters.class);
QName mockedType = AlfMock.generateQName();
when(mockedNodeService.getType(nodeRef)).thenReturn(mockedType);
NodeRef filePlanNodeRef = AlfMock.generateNodeRef(mockedNodeService);
when(mockedFilePlanService.getFilePlanBySiteId(RM_SITE_ID)).thenReturn(filePlanNodeRef);
NodeRef transferContainerNodeRef = AlfMock.generateNodeRef(mockedNodeService);
when(mockedFilePlanService.getTransferContainer(filePlanNodeRef)).thenReturn(transferContainerNodeRef);
when(mockedFilePlanService.getHoldContainer(filePlanNodeRef)).thenReturn(nodeRef);
try
{
rmNodesImpl.deleteNode(nodeRef.getId(), mockedParameters);
fail("Expected ecxeption as Holds container can't be deleted.");
}
catch(PermissionDeniedException ex)
{
assertEquals("Cannot delete: " + nodeRef.getId(), ex.getMsgId());
}
verify(mockedFileFolderService, never()).delete(nodeRef);
}
@Test
public void testDeleteUnfiledRecordsContainerNode() throws Exception
{
NodeRef nodeRef = AlfMock.generateNodeRef(mockedNodeService);
Parameters mockedParameters = mock(Parameters.class);
QName mockedType = AlfMock.generateQName();
when(mockedNodeService.getType(nodeRef)).thenReturn(mockedType);
NodeRef filePlanNodeRef = AlfMock.generateNodeRef(mockedNodeService);
when(mockedFilePlanService.getFilePlanBySiteId(RM_SITE_ID)).thenReturn(filePlanNodeRef);
NodeRef transferContainerNodeRef = AlfMock.generateNodeRef(mockedNodeService);
when(mockedFilePlanService.getTransferContainer(filePlanNodeRef)).thenReturn(transferContainerNodeRef);
NodeRef holdContainerNodeRef = AlfMock.generateNodeRef(mockedNodeService);
when(mockedFilePlanService.getHoldContainer(filePlanNodeRef)).thenReturn(holdContainerNodeRef);
when(mockedFilePlanService.getUnfiledContainer(filePlanNodeRef)).thenReturn(nodeRef);
try
{
rmNodesImpl.deleteNode(nodeRef.getId(), mockedParameters);
fail("Expected ecxeption as Unfiled Records container can't be deleted.");
}
catch(PermissionDeniedException ex)
{
assertEquals("Cannot delete: " + nodeRef.getId(), ex.getMsgId());
}
verify(mockedFileFolderService, never()).delete(nodeRef);
}
private void setupCompanyHomeAndPrimaryParent(NodeRef nodeRef)
{
NodeRef companyHomeNodeRef = AlfMock.generateNodeRef(mockedNodeService);