Merged V3.3-BUG-FIX to HEAD

20954: Calendar Dashlet updates. Fixes: ALF-2907 (meeting workspace issue)
   20968: Minor VersionableAspect fix to onDeleteNode policy firing (follow-on for r19507)
   20981: Removed Install Jammer installers from V3.3.3
   20982: AVMTestSuite - run PurgeTestP after AVMServiceTest (investigating ALF-3611)
   20997: Fix for ALF-2605 - updated share-config-custom.xml.sample and removed obsolete extension files
   21030: Pulled XAMConnector AMP into main 3.3SP3 codeline.  Apart from build changes (incl. EOL), there are no repo changes.
   21032: StoreSelector passes through NodeContentContext allowing stores access to node information
   21036: Fix ALF-245: Can't delete space that contains "translation without content"
      - Delete triggers 'unmakeTranslation'
      - Empty translations are marked with sys:temporary before being deleted
   21051: More on fix ALF-245.  Reduced complexity by not deleting empty translations twice
   21064: Merged V3.3 to V3.3-BUG_FIX
      20898: Merged HEAD to V3.3
         20724: AVMTestSuite - temporarily comment out PurgeTestP
            - TODO: investigate intermittent test failure
      20903: Incremented version revision
      20921: AVM - fix purge store so that vr nodes are actually orphaned (ALF-3627)
      20952: Fix for ALF-3704: Module conflict - Alfresco web client config property page missing metadata. 
         This is application of a fix made to the config service in a hotfix. The change provides a deterministic load order for config files loaded via the ConfigBootstrap spring bean. More importantly it means that config files loaded by modules on different machines in a cluster load in the same order.

         The forms client and AWE config files have been updated to take advantage of the new loading order.
      21061: Merged PATCHES/V3.1.2 to V3.3 (RECORD ONLY)
         20890: ALF-3687: Apply LUCENE-1383 patch to Lucene 2.1.0 to reduce memory leaks from ThreadLocals
         20891: ALF-3687: Build classpath fix
         20892: Incremented version label
      21062: Merged PATCHES/V3.2.1 to V3.3
         20897: (RECORD ONLY) Incremented version label
         20901: (RECORD ONLY) ALF-3740: Merged V3.3 to PATCHES/V3.2.1
            20524: VersionMigrator - option to run as scheduled job (ALF-1000)
         20904: (RECORD ONLY) ALF-3732: Merged PATCHES/V3.2.r to PATCHES/V3.2.1
            19803: ALF-558: File servers (CIFS / FTP / NFS) can now handle concurrent write operations on Alfresco repository
               - ContentDiskDriver / AVMDiskDriver now use retrying transactions for write operations
               - Disable EagerContentStoreCleaner on ContentDiskDriver / AVMDiskDriver closeFile() operations so that they may be retried after rollback (Sony zero byte problem)
               - Allow manual association of AVM ContentData with nodes so that closeFile() may be retried
               - Propagation of new argument through AVM interfaces
         20905: (RECORD ONLY) ALF-3732: Rolled back the now unnecessary reference()/dereference() stuff from ALF-558
         20906: (RECORD ONLY) ALF-3732: Merged DEV/V3.3-BUG-FIX to PATCHES/V3.2.1
            20623: Fix for ALF-3188 : Access Denied when updating doc via CIFS
         20907: (RECORD ONLY) ALF-3732: Merged V3.3 to PATCHES/V3.2.1
            20173: Propagate IOExceptions from retryable write transactions in AlfrescoDiskDriver
         20950: ALF-3779: Upgrades on large repositories from v2.1 and v2.2 were failing on MySQL due to "The total number of locks exceeds the lock table size" errors
            - Solution was to add support for new --BEGIN TXN and --END TXN comments and execute LOCK TABLES statements in the same transaction as large INSERT - SELECT statements.
         20990: ALF-3789: Concurrency issues with InMemoryTicketComponentImpl
            - Previous ETHREEOH-1842 method of caching web session 'ref counts' against tickets could cause tickets to unpredictably fall out of the transactional cache
            - Rolled back original ETHREEOH-1842 fix. Would be too much overhead to keep these ref counts consistent across a cluster.
            - Instead, avoid invalidating tickets on web session timeout and only do it on explicit log out.
            - Now tickets maintained in non-transactional shared cache so they can't drop out unpredictably
            - Logic for ticket inactivity timeout caching improved so that it should work across a cluster
         20991: (RECORD ONLY) Incremented version label
         20993: ALF-3789: Fixed Spring configuration backward compatibily issue with previous fix
            - Ticket cache bean name restored to ticketsCache. This is actually now a non-transactional cache.
            - Also externalized parameters so that they can now be controlled by alfresco-global.properties without any bean overrides
               authentication.ticket.ticketsExpire=false
               authentication.ticket.expiryMode=AFTER_FIXED_TIME
               authentication.ticket.validDuration=PT1H
         20994: Eclipse classpath fixes for unit testing after ant build
         21057: ALF-3592: PassthruCifsAuthenticator now auto-creates / imports users who do not already exist in Alfresco
            - At least one of the following properties must be true for this to happen
               synchronization.autoCreatePeopleOnLogin
               synchronization.syncWhenMissingPeopleLogIn
            - Also improved debug logging of unknown passthru domains
      21063: Merged PATCHES/V3.2.r to V3.3
         21037: ALF-3793: Final attempt at realigning saved XForm data with a modified Schema
            - removeRemovedNodes / insertUpdatedNodes / insertPrototypeNodes replaced by a one stop recursive process that builds a new instance tree from scratch
            - Nodes copied over in correct order
            - Missing nodes added in and extra nodes discarded
            - Prototype nodes appended at appropriate points
         21038: (RECORD ONLY) Incremented version label


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21065 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/web/forms/xforms/Schema2XForms.java

@@ -71,8 +71,10 @@ import org.w3c.dom.Attr;
 import org.w3c.dom.Comment;
 import org.w3c.dom.Document;
 import org.w3c.dom.Element;
+import org.w3c.dom.NamedNodeMap;
 import org.w3c.dom.Node;
 import org.w3c.dom.NodeList;
+import org.w3c.dom.Text;
 
 /**
  * An abstract implementation of the Schema2XForms interface allowing
@@ -234,7 +236,7 @@ public class Schema2XForms implements Serializable
             {
                continue;
             }
-            final String prefix = this.addNamespace(xformsDocument.getDocumentElement(),
+            final String prefix = addNamespace(xformsDocument.getDocumentElement(),
                                                     schemaDocument.lookupPrefix(schemaNamespaces.item(i)),
                                                     schemaNamespaces.item(i));
             if (LOGGER.isDebugEnabled())
@@ -273,7 +275,7 @@ public class Schema2XForms implements Serializable
       this.setXFormsId(instanceElement);
 
       final Element defaultInstanceDocumentElement = xformsDocument.createElement(rootElementName);
-      this.addNamespace(defaultInstanceDocumentElement,
+      addNamespace(defaultInstanceDocumentElement,
                         NamespaceConstants.XMLSCHEMA_INSTANCE_PREFIX,
                         NamespaceConstants.XMLSCHEMA_INSTANCE_NS);
       if (this.targetNamespace != null)
@@ -287,21 +289,21 @@ public class Schema2XForms implements Serializable
                       " to xform and default instance element");
          }
          
-         this.addNamespace(defaultInstanceDocumentElement,
+         addNamespace(defaultInstanceDocumentElement,
                            targetNamespacePrefix,
                            this.targetNamespace);
-         this.addNamespace(xformsDocument.getDocumentElement(),
+         addNamespace(xformsDocument.getDocumentElement(),
                            targetNamespacePrefix,
                            this.targetNamespace);
       }
 
-      Element importedInstanceDocumentElement = null;
+      Element prototypeInstanceElement = null;
       if (instanceDocument == null || instanceDocument.getDocumentElement() == null)
       {
          instanceElement.appendChild(defaultInstanceDocumentElement);
       }
       else
-      {
+      {         
          Element instanceDocumentElement = instanceDocument.getDocumentElement();
          if (!instanceDocumentElement.getNodeName().equals(rootElementName))
          {
@@ -312,16 +314,8 @@ public class Schema2XForms implements Serializable
          
          if (LOGGER.isDebugEnabled())
             LOGGER.debug("[buildXForm] importing rootElement from other document");
-         
-         importedInstanceDocumentElement = (Element)
-            xformsDocument.importNode(instanceDocumentElement, true);
-         //add XMLSchema instance NS
-         this.addNamespace(importedInstanceDocumentElement,
-                           NamespaceConstants.XMLSCHEMA_INSTANCE_PREFIX,
-                           NamespaceConstants.XMLSCHEMA_INSTANCE_NS);
-         instanceElement.appendChild(importedInstanceDocumentElement);
 
-         final Element prototypeInstanceElement =
+         prototypeInstanceElement =
             xformsDocument.createElementNS(NamespaceConstants.XFORMS_NS,
                                            NamespaceConstants.XFORMS_PREFIX + ":instance");
          modelSection.appendChild(prototypeInstanceElement);
@@ -349,18 +343,10 @@ public class Schema2XForms implements Serializable
       }
       this.setXFormsId(rootGroup, "alfresco-xforms-root-group");
 
-      if (importedInstanceDocumentElement != null)
+      if (prototypeInstanceElement != null)
       {
-         Schema2XForms.removeRemovedNodes(importedInstanceDocumentElement,
-                                          defaultInstanceDocumentElement,
-                                          schemaNamespacesMap);
-         Schema2XForms.insertUpdatedNodes(importedInstanceDocumentElement,
-                                          defaultInstanceDocumentElement,
-                                          schemaNamespacesMap);
-         Schema2XForms.insertPrototypeNodes(importedInstanceDocumentElement,
-                                            defaultInstanceDocumentElement,
-                                            schemaNamespacesMap);
-         
+         Schema2XForms.rebuildInstance(prototypeInstanceElement, instanceDocument,
+               instanceElement, schemaNamespacesMap);
       }
 
       this.createSubmitElements(xformsDocument, modelSection, rootGroup);
@@ -388,364 +374,179 @@ public class Schema2XForms implements Serializable
       this.counter.clear();
    }
 
-   /**
-    * Inserts nodes that exist in the prototype document that are absent in the imported instance.
-    * This is to handle the case where a schema has been updated since the last time the
-    * imported document was modified.
-    *
-    * @param instanceDocumentElement the user provided instance document
-    * @param prototypeInstanceElement the generated prototype instance document
-    * @param schemaNamespaces the namespaces used by the instance document needed for
-    * initializing the xpath context.
-    */
    @SuppressWarnings("unchecked")
-   public static void insertUpdatedNodes(final Element instanceDocumentElement,
-                                         final Element prototypeDocumentElement,
-                                         final HashMap<String, String> schemaNamespaces)
+   public static void rebuildInstance(final Node prototypeNode, final Node oldInstanceNode,
+         final Node newInstanceNode,
+
+         final HashMap<String, String> schemaNamespaces)
    {
-      if (LOGGER.isDebugEnabled())
-         LOGGER.debug("[insertUpdatedNodes] updating imported instance document");
-      
-      final JXPathContext prototypeContext =
-         JXPathContext.newContext(prototypeDocumentElement);
-      prototypeContext.registerNamespace(NamespaceService.ALFRESCO_PREFIX,
-                                         NamespaceService.ALFRESCO_URI);
-      final JXPathContext instanceContext =
-         JXPathContext.newContext(instanceDocumentElement);
-      instanceContext.registerNamespace(NamespaceService.ALFRESCO_PREFIX,
-                                        NamespaceService.ALFRESCO_URI);
+      final JXPathContext prototypeContext = JXPathContext.newContext(prototypeNode);
+      prototypeContext.registerNamespace(NamespaceService.ALFRESCO_PREFIX, NamespaceService.ALFRESCO_URI);
+      final JXPathContext instanceContext = JXPathContext.newContext(oldInstanceNode);
+      instanceContext.registerNamespace(NamespaceService.ALFRESCO_PREFIX, NamespaceService.ALFRESCO_URI);
 
-      // identify all non prototype elements in the prototypeDocument
       for (final String prefix : schemaNamespaces.keySet())
       {
          prototypeContext.registerNamespace(prefix, schemaNamespaces.get(prefix));
          instanceContext.registerNamespace(prefix, schemaNamespaces.get(prefix));
       }
 
-      final Iterator it =
-         prototypeContext.iteratePointers("//*[not(@" + NamespaceService.ALFRESCO_PREFIX +
-                                          ":prototype='true')] | //@*[name()!='" + NamespaceService.ALFRESCO_PREFIX + 
-                                          ":prototype']");
+      // Evaluate non-recursive XPaths for all prototype elements at this level
+      final Iterator<Pointer> it = prototypeContext.iteratePointers("*");
       while (it.hasNext())
       {
-         final Pointer p = (Pointer)it.next();
-         if (LOGGER.isDebugEnabled())
-         {
-            LOGGER.debug("[insertUpdatedNodes] evaluating prototype node " + p.asPath() +
-                         " normalized " + p.asPath().replaceAll("\\[\\d+\\]", ""));
-         }
+         final Pointer p = it.next();
+         Element proto = (Element) p.getNode();
+         String path = p.asPath();
+         // check if this is a prototype element with the attribute set
+         boolean isPrototype = proto.hasAttributeNS(NamespaceService.ALFRESCO_URI, "prototype")
+               && proto.getAttributeNS(NamespaceService.ALFRESCO_URI, "prototype").equals("true");
 
-         String path = p.asPath().replaceAll("\\[\\d+\\]", "");
-         if (path.lastIndexOf("/") == 0)
+         // We shouldn't locate a repeatable child with a fixed path
+         if (isPrototype)
          {
-            if (instanceContext.selectNodes(path).size() == 0)
+            path = path.replaceAll("\\[(\\d+)\\]", "[position() >= $1]");
+            if (LOGGER.isDebugEnabled())
             {
-               if (LOGGER.isDebugEnabled())
-                  LOGGER.debug("[insertUpdatedNodes] copying " + path + " into imported instance");
-               
-               // remove child elements - we want attributes but don't want to
-               // copy any potential prototyp nodes
-               final Node clone = ((Node)p.getNode()).cloneNode(true);
-               if (clone instanceof Attr)
-               {
-                  instanceDocumentElement.setAttributeNode((Attr)clone);
-               }
-               else
-               {
-                  final NodeList children = clone.getChildNodes();
-                  for (int i = 0; i < children.getLength(); i++)
-                  {
-                     if (children.item(i) instanceof Element)
-                     {
-                        clone.removeChild(children.item(i));
-                     }
-                  }
-                  instanceDocumentElement.appendChild(clone);
-               }
+               LOGGER.debug("[rebuildInstance] evaluating prototyped nodes " + path);
             }
          }
          else
          {
-            // change path /foo/bar into /foo[not(child::bar)]
-            if (path.indexOf("@") >= 0)
-            {
-               path = path.replaceAll("\\/(@.+)$", "[not($1)]");
-            }
-            else
-            {
-               path = path.replaceAll("\\/([^/]+)$", "[not(child::$1)]");
-            }
-            final List<Node> l = (List<Node>)instanceContext.selectNodes(path);
-            
             if (LOGGER.isDebugEnabled())
             {
-               LOGGER.debug("[insertUpdatedNodes] appending node " + ((Node)p.getNode()).getNodeName() +
-                            " to the " + l.size() + " selected nodes matching path " + path);
-            }
-            
-            for (Node n : l)
-            {
-               // remove child elements - we want attributes but don't want to
-               // copy any potential prototyp nodes
-               final Node clone = ((Node)p.getNode()).cloneNode(true);
-               if (clone instanceof Attr)
-               {
-                  ((Element)n).setAttributeNode((Attr)clone);
-               }
-               else
-               {
-                  final NodeList children = clone.getChildNodes();
-                  for (int i = 0; i < children.getLength(); i++)
-                  {
-                     if (children.item(i) instanceof Element)
-                     {
-                        clone.removeChild(children.item(i));
-                     }
-                  }
-                  n.appendChild(clone);
-               }
-            }
+               LOGGER.debug("[rebuildInstance] evaluating child node with positional path " + path);
+            }            
          }
-      }
-   }
 
-   @SuppressWarnings("unchecked")
-   public static void removeRemovedNodes(final Element instanceDocumentElement, final Element prototypeDocumentElement,
-         final HashMap<String, String> schemaNamespaces)
-   {
-      if (LOGGER.isDebugEnabled())
-         LOGGER.debug("[removeRemovedNodes] updating imported instance document");
+         Document newInstanceDocument = newInstanceNode.getOwnerDocument(); 
 
-      final JXPathContext prototypeContext = JXPathContext.newContext(prototypeDocumentElement);
-      prototypeContext.registerNamespace(NamespaceService.ALFRESCO_PREFIX, NamespaceService.ALFRESCO_URI);
-      final JXPathContext instanceContext = JXPathContext.newContext(instanceDocumentElement);
-      instanceContext.registerNamespace(NamespaceService.ALFRESCO_PREFIX, NamespaceService.ALFRESCO_URI);
-
-      for (final String prefix : schemaNamespaces.keySet())
-      {
-         prototypeContext.registerNamespace(prefix, schemaNamespaces.get(prefix));
-         instanceContext.registerNamespace(prefix, schemaNamespaces.get(prefix));
-      }
-
-      // Check all elements and attributes in the instance document
-      OUTER: for (;;)
-      {
-         final Iterator<Pointer> it = instanceContext.iteratePointers("//* | //@*");
-         while (it.hasNext())
+         // Locate the corresponding nodes in the instance document
+         List<Node> l = (List<Node>) instanceContext.selectNodes(path);
+         
+         // If the prototype node isn't a prototype element, copy it in as a missing node, complete with all its children. We won't need to recurse on this node
+         if (l.isEmpty())
          {
-            final Pointer p = it.next();
-            String path = p.asPath().replaceAll("\\[\\d+\\]", "");
-            if (LOGGER.isDebugEnabled())
+            if (!isPrototype)
             {
-               LOGGER.debug("[removeRemovedNodes] evaluating instance node " + p.asPath() + " normalized "
-                     + path + " in prototype document");
-            }
+               LOGGER.debug("[rebuildInstance] copying in missing node " + proto.getNodeName() + " to "
+                     + XMLUtil.buildXPath(newInstanceNode, newInstanceDocument.getDocumentElement()));
 
-            final List<Node> l = (List<Node>) prototypeContext.selectNodes(path);
-            if (l.isEmpty())
-            {
-               final Node node = (Node) p.getNode();
-               if (LOGGER.isDebugEnabled())
+               // Clone the prototype node and all its children
+               Element clone = (Element)proto.cloneNode(true);
+               newInstanceNode.appendChild(clone);
+               
+               if (oldInstanceNode instanceof Document)
                {
-                  LOGGER.debug("[removeRemovedNodes] removing instance node " + node.getNodeName() +" with no prototype nodes matching path " + path);
-               }
-               if (node instanceof Attr)
-               {
-                  ((Attr) node).getOwnerElement().removeAttributeNode((Attr) node);
-               }
-               else
-               {
-                  node.getParentNode().removeChild(node);
-               }
-
-               // We have removed a node and potentially an entire sub-tree of paths. Restart the search
-               continue OUTER;
+                  // add XMLSchema instance NS
+                  addNamespace(clone, NamespaceConstants.XMLSCHEMA_INSTANCE_PREFIX,
+                        NamespaceConstants.XMLSCHEMA_INSTANCE_NS);
+               }               
             }
          }
-         // We completed the search
-         break OUTER;
-      }
-
-   }
+         else
+         {
+            // Otherwise, append the matches from the old instance document in order
+            for (Node old : l)
+            {
+               Element oldEl = (Element)old;
    
-   /**
-    * Inserts prototype nodes into the provided instance document by aggregating insertion
-    * points from the generated prototype instance docment.
-    *
-    * @param instanceDocumentElement the user provided instance document
-    * @param prototypeInstanceElement the generated prototype instance document
-    * @param schemaNamespaces the namespaces used by the instance document needed for
-    * initializing the xpath context.
-    */
-   @SuppressWarnings("unchecked")
-   public static void insertPrototypeNodes(final Element instanceDocumentElement,
-                                           final Element prototypeDocumentElement,
-                                           final HashMap<String, String> schemaNamespaces)
-   {
-      final JXPathContext prototypeContext =
-         JXPathContext.newContext(prototypeDocumentElement);
-      prototypeContext.registerNamespace(NamespaceService.ALFRESCO_PREFIX,
-                                         NamespaceService.ALFRESCO_URI);
-      final JXPathContext instanceContext =
-         JXPathContext.newContext(instanceDocumentElement);
-      instanceContext.registerNamespace(NamespaceService.ALFRESCO_PREFIX,
-                                        NamespaceService.ALFRESCO_URI);
-      for (final String prefix : schemaNamespaces.keySet())
-      {
-         prototypeContext.registerNamespace(prefix, schemaNamespaces.get(prefix));
-         instanceContext.registerNamespace(prefix, schemaNamespaces.get(prefix));
-      }
+               // Copy the old instance element rather than cloning it, so we don't copy over attributes
+               Element clone = newInstanceDocument.createElementNS(oldEl.getNamespaceURI(), oldEl.getTagName());
+               newInstanceNode.appendChild(clone);
+               
+               if (oldInstanceNode instanceof Document)
+               {
+                  // add XMLSchema instance NS
+                  addNamespace(clone, NamespaceConstants.XMLSCHEMA_INSTANCE_PREFIX,
+                        NamespaceConstants.XMLSCHEMA_INSTANCE_NS);
+               }
+               
+               // Copy over child text if this is not a complex type
+               boolean isEmpty = true;
+               for (Node n = old.getFirstChild(); n != null; n = n.getNextSibling())
+               {
+                  if (n instanceof Text)
+                  {
+                     clone.appendChild(newInstanceDocument.importNode(n, false));
+                     isEmpty = false;
+                  }
+                  else if (n instanceof Element)
+                  {
+                     break;
+                  }
+               }
+
+               // Check the nil attribute
+               if (oldEl.getAttributeNS(NamespaceConstants.XMLSCHEMA_INSTANCE_NS, "nil").equals("true"))
+               {
+                  clone.setAttributeNS(NamespaceConstants.XMLSCHEMA_INSTANCE_NS,
+                        NamespaceConstants.XMLSCHEMA_INSTANCE_PREFIX + ":nil", "true");
+               }
+               
+               // Copy over attributes present in the prototype
+               NamedNodeMap attributes = proto.getAttributes();
+               for (int i = 0; i < attributes.getLength(); i++)
+               {
+                  Attr attribute = (Attr) attributes.item(i);
+                  String localName = attribute.getLocalName();
+                  if (localName == null)
+                  {
+                     String name = attribute.getName();
+                     if (oldEl.hasAttribute(name))
+                     {
+                        clone.setAttributeNode((Attr) newInstanceDocument.importNode(oldEl.getAttributeNode(name),
+                              false));
+                     }
+                     else
+                     {
+                        LOGGER.debug("[rebuildInstance] copying in missing attribute " + attribute.getNodeName()
+                              + " to " + XMLUtil.buildXPath(clone, newInstanceDocument.getDocumentElement()));
+
+                        clone.setAttributeNode((Attr) attribute.cloneNode(false));
+                     }
+                  }
+                  else
+                  {
+                     String namespace = attribute.getNamespaceURI();
+                     if (!((!isEmpty
+                           && (namespace.equals(NamespaceConstants.XMLSCHEMA_INSTANCE_NS) && localName.equals("nil")) || (namespace
+                           .equals(NamespaceService.ALFRESCO_URI) && localName.equals("prototype")))))
+                     {
+                        if (oldEl.hasAttributeNS(namespace, localName))
+                        {
+                           clone.setAttributeNodeNS((Attr) newInstanceDocument.importNode(oldEl.getAttributeNodeNS(
+                                 namespace, localName), false));
+                        }
+                        else
+                        {
+                           LOGGER.debug("[rebuildInstance] copying in missing attribute " + attribute.getNodeName()
+                                 + " to " + XMLUtil.buildXPath(clone, newInstanceDocument.getDocumentElement()));
+
+                           clone.setAttributeNodeNS((Attr) attribute.cloneNode(false));
+                        }
+                     }
+                  }
+               }
 
-      class PrototypeInsertionData
-      {
-         final Node prototype;
-         final List<Node> nodes;
-         final boolean append;
-
-         PrototypeInsertionData(final Node prototype,
-                                final List<Node> nodes,
-                                final boolean append)
-         {
-            this.prototype = prototype;
-            this.nodes = nodes;
-            this.append = append;
+               // recurse on children
+               rebuildInstance(proto, oldEl, clone, schemaNamespaces);
+            }
          }
-      };
 
-      final HashMap<String, PrototypeInsertionData> prototypesToInsert = 
-         new HashMap<String, PrototypeInsertionData>();
-      // find all prototype nodes
-      final Iterator it =
-         prototypeContext.iteratePointers("//*[@" + NamespaceService.ALFRESCO_PREFIX +
-                                          ":prototype='true'][ancestor::*[not(@" + NamespaceService.ALFRESCO_PREFIX +
-                                          ":prototype)]]");
-
-      // find all relevant insertion points within the instance document
-      while (it.hasNext())
-      {
-         final Pointer p = (Pointer)it.next();
-         if (LOGGER.isDebugEnabled())
-         {
-            LOGGER.debug("[insertPrototypeNodes] evaluating prototype node " + p.asPath());
-         }
-         String path = p.asPath().replaceAll("\\[\\d+\\]", "") + "[last()]";
-         if (prototypesToInsert.containsKey(path))
+         // Now add in a new copy of the prototype
+         if (isPrototype)
          {
             if (LOGGER.isDebugEnabled())
             {
-               LOGGER.debug("[insertPrototypeNodes] already checked path " + path + " - ignoring.");
+               LOGGER.debug("[rebuildInstance] appending "
+                     + proto.getNodeName()
+                     + " to "
+                     + XMLUtil.buildXPath(newInstanceNode, newInstanceDocument
+                           .getDocumentElement()));
             }
-            continue;
-         }
-
-         if (LOGGER.isDebugEnabled())
-         {
-            LOGGER.debug("[insertPrototypeNodes] evaluating " + path + " against instance document");
-         }
-
-         List<Node> l = (List<Node>)instanceContext.selectNodes(path);
-         if (l.size() != 0)
-         {
-            // this is a 1 to n repeat - add a prototype node to the list of repeat instances
-            if (LOGGER.isDebugEnabled())
-            {
-               LOGGER.debug("[insertPrototypeNodes] path " + path + " evaluated to " + l.size() + " nodes");
-            }
-            prototypesToInsert.put(path, new PrototypeInsertionData((Node)p.getNode(),
-                                                                    l,
-                                                                    false));
-         }
-
-         if (path.lastIndexOf("/") != 0)
-         {
-            // this could be a 0 to n repeat - check if there are any relevant parent
-            // insertion points
-            path = path.replaceAll("\\/([^/]+)\\[last\\(\\)\\]$", "[not(child::$1)]");
-
-            l = (List<Node>)instanceContext.selectNodes(path);
-            if (LOGGER.isDebugEnabled())
-            {
-               LOGGER.debug("[insertPrototypeNodes] path " + path + " evaluated to " + l.size() + " nodes");
-            }
-            prototypesToInsert.put(path, new PrototypeInsertionData((Node)p.getNode(),
-                                                                    l,
-                                                                    true));
-         }
-         else 
-         {
-            // this could be a repeat at the root of the document
-            path = path.replaceAll("\\[last\\(\\)\\]$", "");
-            l = (List<Node>)instanceContext.selectNodes(path);
-            if (LOGGER.isDebugEnabled())
-            {
-               LOGGER.debug("[insertPrototypeNodes] path " + path + " evaluated to " + l.size() + " nodes");
-            }
-            if (l.size() == 0)
-            {
-               l.add(instanceDocumentElement);
-               prototypesToInsert.put(path, new PrototypeInsertionData((Node)p.getNode(),
-                                                                       l,
-                                                                       true));
-            }
-         }
-      }
-
-      // apply prototype nodes to all discovered insertion points
-      if (LOGGER.isDebugEnabled())
-      {
-         LOGGER.debug("[insertPrototypeNodes] instance dcoument before mutation =\n" + 
-                      XMLUtil.toString(instanceDocumentElement, true));
-      }
-      for (Map.Entry<String, PrototypeInsertionData> me : prototypesToInsert.entrySet())
-      {
-         final PrototypeInsertionData data = me.getValue();
-         if (LOGGER.isDebugEnabled())
-         {
-            LOGGER.debug("[insertPrototypeNodes] adding prototype for " + data.prototype.getNodeName() + 
-                         " from path " + me.getKey() +
-                         " to " + data.nodes.size() + " nodes");
-         }
-
-         for (final Node n : data.nodes)
-         {
-            if (data.append)
-            {
-               if (LOGGER.isDebugEnabled())
-               {
-                  LOGGER.debug("[insertPrototypeNodes] appending " + data.prototype.getNodeName() +
-                               " to " + XMLUtil.buildXPath(n, instanceDocumentElement));
-               }
-               n.appendChild(data.prototype.cloneNode(true));
-            }
-            else if (n.getNextSibling() != null)
-            {
-               if (LOGGER.isDebugEnabled())
-               {
-                  LOGGER.debug("[insertPrototypeNodes] inserting " + data.prototype.getNodeName() +
-                               " into " + XMLUtil.buildXPath(n.getParentNode(), 
-                                                             instanceDocumentElement) +
-                               " before " + XMLUtil.buildXPath(n.getNextSibling(),
-                                                               instanceDocumentElement));
-               }
-               n.getParentNode().insertBefore(data.prototype.cloneNode(true),
-                                              n.getNextSibling());
-            }
-            else
-            {
-               if (LOGGER.isDebugEnabled())
-               {
-                  LOGGER.debug("[insertPrototypeNodes] appending " + data.prototype.getNodeName() +
-                               " to " + XMLUtil.buildXPath(n.getParentNode(),
-                                                           instanceDocumentElement));
-               }
-               n.getParentNode().appendChild(data.prototype.cloneNode(true));
-            }
-         }
-         if (LOGGER.isDebugEnabled())
-         {
-            LOGGER.debug("[insertPrototypeNodes] instance dcoument after mutation =\n" + 
-                         XMLUtil.toString(instanceDocumentElement, true));
-         }
+            newInstanceNode.appendChild(proto.cloneNode(true));
+         }         
       }
    }
 
@@ -2349,19 +2150,19 @@ public class Schema2XForms implements Serializable
       xformsDocument.appendChild(envelopeElement);
 
       //set namespace attribute
-      this.addNamespace(envelopeElement,
+      addNamespace(envelopeElement,
                         NamespaceConstants.XHTML_PREFIX,
                         NamespaceConstants.XHTML_NS);
-      this.addNamespace(envelopeElement,
+      addNamespace(envelopeElement,
                         NamespaceConstants.XFORMS_PREFIX,
                         NamespaceConstants.XFORMS_NS);
-      this.addNamespace(envelopeElement,
+      addNamespace(envelopeElement,
                         NamespaceConstants.XMLEVENTS_PREFIX,
                         NamespaceConstants.XMLEVENTS_NS);
-      this.addNamespace(envelopeElement,
+      addNamespace(envelopeElement,
                         NamespaceConstants.XMLSCHEMA_INSTANCE_PREFIX,
                         NamespaceConstants.XMLSCHEMA_INSTANCE_NS);
-      this.addNamespace(envelopeElement,
+      addNamespace(envelopeElement,
                         NamespaceService.ALFRESCO_PREFIX,
                         NamespaceService.ALFRESCO_URI);
 
@@ -3164,9 +2965,7 @@ public class Schema2XForms implements Serializable
       return elementName;
    }
 
-   private String addNamespace(final Element e,
-                               String nsPrefix,
-                               final String ns)
+   private static String addNamespace(final Element e, String nsPrefix, final String ns)
    {
       String prefix;
       if ((prefix = NamespaceResolver.getPrefix(e, ns)) != null)