inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-24 17:32:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rhinoscript Engine:

Browse Source 
- Remove ability to import any java package - this is not secure.
- Small code update (instanceof instead of class comparison) after Kev review

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@3490 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
David Caruana
2006-08-14 09:51:12 +00:00
parent cddf5ac2ab
commit 5460feaaee
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
source/java/org/alfresco/repo/jscript/RhinoScriptService.java
View File

@@ -223,11 +223,8 @@ public class RhinoScriptService implements ScriptService
{ {
// The easiest way to embed Rhino is just to create a new scope this way whenever // The easiest way to embed Rhino is just to create a new scope this way whenever
// you need one. However, initStandardObjects is an expensive method to call and it // you need one. However, initStandardObjects is an expensive method to call and it
// allocates a fair amount of memory. ImporterTopLevel provides a scope allowing // allocates a fair amount of memory.
// the import of java classes and packages.
Scriptable topLevelScope = new ImporterTopLevel(cx);
Scriptable scope = cx.initStandardObjects(); Scriptable scope = cx.initStandardObjects();
scope.setParentScope(topLevelScope);
// insert supplied object model into root of the default scope // insert supplied object model into root of the default scope
if (model != null) if (model != null)
@@ -254,7 +251,7 @@ public class RhinoScriptService implements ScriptService
Object result = cx.evaluateReader(scope, reader, "AlfrescoScript", 1, null); Object result = cx.evaluateReader(scope, reader, "AlfrescoScript", 1, null);
// extract java object result if wrapped by rhinoscript // extract java object result if wrapped by rhinoscript
if (result != null && result.getClass().equals(NativeJavaObject.class)) if (result != null && result instanceof NativeJavaObject)
{ {
result = Context.jsToJava(result, Object.class); result = Context.jsToJava(result, Object.class);
} }