inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-24 17:32:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

MNT-22135 Filter policy to only run on admin auth - Unit test (#275)

Browse Source 
Created unit test testIfGroupIsAdminAuthority to check if public method isAdminAuthority correctly validates groups:
* Verify it can identify GROUP_ALFRESCO_ADMINISTRATORS as an admin group
* Verify created groups (non administrators) and users are not considered administrators
* Add a subgroup to the parent group and verify if its still identified as non admin
* Add the group to the administrators group and verify if both group and subgroup are identified correctly as admins
* Add the user to the subgroup and verify if he's an admin
* Create a group with the same name as an admin user, group should not be identified as admin
This commit is contained in:
evasques
2021-02-08 10:53:35 +00:00
committed by GitHub
parent 1776a43a30
commit 592dde531f
1 changed files with 56 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
repository/src/test/java/org/alfresco/repo/security/authority/AuthorityServiceTest.java
View File

@@ -1717,6 +1717,62 @@ public class AuthorityServiceTest extends TestCase
} }
} }
public void testIfGroupIsAdminAuthority()
{
String adminGroup = "GROUP_ALFRESCO_ADMINISTRATORS";
String parentGroup = "parentGroup";
String subGroup1 = "subGroup1";
String subGroup2 = "subGroup2";
String username = "johnsnow";
HashMap<QName, Serializable> properties = new HashMap<>();
properties.put(ContentModel.PROP_USERNAME, username);
personService.createPerson(properties);
pubAuthorityService.createAuthority(AuthorityType.GROUP, parentGroup);
pubAuthorityService.createAuthority(AuthorityType.GROUP, subGroup1);
pubAuthorityService.createAuthority(AuthorityType.GROUP, subGroup2);
// Verify it can identify GROUP_ALFRESCO_ADMINISTRATORS as an admin group
assertTrue(pubAuthorityService.isAdminAuthority(adminGroup));
// Verify the created groups and users are not administrators
assertFalse(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, parentGroup)));
assertFalse(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, subGroup1)));
assertFalse(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, subGroup2)));
assertFalse(pubAuthorityService.isAdminAuthority(username));
// Add a subgroup to the parent group and verify if its still identified as non admin
pubAuthorityService.addAuthority(pubAuthorityService.getName(AuthorityType.GROUP, parentGroup),
pubAuthorityService.getName(AuthorityType.GROUP, subGroup1));
assertFalse(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, parentGroup)));
assertFalse(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, subGroup1)));
// Add the group to the administrators group and if both group and subgroup are identified correctly as admins
pubAuthorityService.addAuthority(adminGroup, pubAuthorityService.getName(AuthorityType.GROUP, parentGroup));
assertTrue(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, parentGroup)));
assertTrue(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, subGroup1)));
// Add another subgroup to the parent group - the subgroup should automatically become an admin
pubAuthorityService.addAuthority(pubAuthorityService.getName(AuthorityType.GROUP, parentGroup),
pubAuthorityService.getName(AuthorityType.GROUP, subGroup2));
assertTrue(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, subGroup2)));
// Add the user to a subgroup and verify if he's an admin
pubAuthorityService.addAuthority(pubAuthorityService.getName(AuthorityType.GROUP, subGroup2), username);
assertTrue(pubAuthorityService.isAdminAuthority(username));
// Create a group with the same name as an admin user, group should not be identified as admin
pubAuthorityService.createAuthority(AuthorityType.GROUP, username);
assertFalse(pubAuthorityService.isAdminAuthority(pubAuthorityService.getName(AuthorityType.GROUP, username)));
//Cleanup created authorities
pubAuthorityService.deleteAuthority(pubAuthorityService.getName(AuthorityType.GROUP, parentGroup));
pubAuthorityService.deleteAuthority(pubAuthorityService.getName(AuthorityType.GROUP, subGroup1));
pubAuthorityService.deleteAuthority(pubAuthorityService.getName(AuthorityType.GROUP, subGroup2));
pubAuthorityService.deleteAuthority(pubAuthorityService.getName(AuthorityType.GROUP, username));
personService.deletePerson(username);
}
private <T extends Policy> T createClassPolicy(Class<T> policyInterface, QName policyQName, QName triggerOnClass) private <T extends Policy> T createClassPolicy(Class<T> policyInterface, QName policyQName, QName triggerOnClass)
{ {
T policy = mock(policyInterface); T policy = mock(policyInterface);