inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-24 17:32:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed auth null from list of available authentication types in the AlfrescoRpcAuthenticator.

Browse Source 
Allow null RPC request to run without needing an authenticated session. Fix for AR-1605.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@6266 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Gary Spencer
2007-07-16 14:55:44 +00:00
parent 72cdb81f47
commit 5ade7cb377
2 changed files with 43 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
source/java/org/alfresco/filesys/server/auth/AlfrescoRpcAuthenticator.java
View File

@@ -55,7 +55,7 @@ public class AlfrescoRpcAuthenticator implements RpcAuthenticator {
// Authentication types aupported by this implementation // Authentication types aupported by this implementation
private int[] _authTypes = { AuthType.Null, AuthType.Unix }; private int[] _authTypes = { AuthType.Unix };
// UID/GID to username conversions // UID/GID to username conversions

61
source/java/org/alfresco/filesys/server/oncrpc/nfs/NFSServer.java
View File

@@ -424,10 +424,13 @@ public class NFSServer extends RpcNetworkServer implements RpcProcessor {
} }
catch (RpcAuthenticationException ex) { catch (RpcAuthenticationException ex) {
// Failed to authenticate the RPC client // Failed to authenticate the RPC client, return an error unless the request is the 'null' request
rpc.buildAuthFailResponse(ex.getAuthenticationErrorCode()); if ( rpc.getProcedureId() != NFS.ProcNull)
return rpc; {
rpc.buildAuthFailResponse(ex.getAuthenticationErrorCode());
return rpc;
}
} }
// Position the RPC buffer pointer at the start of the call parameters // Position the RPC buffer pointer at the start of the call parameters
@@ -582,25 +585,28 @@ public class NFSServer extends RpcNetworkServer implements RpcProcessor {
// Commit, or rollback, any active user transaction // Commit, or rollback, any active user transaction
try if ( nfsSess != null)
{ {
// Commit or rollback the transaction try
{
nfsSess.endTransaction(); // Commit or rollback the transaction
}
catch ( Exception ex) nfsSess.endTransaction();
{ }
// Debug catch ( Exception ex)
{
if ( logger.isDebugEnabled()) // Debug
logger.debug("Error committing transaction", ex);
} if ( logger.isDebugEnabled())
logger.debug("Error committing transaction", ex);
}
}
} }
finally finally
{ {
// If there is an active transaction then roll it back // If there is an active transaction then roll it back
if ( nfsSess.hasUserTransaction()) if ( nfsSess != null && nfsSess.hasUserTransaction())
{ {
try try
{ {
@@ -4126,7 +4132,24 @@ public class NFSServer extends RpcNetworkServer implements RpcProcessor {
// Setup the authentication context for the request // Setup the authentication context for the request
getRpcAuthenticator().setCurrentUser( sess, sess.getClientInformation()); try
{
getRpcAuthenticator().setCurrentUser( sess, sess.getClientInformation());
}
catch ( Throwable ex)
{
sess = null;
// DEBUG
if (logger.isDebugEnabled() && hasDebugFlag(DBG_ERROR))
logger.debug("RPC Authencation Exception: " + ex.toString());
}
// Check if the session is valid
if ( sess == null)
throw new RpcAuthenticationException(Rpc.AuthBadCred);
// Return the server session // Return the server session