inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-14 17:58:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

ALF-9153 Avoid fetching too much un-used data when rendering a Discussions Topic to JSON with the reply count

Browse Source 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@29773 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Nick Burch
2011-08-15 16:44:47 +00:00
parent d5de16b4ba
commit 5ae9918204
1 changed files with 28 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
source/java/org/alfresco/repo/web/scripts/discussion/AbstractDiscussionWebScript.java
View File

@@ -293,24 +293,36 @@ public abstract class AbstractDiscussionWebScript extends DeclarativeWebScript
*/ */
protected Map<String, Object> renderTopic(TopicInfo topic, SiteInfo site) protected Map<String, Object> renderTopic(TopicInfo topic, SiteInfo site)
{ {
// Fetch all the posts for the topic // Fetch the primary post
// TODO We actually only need the count, the first and the last PostInfo primaryPost = discussionService.getPrimaryPost(topic);
// In the interest of keeping our life simply, get all of them if(primaryPost == null)
PagingRequest paging = new PagingRequest(MAX_QUERY_ENTRY_COUNT);
paging.setRequestTotalCountMax(MAX_QUERY_ENTRY_COUNT);
PagingResults<PostInfo> posts = discussionService.listPosts(topic, paging);
// Ensure we got a primary post
if(posts.getPage().size() == 0)
{ {
throw new WebScriptException(Status.STATUS_PRECONDITION_FAILED, throw new WebScriptException(Status.STATUS_PRECONDITION_FAILED,
"First (primary) post was missing from the topic, can't fetch"); "First (primary) post was missing from the topic, can't fetch");
} }
// Grab the posts of interest // Fetch the most recent reply
PostInfo primaryPost = posts.getPage().get(0); PostInfo mostRecentPost = discussionService.getMostRecentPost(topic);
// The posts in a topic listing are ordered by created date
PostInfo mostRecentPost = posts.getPage().get(posts.getPage().size()-1); // Find out how many replies there are
int numReplies;
if(mostRecentPost.getNodeRef().equals( primaryPost.getNodeRef() ))
{
// Only the one post in the topic
mostRecentPost = null;
numReplies = 0;
}
else
{
// Use this trick to get the number of posts in the topic,
// but without needing to get lots of data and objects
PagingRequest paging = new PagingRequest(1);
paging.setRequestTotalCountMax(MAX_QUERY_ENTRY_COUNT);
PagingResults<PostInfo> posts = discussionService.listPosts(topic, paging);
// The primary post is in the list, so exclude from the reply count
numReplies = posts.getTotalResultCount().getFirst() - 1;
}
// Build the details // Build the details
Map<String, Object> item = new HashMap<String, Object>(); Map<String, Object> item = new HashMap<String, Object>();
@@ -321,10 +333,10 @@ public abstract class AbstractDiscussionWebScript extends DeclarativeWebScript
item.put(KEY_AUTHOR, buildPerson(topic.getCreator())); item.put(KEY_AUTHOR, buildPerson(topic.getCreator()));
// The reply count is one less than all posts (first is the primary one) // The reply count is one less than all posts (first is the primary one)
item.put("totalReplyCount", posts.getTotalResultCount().getFirst() - 1); item.put("totalReplyCount", numReplies);
// We want details on the most recent post // We want details on the most recent post
if(posts.getPage().size() > 1) if(mostRecentPost != null)
{ {
item.put("lastReply", mostRecentPost.getNodeRef()); item.put("lastReply", mostRecentPost.getNodeRef());
item.put("lastReplyBy", buildPerson(mostRecentPost.getCreator())); item.put("lastReplyBy", buildPerson(mostRecentPost.getCreator()));