inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-10-08 14:51:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Resolved PMD scan warnings

Browse Source
This commit is contained in:
Manish Kumar
2023-07-14 20:41:58 +05:30
parent bd8fbe2918
commit 5e0ea61a56
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
repository/src/main/java/org/alfresco/repo/doclink/DocumentLinkServiceImpl.java
View File

@@ -75,7 +75,7 @@ import org.springframework.extensions.surf.util.I18NUtil;
*/ */
public class DocumentLinkServiceImpl implements DocumentLinkService, NodeServicePolicies.BeforeDeleteNodePolicy public class DocumentLinkServiceImpl implements DocumentLinkService, NodeServicePolicies.BeforeDeleteNodePolicy
{ {
private static Log logger = LogFactory.getLog(DocumentLinkServiceImpl.class); private static final Log logger = LogFactory.getLog(DocumentLinkServiceImpl.class);
protected static final String CANNED_QUERY_GET_DOC_LINKS = "getDoclinkNodesCannedQueryFactory"; protected static final String CANNED_QUERY_GET_DOC_LINKS = "getDoclinkNodesCannedQueryFactory";
@@ -95,7 +95,7 @@ public class DocumentLinkServiceImpl implements DocumentLinkService, NodeService
/* I18N labels */ /* I18N labels */
private static final String LINK_TO_LABEL = "doclink_service.link_to_label"; private static final String LINK_TO_LABEL = "doclink_service.link_to_label";
private boolean isNodePendingDelete = false; private boolean isNodePendingDelete;
/** /**
* The initialise method. Register our policies. * The initialise method. Register our policies.
@@ -168,22 +168,21 @@ public class DocumentLinkServiceImpl implements DocumentLinkService, NodeService
String newName = sourceName + LINK_NODE_EXTENSION; String newName = sourceName + LINK_NODE_EXTENSION;
newName = I18NUtil.getMessage(LINK_TO_LABEL, newName); newName = I18NUtil.getMessage(LINK_TO_LABEL, newName);
Map<QName, Serializable> props = new HashMap<QName, Serializable>(); Map<QName, Serializable> props = new HashMap<>();
props.put(ContentModel.PROP_NAME, newName); props.put(ContentModel.PROP_NAME, newName);
props.put(ContentModel.PROP_LINK_DESTINATION, source); props.put(ContentModel.PROP_LINK_DESTINATION, source);
props.put(ContentModel.PROP_TITLE, newName); props.put(ContentModel.PROP_TITLE, newName);
props.put(ContentModel.PROP_DESCRIPTION, newName); props.put(ContentModel.PROP_DESCRIPTION, newName);
QName assocQName = QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, QName.createValidLocalName(newName));
ChildAssociationRef childRef = null;
QName sourceType = nodeService.getType(source);
if (checkOutCheckInService.isWorkingCopy(source) || nodeService.hasAspect(source, ContentModel.ASPECT_LOCKABLE)) if (checkOutCheckInService.isWorkingCopy(source) || nodeService.hasAspect(source, ContentModel.ASPECT_LOCKABLE))
{ {
throw new IllegalArgumentException("Cannot perform operation since the node (id:" + source.getId() + ") is locked."); throw new IllegalArgumentException("Cannot perform operation since the node (id:" + source.getId() + ") is locked.");
} }
ChildAssociationRef childRef;
QName sourceType = nodeService.getType(source);
QName assocQName = QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, QName.createValidLocalName(newName));
try try
{ {
if (dictionaryService.isSubClass(sourceType, ContentModel.TYPE_CONTENT)) if (dictionaryService.isSubClass(sourceType, ContentModel.TYPE_CONTENT))