Coding standards.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@34548 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

source/java/org/alfresco/repo/webdav/MTNodesCache2.java

@@ -22,7 +22,8 @@ import java.util.List;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
-import org.alfresco.repo.security.authentication.AuthenticationContext;
+import javax.servlet.ServletException;
+
 import org.alfresco.repo.security.authentication.AuthenticationUtil;
 import org.alfresco.repo.tenant.TenantService;
 import org.alfresco.service.cmr.repository.NodeRef;
@@ -42,22 +43,19 @@ import org.alfresco.util.PropertyCheck;
 public class MTNodesCache2
 {
     private boolean enabled = false;
-    
     private NodeService nodeService;
-
     private SearchService searchService;
-
     private NamespaceService namespaceService;
-
     private TenantService tenantService;
-
     private Map<String, NodeRef> nodesCache = new ConcurrentHashMap<String, NodeRef>();
-
     private NodeRef defaultNode = null;
-    
     private String storeName;
     private String rootPath;
     
+    
+    /**
+     * Spring bean init method
+     */
     public void init()
     {
         PropertyCheck.mandatory(this, "nodeService", getNodeService());
@@ -72,6 +70,7 @@ public class MTNodesCache2
     {
         this.nodeService = nodeService;
     }
+    
     public NodeService getNodeService()
     {
         return nodeService;
@@ -106,7 +105,6 @@ public class MTNodesCache2
         return result;
     }
 
-    
     public void onBootstrap()
     {
         if (!enabled)
@@ -147,7 +145,6 @@ public class MTNodesCache2
         }
     }
     
-    
     /**
      * @return Returns the name of the store
      * @throws ServletException if the store name was not set
@@ -156,6 +153,7 @@ public class MTNodesCache2
     {
         return storeName;
     }
+    
     public void setStoreName(String storeName)
     {
         this.storeName = storeName;
@@ -169,6 +167,7 @@ public class MTNodesCache2
     {
         return rootPath;
     }
+    
     public void setRootPath(String rootPath)
     {
         this.rootPath = rootPath;
@@ -203,15 +202,14 @@ public class MTNodesCache2
     {
         return tenantService;
     }
+    
     public boolean getEnabled()
     {
         return enabled;
     }
+    
     public void setEnabled(boolean enabled)
     {
         this.enabled = enabled;
     }
-    
-
-
 }

source/java/org/alfresco/repo/webdav/WebDavServiceImpl.java

@@ -36,7 +36,7 @@ import org.springframework.extensions.surf.util.URLEncoder;
 
 /**
  * The WebDav client is used by the repository to generate webdav URLs
- * 
+ * <p>
  * This is a bog standard spring bean for the repo side of WebDav.
  * 
  * @See org.alfresco.repo.webdav.WebDavServlet the server side of webdav.
@@ -45,30 +45,23 @@ import org.springframework.extensions.surf.util.URLEncoder;
  */
 public class WebDavServiceImpl implements WebDavService
 {
-    private boolean enabled = false;
+    public static final String WEBDAV_PREFIX = "webdav"; 
     
+    private static Log logger = LogFactory.getLog(WebDavServiceImpl.class);
+    
+    private boolean enabled = false;
     
     private NodeService nodeService;
     private DictionaryService dictionaryService;
     private FileFolderService fileFolderService;
   
-    
-    private static Log logger = LogFactory.getLog(WebDavServiceImpl.class);
-    
     // Root nodes
     private MTNodesCache2 rootNode;
     
-    public static final String WEBDAV_PREFIX = "webdav"; 
-    
-    public boolean getEnabled()
-    {
-        return enabled;
-    }
-    public void setEnabled(boolean enabled)
-    {
-        this.enabled = enabled;
-    }
     
+    /**
+     * Spring bean init method
+     */
     public void init()
     {
         PropertyCheck.mandatory(this, "nodeService", getNodeService());
@@ -85,9 +78,11 @@ public class WebDavServiceImpl implements WebDavService
      */
     public String getWebdavUrl(NodeRef nodeRef)
     {
+        String url = "";
+        
         if (!enabled)
         {
-            return "";
+            return url;
         }
         
         try
@@ -107,15 +102,14 @@ public class WebDavServiceImpl implements WebDavService
                     path.append("/")
                         .append(URLEncoder.encode(paths.get(i).getName()));
                 }
-                return path.toString();
+                url = path.toString();
             }
         }
         catch (FileNotFoundException nodeErr)
         {
-            // cannot build path if file no longer exists
+            // cannot build path if file no longer exists, return default
-            return "";
         }
-        return "";
+        return url;
     }
     
     /**
@@ -138,34 +132,51 @@ public class WebDavServiceImpl implements WebDavService
         return isDocument;
     }
     
+    public boolean getEnabled()
+    {
+        return enabled;
+    }
+    
+    public void setEnabled(boolean enabled)
+    {
+        this.enabled = enabled;
+    }
+    
     public void setNodeService(NodeService nodeService)
     {
         this.nodeService = nodeService;
     }
+    
     public NodeService getNodeService()
     {
         return nodeService;
     }
+    
     public void setDictionaryService(DictionaryService dictionaryService)
     {
         this.dictionaryService = dictionaryService;
     }
+    
     public DictionaryService getDictionaryService()
     {
         return dictionaryService;
     }
+    
     public void setFileFolderService(FileFolderService fileFolderService)
     {
         this.fileFolderService = fileFolderService;
     }
+    
     public FileFolderService getFileFolderService()
     {
         return fileFolderService;
     }
+    
     public void setRootNode(MTNodesCache2 rootNode)
     {
         this.rootNode = rootNode;
     }
+    
     public MTNodesCache2 getRootNode()
     {
         return rootNode;