Freeze indicator now only shows if the user has permission to 'read' at least one of the holds (RM-1210)

* see RM-1372, RM-1373
 * added unit test
 * fixed FIXME in page object



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@66958 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261

rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/evaluator/FrozenEvaluator.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2011 Alfresco Software Limited.
+ * Copyright (C) 2005-2014 Alfresco Software Limited.
  *
  * This file is part of Alfresco
  *
@@ -18,17 +18,42 @@
  */
 package org.alfresco.module.org_alfresco_module_rm.jscript.app.evaluator;
 
+import java.util.List;
+
+import org.alfresco.module.org_alfresco_module_rm.hold.HoldService;
 import org.alfresco.module.org_alfresco_module_rm.jscript.app.BaseEvaluator;
 import org.alfresco.service.cmr.repository.NodeRef;
 
 /**
+ * Freeze indicator.
+ * <p>
+ * Only shows as frozen if the user can 'read' the holds 
+ * that hold the nodeRef.
+ * 
  * @author Roy Wetherall
  */
 public class FrozenEvaluator extends BaseEvaluator
 {
+    /** hold service */
+    private HoldService holdService;
+    
+    /**
+     * @param holdService   hold service
+     */
+    public void setHoldService(HoldService holdService)
+    {
+        this.holdService = holdService;
+    }
+    
+    /**
+     * Only indicate the node is frozen if the user can 'read' at least one of the holds
+     * 
+     * @see org.alfresco.module.org_alfresco_module_rm.jscript.app.BaseEvaluator#evaluateImpl(org.alfresco.service.cmr.repository.NodeRef)
+     */
     @Override
     protected boolean evaluateImpl(NodeRef nodeRef)
     {
-        return freezeService.isFrozen(nodeRef);
+        List<NodeRef> heldBy = holdService.heldBy(nodeRef, true);
+        return !heldBy.isEmpty();
     }
 }