inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-10-08 14:51:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MNT-24127] Added Endpoint to Calculate Size of the folder with Integration Test Cases [ags][tas]

Browse Source
This commit is contained in:
mohit-singh4
2024-07-02 16:55:49 +05:30
parent 87ea4444d4
commit 5f7b97b6a2
2 changed files with 11 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
remote-api/src/main/java/org/alfresco/rest/api/nodes/NodeFolderSizeRelation.java
View File

@@ -80,6 +80,7 @@ public class NodeFolderSizeRelation implements CalculateSize<Map<String, Object>
private ActionTrackingService actionTrackingService; private ActionTrackingService actionTrackingService;
private Action folderSizeAction; private Action folderSizeAction;
private String exceptionMessage = "Invalid parameter: value of nodeId is invalid"; private String exceptionMessage = "Invalid parameter: value of nodeId is invalid";
private InvalidNodeTypeException invalidNodeTypeException;
/** /**
* The logger * The logger
@@ -151,7 +152,8 @@ public class NodeFolderSizeRelation implements CalculateSize<Map<String, Object>
if(!"folder".equals(qName.getLocalName())) if(!"folder".equals(qName.getLocalName()))
{ {
makeErrorResponse(new InvalidNodeTypeException(exceptionMessage),422); invalidNodeTypeException = new InvalidNodeTypeException(exceptionMessage);
return (Map<String, Object>) new ErrorResponse(invalidNodeTypeException.getMsgId(), 422, invalidNodeTypeException.getLocalizedMessage(), invalidNodeTypeException.getStackTrace(), invalidNodeTypeException.getAdditionalState());
} }
try try
@@ -181,11 +183,19 @@ public class NodeFolderSizeRelation implements CalculateSize<Map<String, Object>
public Map<String, Object> readById(String nodeId, String id, Parameters parameters) public Map<String, Object> readById(String nodeId, String id, Parameters parameters)
{ {
NodeRef nodeRef = nodes.validateNode(nodeId); NodeRef nodeRef = nodes.validateNode(nodeId);
// Check node type.
QName qName = nodeService.getType(nodeRef);
Object resultAction; Object resultAction;
Map<String, Object> result = new HashMap<>(); Map<String, Object> result = new HashMap<>();
validatePermissions(nodeRef, nodeId); validatePermissions(nodeRef, nodeId);
validateNodeType(nodeRef); validateNodeType(nodeRef);
if(!"folder".equals(qName.getLocalName()))
{
invalidNodeTypeException = new InvalidNodeTypeException(exceptionMessage);
return (Map<String, Object>) new ErrorResponse(invalidNodeTypeException.getMsgId(), 422, invalidNodeTypeException.getLocalizedMessage(), invalidNodeTypeException.getStackTrace(), invalidNodeTypeException.getAdditionalState());
}
try try
{ {
LOG.info("Retrieving OUTPUT from ActionExecutor in NodeFolderSizeRelation:readById"); LOG.info("Retrieving OUTPUT from ActionExecutor in NodeFolderSizeRelation:readById");
@@ -246,14 +256,6 @@ public class NodeFolderSizeRelation implements CalculateSize<Map<String, Object>
private void validateNodeType(NodeRef nodeRef) private void validateNodeType(NodeRef nodeRef)
{ {
// Check node type.
QName qName = nodeService.getType(nodeRef);
if (!"folder".equals(qName.getLocalName()))
{
makeErrorResponse(new InvalidNodeTypeException(exceptionMessage),422);
}
if(folderSizeAction!=null) if(folderSizeAction!=null)
{ {
String errorInAction = (String) folderSizeAction.getParameterValue(NodeSizeActionExecuter.ERROR); String errorInAction = (String) folderSizeAction.getParameterValue(NodeSizeActionExecuter.ERROR);

9
remote-api/src/test/java/org/alfresco/rest/api/tests/NodeFolderSizeApiTest.java
View File

@@ -181,15 +181,6 @@ public class NodeFolderSizeApiTest extends AbstractBaseApiTest
NodeTarget tgt = new NodeTarget(); NodeTarget tgt = new NodeTarget();
tgt.setTargetParentId(folderId); tgt.setTargetParentId(folderId);
HttpResponse response = post(getFolderSizeUrl(UUID.randomUUID().toString()), toJsonAsStringNonNull(tgt), null, 404); HttpResponse response = post(getFolderSizeUrl(UUID.randomUUID().toString()), toJsonAsStringNonNull(tgt), null, 404);
assertNotNull(response);
// create node
Node n = new Node();
n.setName("temp1");
n.setNodeType("retention");
response = post(getFolderSizeUrl(n.getName()), RestApiUtil.toJsonAsStringNonNull(n), 422);
assertNotNull(response); assertNotNull(response);
} }