ACS-5506 Add missing annotations, hasSubgroups not required

packaging/tests/tas-restapi/src/main/java/org/alfresco/rest/model/RestGroupsModel.java

@@ -42,7 +42,7 @@ public class RestGroupsModel extends TestModel implements IRestModel<RestGroupsM
     private String description;
     @JsonProperty(required = true)
     private Boolean isRoot;
-    @JsonProperty(required = true)
+    @JsonProperty()
     private Boolean hasSubgroups;
 
     @JsonProperty("parentIds")

repository/src/main/java/org/alfresco/repo/security/authority/AuthorityDAOImpl.java

@@ -1444,6 +1444,7 @@ public class AuthorityDAOImpl implements AuthorityDAO, NodeServicePolicies.Befor
         nodeService.setProperty(ref, ContentModel.PROP_AUTHORITY_DISPLAY_NAME, authorityDisplayName);
     }
 
+    @Override
     public Pair<String, String> getAuthorityDisplayNameAndDescription(String authorityName)
     {
         NodeRef ref = getAuthorityOrNull(authorityName);
@@ -1456,6 +1457,7 @@ public class AuthorityDAOImpl implements AuthorityDAO, NodeServicePolicies.Befor
         return new Pair<>(DefaultTypeConverter.INSTANCE.convert(String.class, displayName), DefaultTypeConverter.INSTANCE.convert(String.class, description));
     }
 
+    @Override
     public void setAuthorityDisplayNameAndDescription(String authorityName, String authorityDisplayName, String description)
     {
         NodeRef ref = getAuthorityOrNull(authorityName);

repository/src/main/java/org/alfresco/repo/security/authority/AuthorityServiceImpl.java

@@ -700,6 +700,7 @@ public class AuthorityServiceImpl implements AuthorityService, InitializingBean
     /**
      * {@inheritDoc}
      */
+    @Override
     public Pair<String, String> getAuthorityDisplayNameAndDescription(String name)
     {
         Pair<String, String> displayNameAndDescription = authorityDAO.getAuthorityDisplayNameAndDescription(name);
@@ -713,6 +714,7 @@ public class AuthorityServiceImpl implements AuthorityService, InitializingBean
     /**
      * {@inheritDoc}
      */
+    @Override
     public void setAuthorityDisplayNameAndDescription(String authorityName, String authorityDisplayName, String description)
     {
         AuthorityType type = AuthorityType.getAuthorityType(authorityName);

repository/src/test/java/org/alfresco/repo/security/authority/AuthorityServiceTest.java

@@ -1433,6 +1433,7 @@ public class AuthorityServiceTest extends TestCase
         assertEquals(pubAuthorityService.getAuthorityDisplayName("Monkey"), "Monkey");
     }
 
+    @Test
     public void testAuthorityDisplayNameAndDescription()
     {
         Map<QName, Serializable> props = new HashMap<>();