diff --git a/source/java/org/alfresco/web/app/AlfrescoNavigationHandler.java b/source/java/org/alfresco/web/app/AlfrescoNavigationHandler.java index 84fe5144f4..f49cad9122 100644 --- a/source/java/org/alfresco/web/app/AlfrescoNavigationHandler.java +++ b/source/java/org/alfresco/web/app/AlfrescoNavigationHandler.java @@ -110,7 +110,11 @@ public class AlfrescoNavigationHandler extends NavigationHandler { // there is an overidden outcome so extract it outcome = outcome.substring(idx+1, outcome.length()); - + + // we also need to empty the dialog stack if we have been given + // an overidden outcome as we could be going anywhere in the app + getViewStack(context).clear(); + if (logger.isDebugEnabled()) logger.debug("Closing dialog with an overridden outcome of '" + outcome + "'"); @@ -123,15 +127,10 @@ public class AlfrescoNavigationHandler extends NavigationHandler // log a warning and return a null outcome to stay on the same page if (logger.isWarnEnabled()) { - logger.warn("Attempting to close a dialog with an empty view stack, returning 'browse' outcome"); + logger.warn("Attempting to close a dialog with an empty view stack, returning null outcome"); } - // TODO: change this back to returning null outcome as that - // will highlight any areas we have neglected to launch - // in a dilaog, for backwards compatibility for the short - // term return 'browse' outcome. - - this.origHandler.handleNavigation(context, fromAction, "browse"); + this.origHandler.handleNavigation(context, fromAction, null); } } else diff --git a/source/java/org/alfresco/web/bean/BrowseBean.java b/source/java/org/alfresco/web/bean/BrowseBean.java index 5597cfe59d..16ef142b38 100644 --- a/source/java/org/alfresco/web/bean/BrowseBean.java +++ b/source/java/org/alfresco/web/bean/BrowseBean.java @@ -1181,7 +1181,8 @@ public class BrowseBean implements IContextListener setActionSpace(null); // setting the outcome will show the browse view again - outcome = "browse"; + outcome = AlfrescoNavigationHandler.CLOSE_DIALOG_OUTCOME + + AlfrescoNavigationHandler.DIALOG_SEPARATOR + "browse"; } catch (Throwable err) { @@ -1220,7 +1221,8 @@ public class BrowseBean implements IContextListener setDocument(null); // setting the outcome will show the browse view again - outcome = "browse"; + outcome = AlfrescoNavigationHandler.CLOSE_DIALOG_OUTCOME + + AlfrescoNavigationHandler.DIALOG_SEPARATOR + "browse"; } catch (Throwable err) { diff --git a/source/java/org/alfresco/web/bean/wizard/NewSpaceWizard.java b/source/java/org/alfresco/web/bean/wizard/NewSpaceWizard.java index 75899812db..94b1d73818 100644 --- a/source/java/org/alfresco/web/bean/wizard/NewSpaceWizard.java +++ b/source/java/org/alfresco/web/bean/wizard/NewSpaceWizard.java @@ -709,7 +709,11 @@ public class NewSpaceWizard extends AbstractWizardBean // the first icon in the list the default icons = new ArrayList(iconsCfg.getChildCount()); - this.icon = iconName; + if (this.icon == null) + { + // set the default if it is not already + this.icon = iconName; + } first = false; } diff --git a/source/web/jsp/browse/browse.jsp b/source/web/jsp/browse/browse.jsp index 5165b2ac43..bf35741874 100644 --- a/source/web/jsp/browse/browse.jsp +++ b/source/web/jsp/browse/browse.jsp @@ -107,7 +107,7 @@ - + @@ -311,7 +311,7 @@ - + @@ -479,7 +479,7 @@ - + diff --git a/source/web/jsp/dialog/delete-file.jsp b/source/web/jsp/dialog/delete-file.jsp index fbb01aa0d6..da36180684 100644 --- a/source/web/jsp/dialog/delete-file.jsp +++ b/source/web/jsp/dialog/delete-file.jsp @@ -127,7 +127,7 @@ - + diff --git a/source/web/jsp/dialog/delete-space.jsp b/source/web/jsp/dialog/delete-space.jsp index f482acc96e..93ccb65fc6 100644 --- a/source/web/jsp/dialog/delete-space.jsp +++ b/source/web/jsp/dialog/delete-space.jsp @@ -143,7 +143,7 @@ - + diff --git a/source/web/jsp/dialog/document-details.jsp b/source/web/jsp/dialog/document-details.jsp index 93184e0708..5e5303c74b 100644 --- a/source/web/jsp/dialog/document-details.jsp +++ b/source/web/jsp/dialog/document-details.jsp @@ -153,7 +153,7 @@ + actionListener="#{BrowseBean.setupContentAction}" action="dialog:deleteFile"> @@ -441,7 +441,7 @@
- +
diff --git a/source/web/jsp/dialog/space-details.jsp b/source/web/jsp/dialog/space-details.jsp index eb9e452a45..320a865030 100644 --- a/source/web/jsp/dialog/space-details.jsp +++ b/source/web/jsp/dialog/space-details.jsp @@ -88,7 +88,7 @@ - +